mirror/Vulkan-Hpp
1
0
Fork 0
mirror of https://github.com/KhronosGroup/Vulkan-Hpp.git synced 2024-10-14 16:32:17 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Merge pull request #634 from asuessenbach/ResultValue

Browse Source 
Add cast operator to reference of UniqueHandle of ResultValue<UniqueHandle>
This commit is contained in:
Andreas Süßenbach 2020-06-17 13:35:30 +02:00 committed by GitHub
commit 8c2d6d7d05
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 47 additions and 46 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
VulkanHppGenerator.cpp
View File

@ -7955,15 +7955,6 @@ namespace std
template <typename Type, typename Dispatch>
struct ResultValue<UniqueHandle<Type,Dispatch>>
{
#ifdef VULKAN_HPP_HAS_NOEXCEPT
ResultValue(Result r, UniqueHandle<Type, Dispatch> & v) VULKAN_HPP_NOEXCEPT
#else
ResultValue(Result r, UniqueHandle<Type, Dispatch>& v)
#endif
: result(r)
, value(v)
{}
#ifdef VULKAN_HPP_HAS_NOEXCEPT
ResultValue(Result r, UniqueHandle<Type, Dispatch> && v) VULKAN_HPP_NOEXCEPT
#else
@ -7978,6 +7969,11 @@ namespace std
operator std::tuple<Result&, UniqueHandle<Type, Dispatch>&>() VULKAN_HPP_NOEXCEPT { return std::tuple<Result&, UniqueHandle<Type, Dispatch>&>(result, value); }
operator UniqueHandle<Type, Dispatch>& () & VULKAN_HPP_NOEXCEPT
{
return value;
}
operator UniqueHandle<Type, Dispatch>() VULKAN_HPP_NOEXCEPT
{
return std::move(value);

6
tests/ResultValue/CMakeLists.txt
View File

@ -26,13 +26,9 @@ set(SOURCES
source_group(headers FILES ${HEADERS})
source_group(sources FILES ${SOURCES})
add_library(ResultValue
add_executable(ResultValue
${HEADERS}
${SOURCES}
)
if (UNIX)
target_link_libraries(ResultValue "-ldl")
endif()
set_target_properties(ResultValue PROPERTIES FOLDER "Tests")

59
tests/ResultValue/ResultValue.cpp
View File

@ -21,34 +21,47 @@
VULKAN_HPP_DEFAULT_DISPATCH_LOADER_DYNAMIC_STORAGE
// Compile only test for issue 589.
void test_conversion()
{
#if defined(VULKAN_DISABLE_IMPLICIT_RESULT_VALUE_CAST)
static_assert(false, "Conversions not enabled");
#endif
void as_value( int ) {}
void as_ref( int & ) {}
void as_rvref( int && ) {}
void as_cref( const int & ) {}
void as_crvref( const int && ) {}
void as_value(int);
void as_ref(int&);
void as_cref(const int&);
void as_rvref(int&&);
void as_crvref(const int&&);
void as_cref( const vk::UniquePipeline & ) {}
int main( int /*argc*/, char ** /*argv*/ )
{
#if defined( VULKAN_DISABLE_IMPLICIT_RESULT_VALUE_CAST )
static_assert( false, "Conversions not enabled" );
#endif
using result = vk::ResultValue<int>;
auto val = result {vk::Result{}, 42};
const auto cval = result {vk::Result{}, 42};
auto val = result{ vk::Result{}, 42 };
const auto cval = result{ vk::Result{}, 42 };
as_value(val);
as_value(cval);
as_value( val );
as_value( cval );
as_ref(val);
//as_ref(cval); // should fail
as_cref(val);
as_cref(cval);
as_ref( val );
// as_ref(cval); // should fail
as_cref( val );
as_cref( cval );
as_rvref(std::move(val));
//as_rvref(std::move(cval)); // should fail
as_crvref(std::move(val));
as_crvref(std::move(cval));
as_rvref( std::move( val ) );
// as_rvref(std::move(cval)); // should fail
as_crvref( std::move( val ) );
as_crvref( std::move( cval ) );
vk::Pipeline pipe( VkPipeline( 0x8 ) ); // fake a Pipeline here, to have something different from zero
vk::UniquePipeline pipeline( pipe );
vk::ResultValue<vk::UniquePipeline> rv( {}, std::move( pipeline ) );
as_cref( rv ); // does not move out handle
assert( rv.value );
auto p = std::move( rv.value );
p.release(); // release the faked Pipeline, to prevent error on trying to destroy it
return 0;
}

14
vulkan/vulkan.hpp
View File

@ -15887,15 +15887,6 @@ namespace VULKAN_HPP_NAMESPACE
template <typename Type, typename Dispatch>
struct ResultValue<UniqueHandle<Type, Dispatch>>
{
# ifdef VULKAN_HPP_HAS_NOEXCEPT
ResultValue( Result r, UniqueHandle<Type, Dispatch> & v ) VULKAN_HPP_NOEXCEPT
# else
ResultValue( Result r, UniqueHandle<Type, Dispatch> & v )
# endif
: result( r )
, value( v )
{}
# ifdef VULKAN_HPP_HAS_NOEXCEPT
ResultValue( Result r, UniqueHandle<Type, Dispatch> && v ) VULKAN_HPP_NOEXCEPT
# else
@ -15913,6 +15904,11 @@ namespace VULKAN_HPP_NAMESPACE
return std::tuple<Result &, UniqueHandle<Type, Dispatch> &>( result, value );
}
operator UniqueHandle<Type, Dispatch> &() & VULKAN_HPP_NOEXCEPT
{
return value;
}
operator UniqueHandle<Type, Dispatch>() VULKAN_HPP_NOEXCEPT
{
return std::move( value );