mirror/glfw
1
0
Fork 0
mirror of https://github.com/glfw/glfw.git synced 2024-11-14 10:34:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

Allow to set initial surface swap interval

Browse Source 
After creating surface context in _glfwPlatformCreateWindow function
proceeds with reading context parameters in _glfwRefreshContextAttribs,
which ends with clearing the front buffer when double buffering is
enabled.

Such buffer clearing implicitly calls swapBuffer, which may not behave
properly with the default swap interval. And user has no control to
override this swap interval value with the glfwSwapInterval, because
latter may only be called after the glfwCreateWindow, when it is too
late.

Either clearing buffer should be disablable, or user should have
control on the initial swap interval value before implicit swapBuffer
is invoked.

This patch implements latter by introducing GLFW_SWAP_INTERVAL window
hint. Default value is -1, which matches current policy of avoiding
to override swap interval.
This commit is contained in:
Daniel Levin 2023-08-21 05:00:05 -07:00
parent 3eaf1255b2
commit 23ef05dd79
4 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
include/GLFW/glfw3.h
View File

@ -939,6 +939,8 @@ extern "C" {
*/
#define GLFW_POSITION_Y 0x0002000F
#define GLFW_SWAP_INTERVAL 0x00020010
/*! @brief Framebuffer bit depth hint.
*
* Framebuffer bit depth [hint](@ref GLFW_RED_BITS).

3
src/context.c
View File

@ -364,6 +364,9 @@ GLFWbool _glfwRefreshContextAttribs(_GLFWwindow* window,
previous = _glfwPlatformGetTls(&_glfw.contextSlot);
glfwMakeContextCurrent((GLFWwindow*) window);
if (window->swapInterval != -1)
window->context.swapInterval(window->swapInterval);
window->context.GetIntegerv = (PFNGLGETINTEGERVPROC)
window->context.getProcAddress("glGetIntegerv");
window->context.GetString = (PFNGLGETSTRINGPROC)

2
src/internal.h
View File

@ -408,6 +408,7 @@ struct _GLFWwndconfig
GLFWbool focusOnShow;
GLFWbool mousePassthrough;
GLFWbool scaleToMonitor;
int swapInterval;
struct {
GLFWbool retina;
char frameName[256];
@ -532,6 +533,7 @@ struct _GLFWwindow
GLFWbool focusOnShow;
GLFWbool mousePassthrough;
GLFWbool shouldClose;
int swapInterval;
void* userPointer;
GLFWbool doublebuffer;
GLFWvidmode videoMode;

5
src/window.c
View File

@ -235,6 +235,7 @@ GLFWAPI GLFWwindow* glfwCreateWindow(int width, int height,
window->focusOnShow = wndconfig.focusOnShow;
window->mousePassthrough = wndconfig.mousePassthrough;
window->cursorMode = GLFW_CURSOR_NORMAL;
window->swapInterval = wndconfig.swapInterval;
window->doublebuffer = fbconfig.doublebuffer;
@ -276,6 +277,7 @@ void glfwDefaultWindowHints(void)
_glfw.hints.window.focusOnShow = GLFW_TRUE;
_glfw.hints.window.xpos = GLFW_ANY_POSITION;
_glfw.hints.window.ypos = GLFW_ANY_POSITION;
_glfw.hints.window.swapInterval = -1;
// The default is 24 bits of color, 24 bits of depth and 8 bits of stencil,
// double buffered
@ -397,6 +399,9 @@ GLFWAPI void glfwWindowHint(int hint, int value)
case GLFW_MOUSE_PASSTHROUGH:
_glfw.hints.window.mousePassthrough = value ? GLFW_TRUE : GLFW_FALSE;
return;
case GLFW_SWAP_INTERVAL:
_glfw.hints.window.swapInterval = value;
return;
case GLFW_CLIENT_API:
_glfw.hints.context.client = value;
return;