Cleaned up fix for #234.

XFree may not be passed NULL.  An invalid window handle will cause
_glfwGetWindowProperty to not return 1.
This commit is contained in:
Camilla Berglund 2014-02-12 13:02:46 +01:00
parent 135ee0d93f
commit b3c461bd7e

View File

@ -355,7 +355,8 @@ static void detectEWMH(void)
XA_WINDOW,
(unsigned char**) &windowFromRoot) != 1)
{
XFree(windowFromRoot);
if (windowFromRoot)
XFree(windowFromRoot);
return;
}
@ -369,13 +370,12 @@ static void detectEWMH(void)
(unsigned char**) &windowFromChild) != 1)
{
XFree(windowFromRoot);
XFree(windowFromChild);
if (windowFromChild)
XFree(windowFromChild);
return;
}
_glfwReleaseXErrorHandler();
if (_glfw.x11.errorCode != Success)
return;
// It should be the ID of that same child window
if (*windowFromRoot != *windowFromChild)