From ea1958a948b263605d0dbc59cf8e8da5b05ec160 Mon Sep 17 00:00:00 2001 From: Camilla Berglund Date: Fri, 30 Sep 2016 05:31:07 +0200 Subject: [PATCH] Replace sprintf with snprintf --- tests/events.c | 4 ++-- tests/monitors.c | 15 ++++++++------- tests/tearing.c | 8 ++++---- 3 files changed, 14 insertions(+), 13 deletions(-) diff --git a/tests/events.c b/tests/events.c index b0b34e4f..09da5657 100644 --- a/tests/events.c +++ b/tests/events.c @@ -221,7 +221,7 @@ static const char* get_button_name(int button) default: { static char name[16]; - sprintf(name, "%i", button); + snprintf(name, sizeof(name), "%i", button); return name; } } @@ -555,7 +555,7 @@ int main(int argc, char** argv) slots[i].closeable = GLFW_TRUE; slots[i].number = i + 1; - sprintf(title, "Event Linter (Window %i)", slots[i].number); + snprintf(title, sizeof(title), "Event Linter (Window %i)", slots[i].number); if (monitor) { diff --git a/tests/monitors.c b/tests/monitors.c index d8d52f77..77a2a51f 100644 --- a/tests/monitors.c +++ b/tests/monitors.c @@ -59,13 +59,14 @@ static const char* format_mode(const GLFWvidmode* mode) static char buffer[512]; const int gcd = euclid(mode->width, mode->height); - sprintf(buffer, - "%i x %i x %i (%i:%i) (%i %i %i) %i Hz", - mode->width, mode->height, - mode->redBits + mode->greenBits + mode->blueBits, - mode->width / gcd, mode->height / gcd, - mode->redBits, mode->greenBits, mode->blueBits, - mode->refreshRate); + snprintf(buffer, + sizeof(buffer), + "%i x %i x %i (%i:%i) (%i %i %i) %i Hz", + mode->width, mode->height, + mode->redBits + mode->greenBits + mode->blueBits, + mode->width / gcd, mode->height / gcd, + mode->redBits, mode->greenBits, mode->blueBits, + mode->refreshRate); buffer[sizeof(buffer) - 1] = '\0'; return buffer; diff --git a/tests/tearing.c b/tests/tearing.c index 07824e3f..46c51e40 100644 --- a/tests/tearing.c +++ b/tests/tearing.c @@ -79,10 +79,10 @@ static void update_window_title(GLFWwindow* window) { char title[256]; - sprintf(title, "Tearing detector (interval %i%s, %0.1f Hz)", - swap_interval, - (swap_tear && swap_interval < 0) ? " (swap tear)" : "", - frame_rate); + snprintf(title, sizeof(title), "Tearing detector (interval %i%s, %0.1f Hz)", + swap_interval, + (swap_tear && swap_interval < 0) ? " (swap tear)" : "", + frame_rate); glfwSetWindowTitle(window, title); }