mirror/glm
1
0
Fork 0
mirror of https://github.com/g-truc/glm.git synced 2024-11-29 11:24:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1047 from gottfriedleibniz/patch/is_identity

Browse Source 
fix: isIdentity for non-symmetric matrices #1047
This commit is contained in:
Christophe 2020-12-27 16:26:39 +01:00 committed by GitHub
commit 3a25105d86
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
glm/gtx/matrix_query.inl
View File

@ -33,13 +33,13 @@ namespace glm
GLM_FUNC_QUALIFIER bool isIdentity(mat<C, R, T, Q> const& m, T const& epsilon) GLM_FUNC_QUALIFIER bool isIdentity(mat<C, R, T, Q> const& m, T const& epsilon)
{ {
bool result = true; bool result = true;
for(length_t i = 0; result && i < m[0].length() ; ++i) for(length_t i = 0; result && i < m.length(); ++i)
{ {
for(length_t j = 0; result && j < i ; ++j) for(length_t j = 0; result && j < glm::min(i, m[0].length()); ++j)
result = abs(m[i][j]) <= epsilon; result = abs(m[i][j]) <= epsilon;
if(result) if(result && i < m[0].length())
result = abs(m[i][i] - 1) <= epsilon; result = abs(m[i][i] - 1) <= epsilon;
for(length_t j = i + 1; result && j < m.length(); ++j) for(length_t j = i + 1; result && j < m[0].length(); ++j)
result = abs(m[i][j]) <= epsilon; result = abs(m[i][j]) <= epsilon;
} }
return result; return result;