diff --git a/glm/gtx/extended_min_max.inl b/glm/gtx/extended_min_max.inl index 8fc52660..e308c6fe 100644 --- a/glm/gtx/extended_min_max.inl +++ b/glm/gtx/extended_min_max.inl @@ -146,8 +146,8 @@ namespace glm { GLM_STATIC_ASSERT(std::numeric_limits::is_iec559, "'fmin' only accept floating-point input"); - if (isnan(y)) - return x; + if (isnan(x)) + return y; if (isnan(y)) return x; @@ -176,8 +176,8 @@ namespace glm { GLM_STATIC_ASSERT(std::numeric_limits::is_iec559, "'fmax' only accept floating-point input"); - if (isnan(y)) - return x; + if (isnan(x)) + return y; if (isnan(y)) return x; diff --git a/test/gtx/gtx_extended_min_max.cpp b/test/gtx/gtx_extended_min_max.cpp index f071b898..b3c67a88 100644 --- a/test/gtx/gtx_extended_min_max.cpp +++ b/test/gtx/gtx_extended_min_max.cpp @@ -1,4 +1,5 @@ #define GLM_ENABLE_EXPERIMENTAL + #include #include #include @@ -18,6 +19,9 @@ namespace fmin_ glm::vec1 A0 = glm::fmin(glm::vec1(1), glm::vec1(Zero_f / 0.0f)); Error += glm::epsilonEqual(A0.x, 1.0f, glm::epsilon()) ? 0 : 1; + glm::vec1 A1 = glm::fmin(glm::vec1(Zero_f / 0.0f), glm::vec1(1)); + Error += glm::epsilonEqual(A1.x, 1.0f, glm::epsilon()) ? 0 : 1; + glm::vec2 B0 = glm::fmin(glm::vec2(1), glm::vec2(1)); glm::vec2 B1 = glm::fmin(glm::vec2(1), 1.0f); bool B2 = glm::all(glm::equal(B0, B1)); @@ -47,6 +51,9 @@ namespace fmax_ glm::vec1 A0 = glm::fmax(glm::vec1(1), glm::vec1(Zero_f / 0.0f)); Error += glm::epsilonEqual(A0.x, 1.0f, glm::epsilon()) ? 0 : 1; + glm::vec1 A1 = glm::fmax(glm::vec1(Zero_f / 0.0f), glm::vec1(1)); + Error += glm::epsilonEqual(A0.x, 1.0f, glm::epsilon()) ? 0 : 1; + glm::vec2 B0 = glm::fmax(glm::vec2(1), glm::vec2(1)); glm::vec2 B1 = glm::fmax(glm::vec2(1), 1.0f); bool B2 = glm::all(glm::equal(B0, B1));