Apply suggestions from code review

This commit is contained in:
Christophe 2023-12-21 00:52:25 +01:00
parent 5ae05c9296
commit 53302ad486

View File

@ -25,7 +25,6 @@ jobs:
- name: CMake Version - name: CMake Version
run: cmake --version run: cmake --version
- run: cmake -S. -B ./build_auto - run: cmake -S. -B ./build_auto
- run: cmake -S. -B ./build_unknown -DGLM_DISABLE_AUTO_DETECTION=ON
- run: cmake -S. -B ./build_pure_std -DGLM_TEST_FORCE_PURE=ON -DGLM_TEST_ENABLE_CXX_${{matrix.std}}=ON - run: cmake -S. -B ./build_pure_std -DGLM_TEST_FORCE_PURE=ON -DGLM_TEST_ENABLE_CXX_${{matrix.std}}=ON
- run: cmake -S. -B ./build_pure_ext -DGLM_TEST_FORCE_PURE=ON -DGLM_TEST_ENABLE_CXX_${{matrix.std}}=ON -DGLM_TEST_ENABLE_LANG_EXTENSIONS=ON - run: cmake -S. -B ./build_pure_ext -DGLM_TEST_FORCE_PURE=ON -DGLM_TEST_ENABLE_CXX_${{matrix.std}}=ON -DGLM_TEST_ENABLE_LANG_EXTENSIONS=ON
- run: cmake -S. -B ./build_sse2_std -DGLM_TEST_ENABLE_SIMD_SSE2=ON -DGLM_TEST_ENABLE_CXX_${{matrix.std}}=ON - run: cmake -S. -B ./build_sse2_std -DGLM_TEST_ENABLE_SIMD_SSE2=ON -DGLM_TEST_ENABLE_CXX_${{matrix.std}}=ON
@ -35,7 +34,6 @@ jobs:
- run: cmake -S. -B ./build_avx2_std -DGLM_TEST_ENABLE_SIMD_AVX2=ON -DGLM_TEST_ENABLE_CXX_${{matrix.std}}=ON - run: cmake -S. -B ./build_avx2_std -DGLM_TEST_ENABLE_SIMD_AVX2=ON -DGLM_TEST_ENABLE_CXX_${{matrix.std}}=ON
- run: cmake -S. -B ./build_avx2_ext -DGLM_TEST_ENABLE_SIMD_AVX2=ON -DGLM_TEST_ENABLE_CXX_${{matrix.std}}=ON -DGLM_TEST_ENABLE_LANG_EXTENSIONS=ON - run: cmake -S. -B ./build_avx2_ext -DGLM_TEST_ENABLE_SIMD_AVX2=ON -DGLM_TEST_ENABLE_CXX_${{matrix.std}}=ON -DGLM_TEST_ENABLE_LANG_EXTENSIONS=ON
- run: cmake --build ./build_auto --config ${{matrix.config}} - run: cmake --build ./build_auto --config ${{matrix.config}}
- run: cmake --build ./build_unknown --config ${{matrix.config}}
- run: cmake --build ./build_pure_std --config ${{matrix.config}} - run: cmake --build ./build_pure_std --config ${{matrix.config}}
- run: cmake --build ./build_pure_ext --config ${{matrix.config}} - run: cmake --build ./build_pure_ext --config ${{matrix.config}}
- run: cmake --build ./build_sse2_std --config ${{matrix.config}} - run: cmake --build ./build_sse2_std --config ${{matrix.config}}
@ -45,7 +43,6 @@ jobs:
- run: cmake --build ./build_avx2_std --config ${{matrix.config}} - run: cmake --build ./build_avx2_std --config ${{matrix.config}}
- run: cmake --build ./build_avx2_ext --config ${{matrix.config}} - run: cmake --build ./build_avx2_ext --config ${{matrix.config}}
- run: ctest --verbose -C ${{matrix.config}} --test-dir ./build_auto - run: ctest --verbose -C ${{matrix.config}} --test-dir ./build_auto
- run: ctest --verbose -C ${{matrix.config}} --test-dir ./build_unknown
- run: ctest --verbose -C ${{matrix.config}} --test-dir ./build_pure_std - run: ctest --verbose -C ${{matrix.config}} --test-dir ./build_pure_std
- run: ctest --verbose -C ${{matrix.config}} --test-dir ./build_pure_ext - run: ctest --verbose -C ${{matrix.config}} --test-dir ./build_pure_ext
- run: ctest --verbose -C ${{matrix.config}} --test-dir ./build_sse2_std - run: ctest --verbose -C ${{matrix.config}} --test-dir ./build_sse2_std