From a925120716b3638b1b3eac57f7b38300a10dd965 Mon Sep 17 00:00:00 2001 From: Roger Leigh Date: Tue, 15 Apr 2014 10:26:28 +0100 Subject: [PATCH 01/10] cmake: Install FindGLM --- CMakeLists.txt | 6 +- cmake/GNUInstallDirs.cmake | 188 +++++++++++++++++++++++++++++++++++++ util/CMakeLists.txt | 3 + 3 files changed, 196 insertions(+), 1 deletion(-) create mode 100644 cmake/GNUInstallDirs.cmake create mode 100644 util/CMakeLists.txt diff --git a/CMakeLists.txt b/CMakeLists.txt index 6971a678..ab227b1b 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -4,6 +4,9 @@ cmake_policy(VERSION 2.6) project(glm) enable_testing() +list(APPEND CMAKE_MODULE_PATH "${PROJECT_SOURCE_DIR}/cmake") +include(GNUInstallDirs) + add_definitions(-D_CRT_SECURE_NO_WARNINGS) option(GLM_TEST_ENABLE "GLM test" OFF) @@ -129,5 +132,6 @@ include_directories("./test/external") add_subdirectory(glm) add_subdirectory(test) +add_subdirectory(util) -install(DIRECTORY glm DESTINATION include) +install(DIRECTORY glm DESTINATION ${CMAKE_INSTALL_FULL_INCLUDEDIR}) diff --git a/cmake/GNUInstallDirs.cmake b/cmake/GNUInstallDirs.cmake new file mode 100644 index 00000000..4dc2d68a --- /dev/null +++ b/cmake/GNUInstallDirs.cmake @@ -0,0 +1,188 @@ +# - Define GNU standard installation directories +# Provides install directory variables as defined for GNU software: +# http://www.gnu.org/prep/standards/html_node/Directory-Variables.html +# Inclusion of this module defines the following variables: +# CMAKE_INSTALL_ - destination for files of a given type +# CMAKE_INSTALL_FULL_ - corresponding absolute path +# where is one of: +# BINDIR - user executables (bin) +# SBINDIR - system admin executables (sbin) +# LIBEXECDIR - program executables (libexec) +# SYSCONFDIR - read-only single-machine data (etc) +# SHAREDSTATEDIR - modifiable architecture-independent data (com) +# LOCALSTATEDIR - modifiable single-machine data (var) +# LIBDIR - object code libraries (lib or lib64 or lib/ on Debian) +# INCLUDEDIR - C header files (include) +# OLDINCLUDEDIR - C header files for non-gcc (/usr/include) +# DATAROOTDIR - read-only architecture-independent data root (share) +# DATADIR - read-only architecture-independent data (DATAROOTDIR) +# INFODIR - info documentation (DATAROOTDIR/info) +# LOCALEDIR - locale-dependent data (DATAROOTDIR/locale) +# MANDIR - man documentation (DATAROOTDIR/man) +# DOCDIR - documentation root (DATAROOTDIR/doc/PROJECT_NAME) +# Each CMAKE_INSTALL_ value may be passed to the DESTINATION options of +# install() commands for the corresponding file type. If the includer does +# not define a value the above-shown default will be used and the value will +# appear in the cache for editing by the user. +# Each CMAKE_INSTALL_FULL_ value contains an absolute path constructed +# from the corresponding destination by prepending (if necessary) the value +# of CMAKE_INSTALL_PREFIX. + +#============================================================================= +# Copyright 2011 Nikita Krupen'ko +# Copyright 2011 Kitware, Inc. +# +# Distributed under the OSI-approved BSD License (the "License"); +# see accompanying file Copyright.txt for details. +# +# This software is distributed WITHOUT ANY WARRANTY; without even the +# implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. +# See the License for more information. +#============================================================================= +# (To distribute this file outside of CMake, substitute the full +# License text for the above reference.) + +# Installation directories +# +if(NOT DEFINED CMAKE_INSTALL_BINDIR) + set(CMAKE_INSTALL_BINDIR "bin" CACHE PATH "user executables (bin)") +endif() + +if(NOT DEFINED CMAKE_INSTALL_SBINDIR) + set(CMAKE_INSTALL_SBINDIR "sbin" CACHE PATH "system admin executables (sbin)") +endif() + +if(NOT DEFINED CMAKE_INSTALL_LIBEXECDIR) + set(CMAKE_INSTALL_LIBEXECDIR "libexec" CACHE PATH "program executables (libexec)") +endif() + +if(NOT DEFINED CMAKE_INSTALL_SYSCONFDIR) + set(CMAKE_INSTALL_SYSCONFDIR "etc" CACHE PATH "read-only single-machine data (etc)") +endif() + +if(NOT DEFINED CMAKE_INSTALL_SHAREDSTATEDIR) + set(CMAKE_INSTALL_SHAREDSTATEDIR "com" CACHE PATH "modifiable architecture-independent data (com)") +endif() + +if(NOT DEFINED CMAKE_INSTALL_LOCALSTATEDIR) + set(CMAKE_INSTALL_LOCALSTATEDIR "var" CACHE PATH "modifiable single-machine data (var)") +endif() + +if(NOT DEFINED CMAKE_INSTALL_LIBDIR) + set(_LIBDIR_DEFAULT "lib") + # Override this default 'lib' with 'lib64' iff: + # - we are on Linux system but NOT cross-compiling + # - we are NOT on debian + # - we are on a 64 bits system + # reason is: amd64 ABI: http://www.x86-64.org/documentation/abi.pdf + # For Debian with multiarch, use 'lib/${CMAKE_LIBRARY_ARCHITECTURE}' if + # CMAKE_LIBRARY_ARCHITECTURE is set (which contains e.g. "i386-linux-gnu" + # See http://wiki.debian.org/Multiarch + if((CMAKE_SYSTEM_NAME MATCHES "Linux|kFreeBSD" OR CMAKE_SYSTEM_NAME STREQUAL "GNU") + AND NOT CMAKE_CROSSCOMPILING) + if (EXISTS "/etc/debian_version") # is this a debian system ? + if(CMAKE_LIBRARY_ARCHITECTURE) + set(_LIBDIR_DEFAULT "lib/${CMAKE_LIBRARY_ARCHITECTURE}") + endif() + else() # not debian, rely on CMAKE_SIZEOF_VOID_P: + if(NOT DEFINED CMAKE_SIZEOF_VOID_P) + message(AUTHOR_WARNING + "Unable to determine default CMAKE_INSTALL_LIBDIR directory because no target architecture is known. " + "Please enable at least one language before including GNUInstallDirs.") + else() + if("${CMAKE_SIZEOF_VOID_P}" EQUAL "8") + set(_LIBDIR_DEFAULT "lib64") + endif() + endif() + endif() + endif() + set(CMAKE_INSTALL_LIBDIR "${_LIBDIR_DEFAULT}" CACHE PATH "object code libraries (${_LIBDIR_DEFAULT})") +endif() + +if(NOT DEFINED CMAKE_INSTALL_INCLUDEDIR) + set(CMAKE_INSTALL_INCLUDEDIR "include" CACHE PATH "C header files (include)") +endif() + +if(NOT DEFINED CMAKE_INSTALL_OLDINCLUDEDIR) + set(CMAKE_INSTALL_OLDINCLUDEDIR "/usr/include" CACHE PATH "C header files for non-gcc (/usr/include)") +endif() + +if(NOT DEFINED CMAKE_INSTALL_DATAROOTDIR) + set(CMAKE_INSTALL_DATAROOTDIR "share" CACHE PATH "read-only architecture-independent data root (share)") +endif() + +#----------------------------------------------------------------------------- +# Values whose defaults are relative to DATAROOTDIR. Store empty values in +# the cache and store the defaults in local variables if the cache values are +# not set explicitly. This auto-updates the defaults as DATAROOTDIR changes. + +if(NOT CMAKE_INSTALL_DATADIR) + set(CMAKE_INSTALL_DATADIR "" CACHE PATH "read-only architecture-independent data (DATAROOTDIR)") + set(CMAKE_INSTALL_DATADIR "${CMAKE_INSTALL_DATAROOTDIR}") +endif() + +if(NOT CMAKE_INSTALL_INFODIR) + set(CMAKE_INSTALL_INFODIR "" CACHE PATH "info documentation (DATAROOTDIR/info)") + set(CMAKE_INSTALL_INFODIR "${CMAKE_INSTALL_DATAROOTDIR}/info") +endif() + +if(NOT CMAKE_INSTALL_LOCALEDIR) + set(CMAKE_INSTALL_LOCALEDIR "" CACHE PATH "locale-dependent data (DATAROOTDIR/locale)") + set(CMAKE_INSTALL_LOCALEDIR "${CMAKE_INSTALL_DATAROOTDIR}/locale") +endif() + +if(NOT CMAKE_INSTALL_MANDIR) + set(CMAKE_INSTALL_MANDIR "" CACHE PATH "man documentation (DATAROOTDIR/man)") + set(CMAKE_INSTALL_MANDIR "${CMAKE_INSTALL_DATAROOTDIR}/man") +endif() + +if(NOT CMAKE_INSTALL_DOCDIR) + set(CMAKE_INSTALL_DOCDIR "" CACHE PATH "documentation root (DATAROOTDIR/doc/PROJECT_NAME)") + set(CMAKE_INSTALL_DOCDIR "${CMAKE_INSTALL_DATAROOTDIR}/doc/${PROJECT_NAME}") +endif() + +#----------------------------------------------------------------------------- + +mark_as_advanced( + CMAKE_INSTALL_BINDIR + CMAKE_INSTALL_SBINDIR + CMAKE_INSTALL_LIBEXECDIR + CMAKE_INSTALL_SYSCONFDIR + CMAKE_INSTALL_SHAREDSTATEDIR + CMAKE_INSTALL_LOCALSTATEDIR + CMAKE_INSTALL_LIBDIR + CMAKE_INSTALL_INCLUDEDIR + CMAKE_INSTALL_OLDINCLUDEDIR + CMAKE_INSTALL_DATAROOTDIR + CMAKE_INSTALL_DATADIR + CMAKE_INSTALL_INFODIR + CMAKE_INSTALL_LOCALEDIR + CMAKE_INSTALL_MANDIR + CMAKE_INSTALL_DOCDIR + ) + +# Result directories +# +foreach(dir + BINDIR + SBINDIR + LIBEXECDIR + SYSCONFDIR + SHAREDSTATEDIR + LOCALSTATEDIR + LIBDIR + INCLUDEDIR + OLDINCLUDEDIR + DATAROOTDIR + DATADIR + INFODIR + LOCALEDIR + MANDIR + DOCDIR + ) + if(NOT IS_ABSOLUTE ${CMAKE_INSTALL_${dir}}) + set(CMAKE_INSTALL_FULL_${dir} "${CMAKE_INSTALL_PREFIX}/${CMAKE_INSTALL_${dir}}") + else() + set(CMAKE_INSTALL_FULL_${dir} "${CMAKE_INSTALL_${dir}}") + endif() +endforeach() diff --git a/util/CMakeLists.txt b/util/CMakeLists.txt new file mode 100644 index 00000000..3deeb15b --- /dev/null +++ b/util/CMakeLists.txt @@ -0,0 +1,3 @@ +install(FILES ${CMAKE_CURRENT_SOURCE_DIR}/FindGLM.cmake + DESTINATION ${CMAKE_INSTALL_FULL_LIBDIR}/cmake) + From e9ad8f7c18eff5650ad23aaf23856af7a1733757 Mon Sep 17 00:00:00 2001 From: Roger Leigh Date: Tue, 15 Apr 2014 10:30:58 +0100 Subject: [PATCH 02/10] cmake: Don't abort if not testing This prevents installing and is quite antisocial. --- CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index ab227b1b..6631b464 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -11,7 +11,7 @@ add_definitions(-D_CRT_SECURE_NO_WARNINGS) option(GLM_TEST_ENABLE "GLM test" OFF) if(NOT GLM_TEST_ENABLE) - message(FATAL_ERROR "GLM is a header only library, no need to build it. Set the option GLM_TEST_ENABLE with ON to build and run the test bench") + message(STATUS "GLM is a header only library, no need to build it. Set the option GLM_TEST_ENABLE with ON to build and run the test bench") endif() if(("${CMAKE_CXX_COMPILER_ID}" STREQUAL "Clang") OR ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "GNU") OR (("${CMAKE_CXX_COMPILER_ID}" STREQUAL "Intel") AND UNIX)) From 34bd28e8c6e9ce5e7bfa703be3635d39a4e726f9 Mon Sep 17 00:00:00 2001 From: Roger Leigh Date: Tue, 15 Apr 2014 10:44:03 +0100 Subject: [PATCH 03/10] cmake: Don't build tests when not testing --- glm/CMakeLists.txt | 12 +++++++----- test/CMakeLists.txt | 12 +++++++----- 2 files changed, 14 insertions(+), 10 deletions(-) diff --git a/glm/CMakeLists.txt b/glm/CMakeLists.txt index 79a46074..9dbe11ca 100644 --- a/glm/CMakeLists.txt +++ b/glm/CMakeLists.txt @@ -30,11 +30,13 @@ source_group("GTX Files" FILES ${GTX_HEADER}) include_directories(${CMAKE_CURRENT_SOURCE_DIR}/..) -add_executable(${NAME} ${ROOT_TEXT} - ${ROOT_SOURCE} ${ROOT_INLINE} ${ROOT_HEADER} - ${CORE_SOURCE} ${CORE_INLINE} ${CORE_HEADER} - ${GTC_SOURCE} ${GTC_INLINE} ${GTC_HEADER} - ${GTX_SOURCE} ${GTX_INLINE} ${GTX_HEADER}) +if(GLM_TEST_ENABLE) + add_executable(${NAME} ${ROOT_TEXT} + ${ROOT_SOURCE} ${ROOT_INLINE} ${ROOT_HEADER} + ${CORE_SOURCE} ${CORE_INLINE} ${CORE_HEADER} + ${GTC_SOURCE} ${GTC_INLINE} ${GTC_HEADER} + ${GTX_SOURCE} ${GTX_INLINE} ${GTX_HEADER}) +endif(GLM_TEST_ENABLE) #add_library(glm STATIC glm.cpp) #add_library(glm_shared SHARED glm.cpp) diff --git a/test/CMakeLists.txt b/test/CMakeLists.txt index 0d4acb92..ef6c2877 100644 --- a/test/CMakeLists.txt +++ b/test/CMakeLists.txt @@ -1,10 +1,12 @@ function(glmCreateTestGTC NAME) - set(SAMPLE_NAME test-${NAME}) - add_executable(${SAMPLE_NAME} ${NAME}.cpp) + if(GLM_TEST_ENABLE) + set(SAMPLE_NAME test-${NAME}) + add_executable(${SAMPLE_NAME} ${NAME}.cpp) - add_test( - NAME ${SAMPLE_NAME} - COMMAND $ ) + add_test( + NAME ${SAMPLE_NAME} + COMMAND $ ) + endif(GLM_TEST_ENABLE) endfunction() add_subdirectory(bug) From 4aa1c19707587713e92579866e600e2cd7c15796 Mon Sep 17 00:00:00 2001 From: Roger Leigh Date: Tue, 15 Apr 2014 10:54:03 +0100 Subject: [PATCH 04/10] cmake: Don't use unqualified include paths --- CMakeLists.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 6631b464..685710f5 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -127,8 +127,8 @@ if(CMAKE_COMPILER_IS_GNUCXX) #ctest_enable_coverage() endif() -include_directories(".") -include_directories("./test/external") +include_directories("${PROJECT_SOURCE_DIR}") +include_directories("${PROJECT_SOURCE_DIR}/test/external") add_subdirectory(glm) add_subdirectory(test) From e5ee35323af77a9017f9154c704d59aefd877ea7 Mon Sep 17 00:00:00 2001 From: Christophe Riccio Date: Sun, 4 May 2014 16:34:46 +0200 Subject: [PATCH 05/10] Fixed non-utf8 character #196 --- glm/detail/type_half.inl | 3 +-- readme.txt | 5 +++++ 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/glm/detail/type_half.inl b/glm/detail/type_half.inl index c304d9ac..29801357 100644 --- a/glm/detail/type_half.inl +++ b/glm/detail/type_half.inl @@ -38,8 +38,7 @@ namespace detail volatile float f = 1e10; for(int i = 0; i < 10; ++i) - f *= f; // this will overflow before - // the for­loop terminates + f *= f; // this will overflow before the for loop terminates return f; } diff --git a/readme.txt b/readme.txt index aaf3e217..0e7528eb 100644 --- a/readme.txt +++ b/readme.txt @@ -36,6 +36,11 @@ GLM is a header only library, there is nothing to build, just include it. More informations in GLM manual: http://glm.g-truc.net/glm.pdf +================================================================================ +GLM 0.9.5.4: 2014-0X-XX +-------------------------------------------------------------------------------- +- Fixed non-utf8 space character #196 + ================================================================================ GLM 0.9.5.3: 2014-04-02 -------------------------------------------------------------------------------- From 7d7444df8d5f6074d32b079ff5f41088fe645146 Mon Sep 17 00:00:00 2001 From: Christophe Riccio Date: Sun, 4 May 2014 16:43:57 +0200 Subject: [PATCH 06/10] Fixed non-utf8 character #196 --- readme.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/readme.txt b/readme.txt index 0e7528eb..b45d81fa 100644 --- a/readme.txt +++ b/readme.txt @@ -39,7 +39,7 @@ http://glm.g-truc.net/glm.pdf ================================================================================ GLM 0.9.5.4: 2014-0X-XX -------------------------------------------------------------------------------- -- Fixed non-utf8 space character #196 +- Fixed non-utf8 character #196 ================================================================================ GLM 0.9.5.3: 2014-04-02 From c80f5bc7406c762ed414f9408740fb0b1a2ae576 Mon Sep 17 00:00:00 2001 From: Christophe Riccio Date: Sun, 4 May 2014 16:55:15 +0200 Subject: [PATCH 07/10] Updated readme for GLM 0.9.5.4 with #189 --- readme.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/readme.txt b/readme.txt index b45d81fa..218b2811 100644 --- a/readme.txt +++ b/readme.txt @@ -40,6 +40,7 @@ http://glm.g-truc.net/glm.pdf GLM 0.9.5.4: 2014-0X-XX -------------------------------------------------------------------------------- - Fixed non-utf8 character #196 +- Added FindGLM install for CMake #189 ================================================================================ GLM 0.9.5.3: 2014-04-02 From d77bfa1a704c7060fc723e2c463cae398dc5b354 Mon Sep 17 00:00:00 2001 From: Christophe Riccio Date: Sun, 4 May 2014 17:20:40 +0200 Subject: [PATCH 08/10] Fixed GTX_color_space - saturation #195 --- glm/gtx/color_space.hpp | 4 ++-- glm/gtx/color_space.inl | 8 ++++---- test/gtx/gtx_color_space.cpp | 11 +++++++++++ 3 files changed, 17 insertions(+), 6 deletions(-) diff --git a/glm/gtx/color_space.hpp b/glm/gtx/color_space.hpp index f9bb7ac1..44e2dd13 100644 --- a/glm/gtx/color_space.hpp +++ b/glm/gtx/color_space.hpp @@ -64,8 +64,8 @@ namespace glm /// Build a saturation matrix. /// @see gtx_color_space - template - GLM_FUNC_DECL detail::tmat4x4 saturation( + template + GLM_FUNC_DECL detail::tmat4x4 saturation( T const s); /// Modify the saturation of a color. diff --git a/glm/gtx/color_space.inl b/glm/gtx/color_space.inl index e45fae61..32d2ce8d 100644 --- a/glm/gtx/color_space.inl +++ b/glm/gtx/color_space.inl @@ -106,16 +106,16 @@ namespace glm return hsv; } - template - GLM_FUNC_QUALIFIER detail::tmat4x4 saturation(const T s) + template + GLM_FUNC_QUALIFIER detail::tmat4x4 saturation(T const s) { - detail::tvec3 rgbw = detail::tvec3(T(0.2126), T(0.7152), T(0.0722)); + detail::tvec3 rgbw = detail::tvec3(T(0.2126), T(0.7152), T(0.0722)); T col0 = (T(1) - s) * rgbw.r; T col1 = (T(1) - s) * rgbw.g; T col2 = (T(1) - s) * rgbw.b; - detail::tmat4x4 result(T(1)); + detail::tmat4x4 result(T(1)); result[0][0] = col0 + s; result[0][1] = col0; result[0][2] = col0; diff --git a/test/gtx/gtx_color_space.cpp b/test/gtx/gtx_color_space.cpp index a4e909c5..fb3649e9 100644 --- a/test/gtx/gtx_color_space.cpp +++ b/test/gtx/gtx_color_space.cpp @@ -11,9 +11,20 @@ #include #include +int test_saturation() +{ + int Error(0); + + glm::vec4 Color = glm::saturation(1.0f, glm::vec4(1.0, 0.5, 0.0, 1.0)); + + return Error; +} + int main() { int Error(0); + Error += test_saturation(); + return Error; } From a4bb7e1e382a86fa81cb755e7e32de4fa41a86b2 Mon Sep 17 00:00:00 2001 From: Christophe Riccio Date: Sun, 4 May 2014 17:29:36 +0200 Subject: [PATCH 09/10] Fixed GTX_color_space - saturation #195 --- readme.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/readme.txt b/readme.txt index 218b2811..8c5c6a3d 100644 --- a/readme.txt +++ b/readme.txt @@ -41,6 +41,7 @@ GLM 0.9.5.4: 2014-0X-XX -------------------------------------------------------------------------------- - Fixed non-utf8 character #196 - Added FindGLM install for CMake #189 +- Fixed GTX_color_space - saturation #195 ================================================================================ GLM 0.9.5.3: 2014-04-02 From a2b70690c1d64074f6b3b6f40c6195920efade57 Mon Sep 17 00:00:00 2001 From: Christophe Riccio Date: Sun, 4 May 2014 17:34:34 +0200 Subject: [PATCH 10/10] Added test gor issue #199 --- glm/gtx/quaternion.inl | 2 +- test/gtx/gtx_quaternion.cpp | 12 ++++++++++++ 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/glm/gtx/quaternion.inl b/glm/gtx/quaternion.inl index 0d75f62e..2d1a6c13 100644 --- a/glm/gtx/quaternion.inl +++ b/glm/gtx/quaternion.inl @@ -87,7 +87,7 @@ namespace glm T Vec3Len = sqrt(q.x * q.x + q.y * q.y + q.z * q.z); T QuatLen = sqrt(Vec3Len * Vec3Len + q.w * q.w); T t = atan(Vec3Len, T(q.w)) / Vec3Len; - return detail::tquat(t * q.x, t * q.y, t * q.z, log(QuatLen)); + return detail::tquat(log(QuatLen), t * q.x, t * q.y, t * q.z); } } diff --git a/test/gtx/gtx_quaternion.cpp b/test/gtx/gtx_quaternion.cpp index da052954..1dacc1f2 100644 --- a/test/gtx/gtx_quaternion.cpp +++ b/test/gtx/gtx_quaternion.cpp @@ -87,10 +87,22 @@ int test_rotation() return Error; } +int test_log() +{ + int Error(0); + + glm::quat q; + glm::quat p = glm::log(q); + glm::quat r = glm::exp(p); + + return Error; +} + int main() { int Error(0); + Error += test_log(); Error += test_rotation(); Error += test_quat_fastMix(); Error += test_quat_shortMix();