From 68c7e7e50b934cd265251a0660096f1415647bbb Mon Sep 17 00:00:00 2001 From: Christophe Riccio Date: Sun, 30 Sep 2018 11:07:11 +0200 Subject: [PATCH 1/4] Tentative fix constexpr with GCC --- glm/detail/setup.hpp | 1 + 1 file changed, 1 insertion(+) diff --git a/glm/detail/setup.hpp b/glm/detail/setup.hpp index a26c2dea..1af67533 100644 --- a/glm/detail/setup.hpp +++ b/glm/detail/setup.hpp @@ -283,6 +283,7 @@ #else # define GLM_HAS_CONSTEXPR ((GLM_LANG & GLM_LANG_CXX0X_FLAG) && GLM_HAS_INITIALIZER_LISTS && (\ ((GLM_COMPILER & GLM_COMPILER_INTEL) && (GLM_COMPILER >= GLM_COMPILER_INTEL17)) || \ + ((GLM_COMPILER & GLM_COMPILER_GCC) && (GLM_COMPILER >= GLM_COMPILER_GCC5)) || \ ((GLM_COMPILER & GLM_COMPILER_VC) && (GLM_COMPILER >= GLM_COMPILER_VC15)))) #endif From 3d26f49775c59f70f0dca8b8cfd01b80311cc143 Mon Sep 17 00:00:00 2001 From: Christophe Riccio Date: Sun, 30 Sep 2018 21:52:09 +0200 Subject: [PATCH 2/4] Added GLM_FORCE_ALIGNED_GENTYPES to enable aligned types and SIMD instruction are not enabled. This disable constexpr #816 --- CMakeLists.txt | 2 +- glm/detail/setup.hpp | 32 +++++++++++------ glm/gtc/type_aligned.hpp | 4 +-- manual.md | 62 +++++++++++++++++++------------- readme.md | 1 + test/core/core_cpp_constexpr.cpp | 2 ++ 6 files changed, 66 insertions(+), 37 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 756673a3..03abda95 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -109,7 +109,7 @@ option(GLM_TEST_ENABLE_SIMD_AVX2 "Enable AVX2 optimizations" OFF) option(GLM_TEST_FORCE_PURE "Force 'pure' instructions" OFF) if(GLM_TEST_FORCE_PURE) - add_definitions(-DGLM_FORCE_PURE) + //add_definitions(-DGLM_FORCE_PURE) if(CMAKE_CXX_COMPILER_ID MATCHES "GNU") add_compile_options(-mfpmath=387) diff --git a/glm/detail/setup.hpp b/glm/detail/setup.hpp index 1af67533..3daec599 100644 --- a/glm/detail/setup.hpp +++ b/glm/detail/setup.hpp @@ -723,6 +723,15 @@ namespace detail # define GLM_CONFIG_CTOR_INIT GLM_CTOR_INIT_DISABLE #endif +/////////////////////////////////////////////////////////////////////////////////// +// Use SIMD instruction sets + +#if GLM_HAS_ALIGNOF && (GLM_LANG & GLM_LANG_CXXMS_FLAG) && (GLM_ARCH & GLM_ARCH_SIMD_BIT) +# define GLM_CONFIG_SIMD GLM_ENABLE +#else +# define GLM_CONFIG_SIMD GLM_DISABLE +#endif + /////////////////////////////////////////////////////////////////////////////////// // Configure the use of defaulted function @@ -741,21 +750,16 @@ namespace detail # define GLM_FORCE_DEFAULT_ALIGNED_GENTYPES #endif -#if GLM_HAS_ALIGNOF && (GLM_LANG & GLM_LANG_CXXMS_FLAG) +#ifdef GLM_FORCE_DEFAULT_ALIGNED_GENTYPES +# define GLM_FORCE_ALIGNED_GENTYPES +#endif + +#if GLM_HAS_ALIGNOF && (GLM_LANG & GLM_LANG_CXXMS_FLAG) && (defined(GLM_FORCE_ALIGNED_GENTYPES) || (GLM_CONFIG_SIMD == GLM_ENABLE)) # define GLM_CONFIG_ALIGNED_GENTYPES GLM_ENABLE #else # define GLM_CONFIG_ALIGNED_GENTYPES GLM_DISABLE #endif -/////////////////////////////////////////////////////////////////////////////////// -// Use SIMD instruction sets - -#if GLM_HAS_ALIGNOF && (GLM_LANG & GLM_LANG_CXXMS_FLAG) && (GLM_ARCH & GLM_ARCH_SIMD_BIT) -# define GLM_CONFIG_SIMD GLM_ENABLE -#else -# define GLM_CONFIG_SIMD GLM_DISABLE -#endif - /////////////////////////////////////////////////////////////////////////////////// // Configure the use of anonymous structure as implementation detail @@ -1023,6 +1027,14 @@ namespace detail # pragma message("GLM: GLM_FORCE_SINGLE_ONLY is defined. Using only single precision floating-point types") # endif +# if defined(GLM_FORCE_ALIGNED_GENTYPES) && (GLM_CONFIG_ALIGNED_GENTYPES == GLM_ENABLE) +# undef GLM_FORCE_ALIGNED_GENTYPES +# pragma message("GLM: GLM_FORCE_ALIGNED_GENTYPES is defined, allowing aligned types. This prevents the use of C++ constexpr.") +# elif defined(GLM_FORCE_ALIGNED_GENTYPES) && (GLM_CONFIG_ALIGNED_GENTYPES == GLM_DISABLE) +# undef GLM_FORCE_ALIGNED_GENTYPES +# pragma message("GLM: GLM_FORCE_ALIGNED_GENTYPES is defined but is disabled. It requires C++11 and language extensions") +# endif + # if defined(GLM_FORCE_DEFAULT_ALIGNED_GENTYPES) && (GLM_CONFIG_ALIGNED_GENTYPES == GLM_DISABLE) # undef GLM_FORCE_DEFAULT_ALIGNED_GENTYPES # pragma message("GLM: GLM_FORCE_DEFAULT_ALIGNED_GENTYPES is defined but is disabled. It requires C++11 and language extensions") diff --git a/glm/gtc/type_aligned.hpp b/glm/gtc/type_aligned.hpp index ccb7b6b0..5403abf6 100644 --- a/glm/gtc/type_aligned.hpp +++ b/glm/gtc/type_aligned.hpp @@ -12,8 +12,8 @@ #pragma once -#if !GLM_CONFIG_ANONYMOUS_STRUCT -# error "GLM: Aligned gentypes require to enable C++ language extensions." +#if (GLM_CONFIG_ALIGNED_GENTYPES == GLM_DISABLE) +# error "GLM: Aligned gentypes require to enable C++ language extensions. Define GLM_FORCE_ALIGNED_GENTYPES before including GLM headers to use aligned types." #endif #if GLM_MESSAGES == GLM_ENABLE && !defined(GLM_EXT_INCLUDED) diff --git a/manual.md b/manual.md index eed6c04f..86f96e1c 100644 --- a/manual.md +++ b/manual.md @@ -23,17 +23,18 @@ + [2.6. GLM\_FORCE\_CXX**: C++ language detection](#section2_6) + [2.7. GLM\_FORCE\_EXPLICIT\_CTOR: Requiring explicit conversions](#section2_7) + [2.8. GLM\_FORCE\_INLINE: Force inline](#section2_8) -+ [2.9. GLM\_FORCE\_DEFAULT\_ALIGNED_GENTYPES: Force GLM to use aligned types by default](#section2_9) -+ [2.10. GLM\_FORCE\_SIMD\_**: Using SIMD optimizations](#section2_10) -+ [2.11. GLM\_FORCE\_PRECISION\_**: Default precision](#section2_11) -+ [2.12. GLM\_FORCE\_SINGLE\_ONLY: Removed explicit 64-bits floating point types](#section2_12) -+ [2.13. GLM\_FORCE\_SWIZZLE: Enable swizzle operators](#section2_13) -+ [2.14. GLM\_FORCE\_XYZW\_ONLY: Only exposes x, y, z and w components](#section2_14) -+ [2.15. GLM\_FORCE\_LEFT\_HANDED: Force left handed coordinate system](#section2_15) -+ [2.16. GLM\_FORCE\_DEPTH\_ZERO\_TO\_ONE: Force the use of a clip space between 0 to 1](#section2_16) -+ [2.17. GLM\_FORCE\_SIZE\_T\_LENGTH: Vector and matrix static size type](#section2_17) -+ [2.18. GLM\_FORCE\_UNRESTRICTED\_GENTYPE: Removing genType restriction](#section2_18) -+ [2.19. GLM\_FORCE\_SILENT\_WARNINGS: Silent C++ warnings from language extensions](#section2_19) ++ [2.9. GLM\_FORCE\_ALIGNED\_GENTYPES: Force GLM to enable aligned types](#section2_9) ++ [2.10. GLM\_FORCE\_DEFAULT\_ALIGNED\_GENTYPES: Force GLM to use aligned types by default](#section2_10) ++ [2.11. GLM\_FORCE\_SIMD\_**: Using SIMD optimizations](#section2_11) ++ [2.12. GLM\_FORCE\_PRECISION\_**: Default precision](#section2_12) ++ [2.13. GLM\_FORCE\_SINGLE\_ONLY: Removed explicit 64-bits floating point types](#section2_13) ++ [2.14. GLM\_FORCE\_SWIZZLE: Enable swizzle operators](#section2_14) ++ [2.15. GLM\_FORCE\_XYZW\_ONLY: Only exposes x, y, z and w components](#section2_15) ++ [2.16. GLM\_FORCE\_LEFT\_HANDED: Force left handed coordinate system](#section2_16) ++ [2.17. GLM\_FORCE\_DEPTH\_ZERO\_TO\_ONE: Force the use of a clip space between 0 to 1](#section2_17) ++ [2.18. GLM\_FORCE\_SIZE\_T\_LENGTH: Vector and matrix static size type](#section2_18) ++ [2.19. GLM\_FORCE\_UNRESTRICTED\_GENTYPE: Removing genType restriction](#section2_19) ++ [2.20. GLM\_FORCE\_SILENT\_WARNINGS: Silent C++ warnings from language extensions](#section2_20) + [3. Stable extensions](#section3) + [3.1. Scalar types](#section3_1) + [3.2. Scalar functions](#section3_2) @@ -393,7 +394,7 @@ To push further the software performance, a programmer can define `GLM_FORCE_INL #include ``` -### 2.9. GLM\_FORCE\_DEFAULT\_ALIGNED\_GENTYPES: Force GLM to use aligned types by default +### 2.9. GLM\_FORCE\_ALIGNED\_GENTYPES: Force GLM to enable aligned types Every object type has the property called alignment requirement, which is an integer value (of type `std::size_t`, always a power of 2) representing the number of bytes between successive addresses at which objects of this type can be allocated. The alignment requirement of a type can be queried with alignof or `std::alignment_of`. The pointer alignment function `std::align` can be used to obtain a suitably-aligned pointer within some buffer, and `std::aligned_storage` can be used to obtain suitably-aligned storage. @@ -403,6 +404,19 @@ In order to satisfy alignment requirements of all non-static members of a class, GLM supports both packed and aligned types. Packed types allow filling data structure without inserting extra padding. Aligned GLM types align addresses based on the size of the value type of a GLM type. +```cpp +#define GLM_FORCE_ALIGNED_GENTYPES +#include +#include + +typedef glm::aligned_vec4 vec4a; +typedef glm::packed_vec4 vec4p; +``` + +### 2.10. GLM\_FORCE\_DEFAULT\_ALIGNED\_GENTYPES: Force GLM to use aligned types by default + +GLM allows using aligned types by default for vector types using `GLM_FORCE_DEFAULT_ALIGNED_GENTYPES`: + ```cpp #define GLM_FORCE_DEFAULT_ALIGNED_GENTYPES #include @@ -442,7 +456,7 @@ void foo() *Note: GLM SIMD optimizations require the use of aligned types* -### 2.10. GLM\_FORCE\_SIMD\_**: Using SIMD optimizations +### 2.11. GLM\_FORCE\_SIMD\_**: Using SIMD optimizations GLM provides some SIMD optimizations based on [compiler intrinsics](https://msdn.microsoft.com/en-us/library/26td21ds.aspx). These optimizations will be automatically thanks to compiler arguments. @@ -471,7 +485,7 @@ static_assert(glm::vec4::length() == 4, "Using GLM C++ 14 constexpr support for Additionally, GLM provides a low level SIMD API in glm/simd directory for users who are really interested in writing fast algorithms. -### 2.11. GLM\_FORCE\_PRECISION\_**: Default precision +### 2.12. GLM\_FORCE\_PRECISION\_**: Default precision C++ does not provide a way to implement GLSL default precision selection (as defined in GLSL 4.10 specification section 4.5.3) with GLSL-like syntax. @@ -512,11 +526,11 @@ Available defines for unsigned integer types (`glm::uvec\*`): * `GLM_FORCE_PRECISION_MEDIUMP_UINT`: Medium precision * `GLM_FORCE_PRECISION_HIGHP_UINT`: High precision (default) -### 2.12. GLM\_FORCE\_SINGLE\_ONLY: Removed explicit 64-bits floating point types +### 2.13. GLM\_FORCE\_SINGLE\_ONLY: Removed explicit 64-bits floating point types Some platforms (Dreamcast) doesn't support double precision floating point values. To compile on such platforms, GCC has the `--m4-single-only` build argument. When defining `GLM_FORCE_SINGLE_ONLY` before including GLM headers, GLM releases the requirement of double precision floating point values support. Effectivement, all the float64 types are no longer defined and double behaves like float. -### 2.13. GLM\_FORCE\_SWIZZLE: Enable swizzle operators +### 2.14. GLM\_FORCE\_SWIZZLE: Enable swizzle operators Shader languages like GLSL often feature so-called swizzle expressions, which may be used to freely select and arrange a vector's components. For example, `variable.x`, `variable.xzy` and `variable.zxyy` respectively form a scalar, a 3D vector and a 4D vector. The result of a swizzle expression in GLSL can be either an R-value or an L-value. Swizzle expressions can be written with characters from exactly one of `xyzw` (usually for positions), `rgba` (usually for colors), and `stpq` (usually for texture coordinates). @@ -536,7 +550,7 @@ GLM supports some of this functionality. Swizzling can be enabled by defining `G GLM has two levels of swizzling support described in the following subsections. -#### 2.13.1. Swizzle functions for standard C++ 98 +#### 2.14.1. Swizzle functions for standard C++ 98 When compiling GLM as C++98, R-value swizzle expressions are simulated through member functions of each vector type. @@ -573,7 +587,7 @@ void foo() } ``` -#### 2.13.2. Swizzle operations for C++ 98 with language extensions +#### 2.14.2. Swizzle operations for C++ 98 with language extensions Visual C++, GCC and Clang support, as a _non-standard language extension_, anonymous `struct`s as `union` members. This permits a powerful swizzling implementation that both allows L-value swizzle expressions and GLSL-like syntax. To use this feature, the language extension must be enabled by a supporting compiler and `GLM_FORCE_SWIZZLE` must be `#define`d. @@ -623,26 +637,26 @@ void foo() *Note: The implementation has a caveat: Swizzle operator types must be different on both size of the equal operator or the operation will fail. There is no known fix for this issue to date* -### 2.14. GLM\_FORCE\_XYZW\_ONLY: Only exposes x, y, z and w components +### 2.15. GLM\_FORCE\_XYZW\_ONLY: Only exposes x, y, z and w components Following GLSL specifications, GLM supports three sets of components to access vector types member: x, y, z, w; r, g, b, a; and s, t, p, q. Also, this is making vector component very expressive in the code, it may make debugging vector types a little cubersom as the debuggers will typically display three time the values for each compoenents due to the existance of the three sets. To simplify vector types, GLM allows exposing only x, y, z and w components thanks to `GLM_FORCE_XYZW_ONLY` define. -### 2.15. GLM\_FORCE\_LEFT\_HANDED: Force left handed coordinate system +### 2.16. GLM\_FORCE\_LEFT\_HANDED: Force left handed coordinate system By default, OpenGL is using a right handed coordinate system. However, others APIs such as Direct3D have done different choice and relies on the left handed coordinate system. GLM allows switching the coordinate system to left handed by defining `GLM_FORCE_LEFT_HANDED`. -### 2.16. GLM\_FORCE\_DEPTH\_ZERO\_TO\_ONE: Force the use of a clip space between 0 to 1 +### 2.17. GLM\_FORCE\_DEPTH\_ZERO\_TO\_ONE: Force the use of a clip space between 0 to 1 By default, OpenGL is using a -1 to 1 clip space in Z-axis. However, others APIs such as Direct3D relies on a clip space between 0 to 1 in Z-axis. GLM allows switching the clip space in Z-axis to 0 to 1 by defining `GLM_FORCE_DEPTH_ZERO_TO_ONE`. -### 2.17. GLM\_FORCE\_SIZE\_T\_LENGTH: Vector and matrix static size +### 2.18. GLM\_FORCE\_SIZE\_T\_LENGTH: Vector and matrix static size GLSL supports the member function .length() for all vector and matrix types. @@ -671,7 +685,7 @@ void foo(vec4 const& v) } ``` -### 2.18. GLM\_FORCE\_UNRESTRICTED\_GENTYPE: Removing genType restriction +### 2.19. GLM\_FORCE\_UNRESTRICTED\_GENTYPE: Removing genType restriction GLSL has restrictions on types supported by certain functions that may appear excessive. By default, GLM follows the GLSL specification as accurately as possible however it's possible to relax these rules using `GLM_FORCE_UNRESTRICTED_GENTYPE` define. @@ -697,7 +711,7 @@ int average(int const A, int const B) } ``` -### 2.19. GLM\_FORCE\_SILENT\_WARNINGS: Silent C++ warnings from language extensions +### 2.20. GLM\_FORCE\_SILENT\_WARNINGS: Silent C++ warnings from language extensions When using /W4 on Visual C++ or -Wpedantic on GCC, for example, the compilers will generate warnings for using C++ language extensions (/Za with Visual C++) such as anonymous struct. GLM relies on anonymous structs for swizzle operators and aligned vector types. To silent those warnings define `GLM_FORCE_SILENT_WARNINGS` before including GLM headers. diff --git a/readme.md b/readme.md index c0e83e22..dbac0b28 100644 --- a/readme.md +++ b/readme.md @@ -57,6 +57,7 @@ glm::mat4 camera(float Translate, glm::vec2 const& Rotate) - Added equal and notEqual overload with max ULPs parameters for scalar numbers #121 - Added GLM_FORCE_SILENT_WARNINGS to silent GLM warnings when using language extensions but using W4 or Wpedantic warnings #814 #775 - Added adjugate functions to GTX_matrix_operation #151 +- Added GLM_FORCE_ALIGNED_GENTYPES to enable aligned types and SIMD instruction are not enabled. This disable constexpr #816 #### Improvements: - Added constant time ULP distance between float #121 diff --git a/test/core/core_cpp_constexpr.cpp b/test/core/core_cpp_constexpr.cpp index 3dc0a92b..f02441df 100644 --- a/test/core/core_cpp_constexpr.cpp +++ b/test/core/core_cpp_constexpr.cpp @@ -2,6 +2,8 @@ #if GLM_CONFIG_CONSTEXP == GLM_ENABLE +//#error GNI + #include #include #include From abff0a39ace17f88bcdff9c0484beda9246f3121 Mon Sep 17 00:00:00 2001 From: Christophe Riccio Date: Mon, 1 Oct 2018 11:23:26 +0200 Subject: [PATCH 3/4] Fixed build --- CMakeLists.txt | 2 +- test/core/core_cpp_constexpr.cpp | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 03abda95..756673a3 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -109,7 +109,7 @@ option(GLM_TEST_ENABLE_SIMD_AVX2 "Enable AVX2 optimizations" OFF) option(GLM_TEST_FORCE_PURE "Force 'pure' instructions" OFF) if(GLM_TEST_FORCE_PURE) - //add_definitions(-DGLM_FORCE_PURE) + add_definitions(-DGLM_FORCE_PURE) if(CMAKE_CXX_COMPILER_ID MATCHES "GNU") add_compile_options(-mfpmath=387) diff --git a/test/core/core_cpp_constexpr.cpp b/test/core/core_cpp_constexpr.cpp index f02441df..3dc0a92b 100644 --- a/test/core/core_cpp_constexpr.cpp +++ b/test/core/core_cpp_constexpr.cpp @@ -2,8 +2,6 @@ #if GLM_CONFIG_CONSTEXP == GLM_ENABLE -//#error GNI - #include #include #include From 77ce9b5b29d35857e1d43030d6faeff2a45a3f17 Mon Sep 17 00:00:00 2001 From: Christophe Riccio Date: Mon, 1 Oct 2018 14:19:08 +0200 Subject: [PATCH 4/4] Tentative fix of GCC 6 tests --- glm/detail/setup.hpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/glm/detail/setup.hpp b/glm/detail/setup.hpp index 3daec599..63c529b4 100644 --- a/glm/detail/setup.hpp +++ b/glm/detail/setup.hpp @@ -283,7 +283,7 @@ #else # define GLM_HAS_CONSTEXPR ((GLM_LANG & GLM_LANG_CXX0X_FLAG) && GLM_HAS_INITIALIZER_LISTS && (\ ((GLM_COMPILER & GLM_COMPILER_INTEL) && (GLM_COMPILER >= GLM_COMPILER_INTEL17)) || \ - ((GLM_COMPILER & GLM_COMPILER_GCC) && (GLM_COMPILER >= GLM_COMPILER_GCC5)) || \ + ((GLM_COMPILER & GLM_COMPILER_GCC) && (GLM_COMPILER >= GLM_COMPILER_GCC6)) || \ ((GLM_COMPILER & GLM_COMPILER_VC) && (GLM_COMPILER >= GLM_COMPILER_VC15)))) #endif