From 5459a4dcfbf42e8206b3546300fb3090552e1a7b Mon Sep 17 00:00:00 2001 From: Christophe Riccio Date: Wed, 20 Apr 2011 10:30:26 +0100 Subject: [PATCH] Clarify angleAxis function --- glm/gtx/quaternion.hpp | 6 +++--- glm/gtx/quaternion.inl | 1 - 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/glm/gtx/quaternion.hpp b/glm/gtx/quaternion.hpp index 91ca1751..3e76481d 100644 --- a/glm/gtx/quaternion.hpp +++ b/glm/gtx/quaternion.hpp @@ -121,7 +121,7 @@ namespace glm detail::tvec3 axis( detail::tquat const & x); - //! Build a quaternion from an angle and an axis. + //! Build a quaternion from an angle and a normalized axis. //! From GLM_GTX_quaternion extension. template detail::tquat angleAxis( @@ -130,12 +130,12 @@ namespace glm valType const & y, valType const & z); - //! Build a quaternion from an angle and an axis. + //! Build a quaternion from an angle and a normalized axis. //! From GLM_GTX_quaternion extension. template detail::tquat angleAxis( valType const & angle, - detail::tvec3 const & v); + detail::tvec3 const & axis); //! Extract the real component of a quaternion. //! From GLM_GTX_quaternion extension. diff --git a/glm/gtx/quaternion.inl b/glm/gtx/quaternion.inl index ba69b9d1..6ae3fcb9 100644 --- a/glm/gtx/quaternion.inl +++ b/glm/gtx/quaternion.inl @@ -185,7 +185,6 @@ namespace quaternion ) { detail::tquat result; - detail::tvec3 v_normalized = glm::normalize(v); valType a = glm::radians(angle); valType s = glm::sin(a * valType(0.5));