diff --git a/glm/detail/func_integer.inl b/glm/detail/func_integer.inl index cc1c4d33..eead6f9a 100644 --- a/glm/detail/func_integer.inl +++ b/glm/detail/func_integer.inl @@ -116,6 +116,7 @@ namespace detail } }; +# if !((GLM_COMPILER & GLM_COMPILER_VC) && (GLM_COMPILER < GLM_COMPILER_VC2013) && (GLM_MODEL == GLM_MODEL_32)) template struct compute_findLSB { @@ -126,6 +127,7 @@ namespace detail return IsNotNull ? int(Result) : -1; } }; +# endif # endif//GLM_HAS_BITSCAN_WINDOWS template class vecType, bool EXEC = true> @@ -171,14 +173,6 @@ namespace detail return IsNotNull ? int(Result) : -1; } - template - GLM_FUNC_QUALIFIER int compute_findMSB_64(genIUType Value) - { - unsigned long Result(0); - unsigned char IsNotNull = _BitScanReverse64(&Result, *reinterpret_cast(&Value)); - return IsNotNull ? int(Result) : -1; - } - template class vecType> struct compute_findMSB_vec { @@ -188,6 +182,15 @@ namespace detail } }; +# if !((GLM_COMPILER & GLM_COMPILER_VC) && (GLM_COMPILER < GLM_COMPILER_VC2013) && (GLM_MODEL == GLM_MODEL_32)) + template + GLM_FUNC_QUALIFIER int compute_findMSB_64(genIUType Value) + { + unsigned long Result(0); + unsigned char IsNotNull = _BitScanReverse64(&Result, *reinterpret_cast(&Value)); + return IsNotNull ? int(Result) : -1; + } + template class vecType> struct compute_findMSB_vec { @@ -196,6 +199,7 @@ namespace detail return detail::functor1::call(compute_findMSB_64, x); } }; +# endif # endif//GLM_HAS_BITSCAN_WINDOWS }//namespace detail diff --git a/glm/detail/type_vec4.hpp b/glm/detail/type_vec4.hpp index b62906a2..95d3f5fe 100644 --- a/glm/detail/type_vec4.hpp +++ b/glm/detail/type_vec4.hpp @@ -53,7 +53,9 @@ namespace detail typedef T type[4]; }; -# if GLM_ARCH & GLM_ARCH_SSE2 +# define GLM_NOT_BUGGY_VC32BITS !(GLM_MODEL == GLM_MODEL_32 && GLM_COMPILER & GLM_COMPILER_VC && GLM_COMPILER < GLM_COMPILER_VC2013) + +# if GLM_ARCH & GLM_ARCH_SSE2 && GLM_NOT_BUGGY_VC32BITS template <> struct simd { @@ -73,7 +75,7 @@ namespace detail }; # endif -# if GLM_ARCH & GLM_ARCH_AVX +# if GLM_ARCH & GLM_ARCH_AVX && GLM_NOT_BUGGY_VC32BITS template <> struct simd { @@ -81,7 +83,7 @@ namespace detail }; # endif -# if GLM_ARCH & GLM_ARCH_AVX2 +# if GLM_ARCH & GLM_ARCH_AVX2 && GLM_NOT_BUGGY_VC32BITS template <> struct simd { diff --git a/glm/detail/type_vec4.inl b/glm/detail/type_vec4.inl index 6509efb8..38fb6b5f 100644 --- a/glm/detail/type_vec4.inl +++ b/glm/detail/type_vec4.inl @@ -42,22 +42,6 @@ namespace glm # endif {} -#if GLM_HAS_ANONYMOUS_UNION && (GLM_ARCH & GLM_ARCH_SSE2) - template <> - GLM_FUNC_QUALIFIER tvec4::tvec4() -# ifndef GLM_FORCE_NO_CTOR_INIT - : data(_mm_setzero_ps()) -# endif - {} - - template <> - GLM_FUNC_QUALIFIER tvec4::tvec4() -# ifndef GLM_FORCE_NO_CTOR_INIT - : data(_mm_setzero_ps()) -# endif - {} -#endif - template template GLM_FUNC_QUALIFIER tvec4::tvec4(tvec4 const & v) @@ -76,35 +60,11 @@ namespace glm : x(s), y(s), z(s), w(s) {} -#if GLM_HAS_ANONYMOUS_UNION && (GLM_ARCH & GLM_ARCH_SSE2) - template <> - GLM_FUNC_QUALIFIER tvec4::tvec4(float s) : - data(_mm_set1_ps(s)) - {} - - template <> - GLM_FUNC_QUALIFIER tvec4::tvec4(float s) : - data(_mm_set1_ps(s)) - {} -#endif - template GLM_FUNC_QUALIFIER tvec4::tvec4(T a, T b, T c, T d) : x(a), y(b), z(c), w(d) {} -#if GLM_HAS_ANONYMOUS_UNION && (GLM_ARCH & GLM_ARCH_SSE2) - template <> - GLM_FUNC_QUALIFIER tvec4::tvec4(float a, float b, float c, float d) : - data(_mm_set_ps(d, c, b, a)) - {} - - template <> - GLM_FUNC_QUALIFIER tvec4::tvec4(float a, float b, float c, float d) : - data(_mm_set_ps(d, c, b, a)) - {} -#endif - ////////////////////////////////////// // Conversion scalar constructors @@ -307,40 +267,6 @@ namespace glm return *this; } -#if GLM_HAS_ANONYMOUS_UNION && (GLM_ARCH & GLM_ARCH_SSE2) - template <> - template - GLM_FUNC_QUALIFIER tvec4 & tvec4::operator+=(U scalar) - { - this->data = _mm_add_ps(this->data, _mm_set_ps1(static_cast(scalar))); - return *this; - } - - template <> - template <> - GLM_FUNC_QUALIFIER tvec4 & tvec4::operator+=(float scalar) - { - this->data = _mm_add_ps(this->data, _mm_set_ps1(scalar)); - return *this; - } - - template <> - template - GLM_FUNC_QUALIFIER tvec4 & tvec4::operator+=(U scalar) - { - this->data = _mm_add_ps(this->data, _mm_set_ps1(static_cast(scalar))); - return *this; - } - - template <> - template <> - GLM_FUNC_QUALIFIER tvec4 & tvec4::operator+=(float scalar) - { - this->data = _mm_add_ps(this->data, _mm_set_ps1(scalar)); - return *this; - } -#endif - template template GLM_FUNC_QUALIFIER tvec4 & tvec4::operator+=(tvec1 const & v) @@ -353,24 +279,6 @@ namespace glm return *this; } -#if GLM_HAS_ANONYMOUS_UNION && (GLM_ARCH & GLM_ARCH_SSE2) - template <> - template - GLM_FUNC_QUALIFIER tvec4 & tvec4::operator+=(tvec1 const & v) - { - this->data = _mm_add_ps(this->data, _mm_set_ps1(static_cast(v.x))); - return *this; - } - - template <> - template - GLM_FUNC_QUALIFIER tvec4 & tvec4::operator+=(tvec1 const & v) - { - this->data = _mm_add_ps(this->data, _mm_set_ps1(static_cast(v.x))); - return *this; - } -#endif - template template GLM_FUNC_QUALIFIER tvec4 & tvec4::operator+=(tvec4 const & v) @@ -1188,6 +1096,7 @@ namespace glm } }//namespace glm +#if GLM_HAS_ANONYMOUS_UNION && GLM_NOT_BUGGY_VC32BITS #if GLM_ARCH & GLM_ARCH_SSE2 # include "type_vec4_sse2.inl" #endif @@ -1197,3 +1106,4 @@ namespace glm #if GLM_ARCH & GLM_ARCH_AVX2 # include "type_vec4_avx2.inl" #endif +#endif// diff --git a/glm/detail/type_vec4_sse2.inl b/glm/detail/type_vec4_sse2.inl index eb7b3d6b..cacec35a 100644 --- a/glm/detail/type_vec4_sse2.inl +++ b/glm/detail/type_vec4_sse2.inl @@ -36,6 +36,85 @@ namespace detail }//namespace detail + template <> + GLM_FUNC_QUALIFIER tvec4::tvec4() +# ifndef GLM_FORCE_NO_CTOR_INIT + : data(_mm_setzero_ps()) +# endif + {} + template <> + GLM_FUNC_QUALIFIER tvec4::tvec4() +# ifndef GLM_FORCE_NO_CTOR_INIT + : data(_mm_setzero_ps()) +# endif + {} + template <> + GLM_FUNC_QUALIFIER tvec4::tvec4(float s) : + data(_mm_set1_ps(s)) + {} + + template <> + GLM_FUNC_QUALIFIER tvec4::tvec4(float s) : + data(_mm_set1_ps(s)) + {} + + template <> + GLM_FUNC_QUALIFIER tvec4::tvec4(float a, float b, float c, float d) : + data(_mm_set_ps(d, c, b, a)) + {} + + template <> + GLM_FUNC_QUALIFIER tvec4::tvec4(float a, float b, float c, float d) : + data(_mm_set_ps(d, c, b, a)) + {} + + template <> + template + GLM_FUNC_QUALIFIER tvec4 & tvec4::operator+=(U scalar) + { + this->data = _mm_add_ps(this->data, _mm_set_ps1(static_cast(scalar))); + return *this; + } + + template <> + template <> + GLM_FUNC_QUALIFIER tvec4 & tvec4::operator+=(float scalar) + { + this->data = _mm_add_ps(this->data, _mm_set_ps1(scalar)); + return *this; + } + + template <> + template + GLM_FUNC_QUALIFIER tvec4 & tvec4::operator+=(U scalar) + { + this->data = _mm_add_ps(this->data, _mm_set_ps1(static_cast(scalar))); + return *this; + } + + template <> + template <> + GLM_FUNC_QUALIFIER tvec4 & tvec4::operator+=(float scalar) + { + this->data = _mm_add_ps(this->data, _mm_set_ps1(scalar)); + return *this; + } + + template <> + template + GLM_FUNC_QUALIFIER tvec4 & tvec4::operator+=(tvec1 const & v) + { + this->data = _mm_add_ps(this->data, _mm_set_ps1(static_cast(v.x))); + return *this; + } + + template <> + template + GLM_FUNC_QUALIFIER tvec4 & tvec4::operator+=(tvec1 const & v) + { + this->data = _mm_add_ps(this->data, _mm_set_ps1(static_cast(v.x))); + return *this; + } }//namespace glm diff --git a/readme.txt b/readme.txt index 2bef34ca..7bd57fb4 100644 --- a/readme.txt +++ b/readme.txt @@ -70,6 +70,8 @@ Fixes: - Fixed C++11 explicit conversion operators detection #282 - Fixed missing explicit convertion when using integer log2 with *vec1 types - Fixed Android build issue, STL C++11 is not supported by the NDK #284 +- Fixed unsupported _BitScanForward64 and _BitScanReverse64 in VC10 +- Fixed Visual C++ 32 bit build #283 ================================================================================ GLM 0.9.6.0: 2014-11-30