mirror/tracy
1
0
Fork 0
mirror of https://github.com/wolfpld/tracy.git synced 2024-11-26 16:04:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

Do a linear search instead of using a map.

Browse Source 
513 ms -> 227 ms for a trace with 66 unique source locations and 179 million
zones.
This commit is contained in:
Bartosz Taudul 2024-09-08 16:10:39 +02:00
parent d67598f0fe
commit 0c0e4f554f
No known key found for this signature in database
GPG Key ID: B7FE2008B7575DF3
1 changed files with 8 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
profiler/src/profiler/TracyView_FlameGraph.cpp
View File

@ -4,7 +4,6 @@
#include "TracyPrint.hpp" #include "TracyPrint.hpp"
#include "TracyVector.hpp" #include "TracyVector.hpp"
#include "TracyView.hpp" #include "TracyView.hpp"
#include "tracy_robin_hood.h"
namespace tracy namespace tracy
{ {
@ -18,9 +17,6 @@ struct FlameGraphItem
static void BuildFlameGraph( const Worker& worker, Vector<FlameGraphItem>& data, const Vector<short_ptr<ZoneEvent>>& zones ) static void BuildFlameGraph( const Worker& worker, Vector<FlameGraphItem>& data, const Vector<short_ptr<ZoneEvent>>& zones )
{ {
unordered_flat_map<int16_t, uint16_t> map;
for( size_t i=0; i<data.size(); i++ ) map.emplace( data[i].srcloc, i );
if( zones.is_magic() ) if( zones.is_magic() )
{ {
auto& vec = *(Vector<ZoneEvent>*)&zones; auto& vec = *(Vector<ZoneEvent>*)&zones;
@ -29,10 +25,9 @@ static void BuildFlameGraph( const Worker& worker, Vector<FlameGraphItem>& data,
if( !v.IsEndValid() ) break; if( !v.IsEndValid() ) break;
const auto srcloc = v.SrcLoc(); const auto srcloc = v.SrcLoc();
const auto duration = v.End() - v.Start(); const auto duration = v.End() - v.Start();
auto it = map.find( srcloc ); auto it = std::find_if( data.begin(), data.end(), [srcloc]( const auto& v ) { return v.srcloc == srcloc; } );
if( it == map.end() ) if( it == data.end() )
{ {
map.emplace( srcloc, data.size() );
data.push_back( FlameGraphItem { srcloc, duration } ); data.push_back( FlameGraphItem { srcloc, duration } );
if( v.HasChildren() ) if( v.HasChildren() )
{ {
@ -42,12 +37,11 @@ static void BuildFlameGraph( const Worker& worker, Vector<FlameGraphItem>& data,
} }
else else
{ {
auto& item = data[it->second]; it->time += duration;
item.time += duration;
if( v.HasChildren() ) if( v.HasChildren() )
{ {
auto& children = worker.GetZoneChildren( v.Child() ); auto& children = worker.GetZoneChildren( v.Child() );
BuildFlameGraph( worker, item.children, children ); BuildFlameGraph( worker, it->children, children );
} }
} }
} }
@ -59,10 +53,9 @@ static void BuildFlameGraph( const Worker& worker, Vector<FlameGraphItem>& data,
if( !v->IsEndValid() ) break; if( !v->IsEndValid() ) break;
const auto srcloc = v->SrcLoc(); const auto srcloc = v->SrcLoc();
const auto duration = v->End() - v->Start(); const auto duration = v->End() - v->Start();
auto it = map.find( srcloc ); auto it = std::find_if( data.begin(), data.end(), [srcloc]( const auto& v ) { return v.srcloc == srcloc; } );
if( it == map.end() ) if( it == data.end() )
{ {
map.emplace( srcloc, data.size() );
data.push_back( FlameGraphItem { srcloc, duration } ); data.push_back( FlameGraphItem { srcloc, duration } );
if( v->HasChildren() ) if( v->HasChildren() )
{ {
@ -72,12 +65,11 @@ static void BuildFlameGraph( const Worker& worker, Vector<FlameGraphItem>& data,
} }
else else
{ {
auto& item = data[it->second]; it->time += duration;
item.time += duration;
if( v->HasChildren() ) if( v->HasChildren() )
{ {
auto& children = worker.GetZoneChildren( v->Child() ); auto& children = worker.GetZoneChildren( v->Child() );
BuildFlameGraph( worker, item.children, children ); BuildFlameGraph( worker, it->children, children );
} }
} }
} }