mirror/tracy
1
0
Fork 0
mirror of https://github.com/wolfpld/tracy.git synced 2024-11-29 16:54:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix 32 bit NEON version of DXT1 compression.

Browse Source 
This reverts commit b32e8fa24e.

Apparently it is possible to receive non-uniform data in alpha channel, which
breaks the original assumption about not needing the mask. This seemed to be a
problem only on 32 bit NEON implementation of DXT1 compression. Other
implementations handle such data without degradation of visual output.
This commit is contained in:
Bartosz Taudul 2019-09-03 21:26:17 +02:00
parent aa2530d442
commit 37661fd2ee
2 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
client/TracyDxt1.cpp
View File

@ -372,10 +372,11 @@ static tracy_force_inline uint64_t ProcessRGB( const uint8_t* src )
return uint64_t( to565( src[0], src[1], src[2] ) ) << 16; return uint64_t( to565( src[0], src[1], src[2] ) ) << 16;
} }
uint8x16_t l0 = vreinterpretq_u8_u32( px0 ); uint32x4_t mask = vdupq_n_u32( 0xFFFFFF );
uint8x16_t l1 = vreinterpretq_u8_u32( px1 ); uint8x16_t l0 = vreinterpretq_u8_u32( vandq_u32( mask, px0 ) );
uint8x16_t l2 = vreinterpretq_u8_u32( px2 ); uint8x16_t l1 = vreinterpretq_u8_u32( vandq_u32( mask, px1 ) );
uint8x16_t l3 = vreinterpretq_u8_u32( px3 ); uint8x16_t l2 = vreinterpretq_u8_u32( vandq_u32( mask, px2 ) );
uint8x16_t l3 = vreinterpretq_u8_u32( vandq_u32( mask, px3 ) );
uint8x16_t min0 = vminq_u8( l0, l1 ); uint8x16_t min0 = vminq_u8( l0, l1 );
uint8x16_t min1 = vminq_u8( l2, l3 ); uint8x16_t min1 = vminq_u8( l2, l3 );

BIN
doc/issues/dxt1+alpha.png Normal file
View File

Binary file not shown.
Side by Side

After

Width:  |  Height:  |  Size: 17 KiB