mirror/tracy
1
0
Fork 0
mirror of https://github.com/wolfpld/tracy.git synced 2024-09-20 05:42:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Rename IsThreadStringRetrieved -> IsFailureThreadStringRetrieved.

Browse Source 
IsThreadStringRetrieved() interface suggested that it can be used for
checking any thread state, as it had an uint64_t id parameter.

The implementation ignored this parameter and checked the status of
failure thread only. This was never an issue because the code using
this function was only checking for the failure thread state.

Fixed by renaming the function to explicitly state what it does and
removing the thread id parameter.
This commit is contained in:
Bartosz Taudul 2023-04-16 17:49:21 +02:00
parent b64bab197a
commit 3b00e55235
No known key found for this signature in database
GPG Key ID: B7FE2008B7575DF3
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
server/TracyWorker.cpp
View File

@ -2926,7 +2926,7 @@ void Worker::UpdateMbps( int64_t td )
m_mbpsData.transferred += bytes; m_mbpsData.transferred += bytes;
} }
bool Worker::IsThreadStringRetrieved( uint64_t id ) bool Worker::IsFailureThreadStringRetrieved()
{ {
const auto name = GetThreadName( m_failureData.thread ); const auto name = GetThreadName( m_failureData.thread );
return strcmp( name, "???" ) != 0; return strcmp( name, "???" ) != 0;
@ -2953,7 +2953,7 @@ bool Worker::IsSourceLocationRetrieved( int16_t srcloc )
bool Worker::HasAllFailureData() bool Worker::HasAllFailureData()
{ {
if( m_failureData.thread != 0 && !IsThreadStringRetrieved( m_failureData.thread ) ) return false; if( m_failureData.thread != 0 && !IsFailureThreadStringRetrieved() ) return false;
if( m_failureData.srcloc != 0 && !IsSourceLocationRetrieved( m_failureData.srcloc ) ) return false; if( m_failureData.srcloc != 0 && !IsSourceLocationRetrieved( m_failureData.srcloc ) ) return false;
if( m_failureData.callstack != 0 && !IsCallstackRetrieved( m_failureData.callstack ) ) return false; if( m_failureData.callstack != 0 && !IsCallstackRetrieved( m_failureData.callstack ) ) return false;
return true; return true;

2
server/TracyWorker.hpp
View File

@ -882,7 +882,7 @@ private:
void HandlePostponedSamples(); void HandlePostponedSamples();
void HandlePostponedGhostZones(); void HandlePostponedGhostZones();
bool IsThreadStringRetrieved( uint64_t id ); bool IsFailureThreadStringRetrieved();
bool IsSourceLocationRetrieved( int16_t srcloc ); bool IsSourceLocationRetrieved( int16_t srcloc );
bool IsCallstackRetrieved( uint32_t callstack ); bool IsCallstackRetrieved( uint32_t callstack );
bool HasAllFailureData(); bool HasAllFailureData();