Merge pull request #522 from john-plate/fix

Fix MSVC compiler warning
This commit is contained in:
Bartosz Taudul 2023-02-08 16:39:36 +01:00 committed by GitHub
commit 3e30d155ac
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -210,19 +210,14 @@ namespace details
}
};
#ifdef _MSC_VER
#pragma warning(push)
#pragma warning(disable: 4554)
#endif
template<typename T>
static inline bool circular_less_than(T a, T b)
{
static_assert(std::is_integral<T>::value && !std::numeric_limits<T>::is_signed, "circular_less_than is intended to be used only with unsigned integer types");
return static_cast<T>(a - b) > (static_cast<T>(static_cast<T>(1) << static_cast<T>(sizeof(T) * CHAR_BIT - 1)));
return static_cast<T>(a - b) > static_cast<T>(static_cast<T>(1) << (static_cast<T>(sizeof(T) * CHAR_BIT - 1)));
// Note: extra parens around rhs of operator<< is MSVC bug: https://developercommunity2.visualstudio.com/t/C4554-triggers-when-both-lhs-and-rhs-is/10034931
// silencing the bug requires #pragma warning(disable: 4554) around the calling code and has no effect when done here.
}
#ifdef _MSC_VER
#pragma warning(pop)
#endif
template<typename U>
static inline char* align_for(char* ptr)