Merge pull request #927 from sacereda/systrace-leak

Leak, returned value from GetThreadDescription not freed
This commit is contained in:
Bartosz Taudul 2024-11-19 14:50:56 +01:00 committed by GitHub
commit 759b4c3bfe
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

View File

@ -498,11 +498,11 @@ void SysTraceGetExternalName( uint64_t thread, const char*& threadName, const ch
if( _GetThreadDescription ) if( _GetThreadDescription )
{ {
PWSTR tmp; PWSTR tmp;
_GetThreadDescription( hnd, &tmp ); if ( SUCCEEDED( _GetThreadDescription( hnd, &tmp ) ) )
char buf[256];
if( tmp )
{ {
char buf[256];
auto ret = wcstombs( buf, tmp, 256 ); auto ret = wcstombs( buf, tmp, 256 );
LocalFree(tmp);
if( ret != 0 ) if( ret != 0 )
{ {
threadName = CopyString( buf, ret ); threadName = CopyString( buf, ret );