Decouple zoom level from tracking last events.

This commit is contained in:
Bartosz Taudul 2020-09-12 15:49:41 +02:00
parent b000059430
commit 812f869669
2 changed files with 88 additions and 18 deletions

View File

@ -132,7 +132,7 @@ static View* s_instance = nullptr;
View::View( void(*cbMainThread)(std::function<void()>), const char* addr, int port, ImFont* fixedWidth, ImFont* smallFont, ImFont* bigFont, SetTitleCallback stcb, GetWindowCallback gwcb ) View::View( void(*cbMainThread)(std::function<void()>), const char* addr, int port, ImFont* fixedWidth, ImFont* smallFont, ImFont* bigFont, SetTitleCallback stcb, GetWindowCallback gwcb )
: m_worker( addr, port ) : m_worker( addr, port )
, m_staticView( false ) , m_staticView( false )
, m_pause( false ) , m_viewMode( ViewMode::LastFrames )
, m_forceConnectionPopup( true, true ) , m_forceConnectionPopup( true, true )
, m_frames( nullptr ) , m_frames( nullptr )
, m_messagesScrollBottom( true ) , m_messagesScrollBottom( true )
@ -154,7 +154,7 @@ View::View( void(*cbMainThread)(std::function<void()>), FileRead& f, ImFont* fix
: m_worker( f ) : m_worker( f )
, m_filename( f.GetFilename() ) , m_filename( f.GetFilename() )
, m_staticView( true ) , m_staticView( true )
, m_pause( true ) , m_viewMode( ViewMode::Paused )
, m_frames( m_worker.GetFramesBase() ) , m_frames( m_worker.GetFramesBase() )
, m_messagesScrollBottom( false ) , m_messagesScrollBottom( false )
, m_smallFont( smallFont ) , m_smallFont( smallFont )
@ -553,7 +553,17 @@ bool View::DrawImpl()
{ {
if( m_worker.IsConnected() ) if( m_worker.IsConnected() )
{ {
if( ImGui::Button( m_pause ? MainWindowButtons[0] : MainWindowButtons[1], ImVec2( bw, 0 ) ) ) m_pause = !m_pause; if( ImGui::Button( m_viewMode == ViewMode::Paused ? MainWindowButtons[0] : MainWindowButtons[1], ImVec2( bw, 0 ) ) )
{
if( m_viewMode != ViewMode::Paused )
{
m_viewMode = ViewMode::Paused;
}
else
{
ImGui::OpenPopup( "viewMode" );
}
}
} }
else else
{ {
@ -561,6 +571,18 @@ bool View::DrawImpl()
ImGui::ButtonEx( MainWindowButtons[2], ImVec2( bw, 0 ), ImGuiButtonFlags_Disabled ); ImGui::ButtonEx( MainWindowButtons[2], ImVec2( bw, 0 ), ImGuiButtonFlags_Disabled );
ImGui::PopStyleColor( 1 ); ImGui::PopStyleColor( 1 );
} }
if( ImGui::BeginPopup( "viewMode" ) )
{
if( ImGui::Selectable( ICON_FA_SEARCH_PLUS " Newest three frames" ) )
{
m_viewMode = ViewMode::LastFrames;
}
if( ImGui::Selectable( ICON_FA_RULER_HORIZONTAL " Use current zoom level" ) )
{
m_viewMode = ViewMode::LastRange;
}
ImGui::EndPopup();
}
} }
else else
{ {
@ -806,6 +828,17 @@ bool View::DrawImpl()
if( m_zoomAnim.active ) if( m_zoomAnim.active )
{ {
if( m_viewMode == ViewMode::LastRange )
{
const auto delta = m_worker.GetLastTime() - m_vd.zvEnd;
if( delta != 0 )
{
m_zoomAnim.start0 += delta;
m_zoomAnim.start1 += delta;
m_zoomAnim.end0 += delta;
m_zoomAnim.end1 += delta;
}
}
m_zoomAnim.progress += io.DeltaTime * 3.33f; m_zoomAnim.progress += io.DeltaTime * 3.33f;
if( m_zoomAnim.progress >= 1.f ) if( m_zoomAnim.progress >= 1.f )
{ {
@ -1389,17 +1422,30 @@ void View::DrawFrames()
const int group = GetFrameGroup( m_vd.frameScale ); const int group = GetFrameGroup( m_vd.frameScale );
const int total = m_worker.GetFrameCount( *m_frames ); const int total = m_worker.GetFrameCount( *m_frames );
const int onScreen = ( w - 2 ) / fwidth; const int onScreen = ( w - 2 ) / fwidth;
if( !m_pause ) if( m_viewMode != ViewMode::Paused )
{ {
m_vd.frameStart = ( total < onScreen * group ) ? 0 : total - onScreen * group; m_vd.frameStart = ( total < onScreen * group ) ? 0 : total - onScreen * group;
SetViewToLastFrames(); if( m_viewMode == ViewMode::LastFrames )
{
SetViewToLastFrames();
}
else
{
assert( m_viewMode == ViewMode::LastRange );
const auto delta = m_worker.GetLastTime() - m_vd.zvEnd;
if( delta != 0 )
{
m_vd.zvStart += delta;
m_vd.zvEnd += delta;
}
}
} }
if( hover ) if( hover )
{ {
if( IsMouseDragging( 1 ) ) if( IsMouseDragging( 1 ) )
{ {
m_pause = true; m_viewMode = ViewMode::Paused;
const auto delta = GetMouseDragDelta( 1 ).x; const auto delta = GetMouseDragDelta( 1 ).x;
if( abs( delta ) >= fwidth ) if( abs( delta ) >= fwidth )
{ {
@ -1527,7 +1573,7 @@ void View::DrawFrames()
{ {
if( IsMouseClicked( 0 ) ) if( IsMouseClicked( 0 ) )
{ {
m_pause = true; m_viewMode = ViewMode::Paused;
m_zoomAnim.active = false; m_zoomAnim.active = false;
if( !m_playback.pause && m_playback.sync ) m_playback.pause = true; if( !m_playback.pause && m_playback.sync ) m_playback.pause = true;
m_vd.zvStart = m_worker.GetFrameBegin( *m_frames, sel ); m_vd.zvStart = m_worker.GetFrameBegin( *m_frames, sel );
@ -1545,7 +1591,7 @@ void View::DrawFrames()
if( IsMouseClickReleased( 1 ) ) m_setRangePopup = RangeSlim { m_worker.GetFrameBegin( *m_frames, sel ), m_worker.GetFrameEnd( *m_frames, sel + group - 1 ), true }; if( IsMouseClickReleased( 1 ) ) m_setRangePopup = RangeSlim { m_worker.GetFrameBegin( *m_frames, sel ), m_worker.GetFrameEnd( *m_frames, sel + group - 1 ), true };
} }
if( m_pause && wheel != 0 ) if( m_viewMode == ViewMode::Paused && wheel != 0 )
{ {
const int pfwidth = GetFrameWidth( prevScale ); const int pfwidth = GetFrameWidth( prevScale );
const int pgroup = GetFrameGroup( prevScale ); const int pgroup = GetFrameGroup( prevScale );
@ -1900,7 +1946,7 @@ void View::HandleZoneViewMouse( int64_t timespan, const ImVec2& wpos, float w, d
const auto hwheel_delta = io.MouseWheelH * 100.f; const auto hwheel_delta = io.MouseWheelH * 100.f;
if( IsMouseDragging( 1 ) || hwheel_delta != 0 ) if( IsMouseDragging( 1 ) || hwheel_delta != 0 )
{ {
m_pause = true; m_viewMode = ViewMode::Paused;
m_zoomAnim.active = false; m_zoomAnim.active = false;
if( !m_playback.pause && m_playback.sync ) m_playback.pause = true; if( !m_playback.pause && m_playback.sync ) m_playback.pause = true;
const auto delta = GetMouseDragDelta( 1 ); const auto delta = GetMouseDragDelta( 1 );
@ -1930,6 +1976,7 @@ void View::HandleZoneViewMouse( int64_t timespan, const ImVec2& wpos, float w, d
const auto wheel = io.MouseWheel; const auto wheel = io.MouseWheel;
if( wheel != 0 ) if( wheel != 0 )
{ {
if( m_viewMode == ViewMode::LastFrames ) m_viewMode = ViewMode::LastRange;
const double mouse = io.MousePos.x - wpos.x; const double mouse = io.MousePos.x - wpos.x;
const auto p = mouse / w; const auto p = mouse / w;
@ -1957,7 +2004,7 @@ void View::HandleZoneViewMouse( int64_t timespan, const ImVec2& wpos, float w, d
t0 -= std::max( int64_t( 1 ), int64_t( p1 * 0.25 ) ); t0 -= std::max( int64_t( 1 ), int64_t( p1 * 0.25 ) );
t1 += std::max( int64_t( 1 ), int64_t( p2 * 0.25 ) ); t1 += std::max( int64_t( 1 ), int64_t( p2 * 0.25 ) );
} }
ZoomToRange( t0, t1 ); ZoomToRange( t0, t1, m_viewMode == ViewMode::Paused );
} }
} }
@ -14197,6 +14244,7 @@ void View::DrawPlayback()
m_zoomAnim.active = false; m_zoomAnim.active = false;
m_vd.zvStart = tstart; m_vd.zvStart = tstart;
m_vd.zvEnd = end; m_vd.zvEnd = end;
m_viewMode = ViewMode::Paused;
} }
} }
@ -14298,6 +14346,8 @@ void View::DrawPlayback()
{ {
m_vd.zvStart = m_worker.GetFrameBegin( *frameSet, fi->frameRef ); m_vd.zvStart = m_worker.GetFrameBegin( *frameSet, fi->frameRef );
m_vd.zvEnd = m_worker.GetFrameEnd( *frameSet, fi->frameRef ); m_vd.zvEnd = m_worker.GetFrameEnd( *frameSet, fi->frameRef );
m_zoomAnim.active = false;
m_viewMode = ViewMode::Paused;
} }
} }
ImGui::SameLine(); ImGui::SameLine();
@ -16194,21 +16244,34 @@ void View::ZoomToZone( const GpuEvent& ev )
} }
} }
void View::ZoomToRange( int64_t start, int64_t end ) void View::ZoomToRange( int64_t start, int64_t end, bool pause )
{ {
if( start == end ) if( start == end )
{ {
end = start + 1; end = start + 1;
} }
m_pause = true; if( pause ) m_viewMode = ViewMode::Paused;
m_highlightZoom.active = false; m_highlightZoom.active = false;
if( !m_playback.pause && m_playback.sync ) m_playback.pause = true; if( !m_playback.pause && m_playback.sync ) m_playback.pause = true;
m_zoomAnim.active = true; m_zoomAnim.active = true;
m_zoomAnim.start0 = m_vd.zvStart; if( m_viewMode == ViewMode::LastRange )
m_zoomAnim.start1 = start; {
m_zoomAnim.end0 = m_vd.zvEnd; const auto rangeCurr = m_vd.zvEnd - m_vd.zvStart;
m_zoomAnim.end1 = end; const auto rangeDest = end - start;
m_zoomAnim.start0 = m_vd.zvStart;
m_zoomAnim.start1 = m_vd.zvStart - ( rangeDest - rangeCurr );
m_zoomAnim.end0 = m_vd.zvEnd;
m_zoomAnim.end1 = m_vd.zvEnd;
}
else
{
m_zoomAnim.start0 = m_vd.zvStart;
m_zoomAnim.start1 = start;
m_zoomAnim.end0 = m_vd.zvEnd;
m_zoomAnim.end1 = end;
}
m_zoomAnim.progress = 0; m_zoomAnim.progress = 0;
} }

View File

@ -122,6 +122,13 @@ private:
uint64_t mem; uint64_t mem;
}; };
enum class ViewMode
{
Paused,
LastFrames,
LastRange
};
void InitTextEditor( ImFont* font ); void InitTextEditor( ImFont* font );
const char* ShortenNamespace( const char* name ) const; const char* ShortenNamespace( const char* name ) const;
@ -213,7 +220,7 @@ private:
void ZoomToZone( const ZoneEvent& ev ); void ZoomToZone( const ZoneEvent& ev );
void ZoomToZone( const GpuEvent& ev ); void ZoomToZone( const GpuEvent& ev );
void ZoomToRange( int64_t start, int64_t end ); void ZoomToRange( int64_t start, int64_t end, bool pause = true );
void ZoomToPrevFrame(); void ZoomToPrevFrame();
void ZoomToNextFrame(); void ZoomToNextFrame();
void CenterAtTime( int64_t t ); void CenterAtTime( int64_t t );
@ -309,7 +316,7 @@ private:
Worker m_worker; Worker m_worker;
std::string m_filename; std::string m_filename;
bool m_staticView; bool m_staticView;
bool m_pause; ViewMode m_viewMode;
DecayValue<bool> m_forceConnectionPopup = false; DecayValue<bool> m_forceConnectionPopup = false;
ViewData m_vd; ViewData m_vd;