mirror/tracy
1
0
Fork 0
mirror of https://github.com/wolfpld/tracy.git synced 2024-11-26 07:54:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix: Don't let make_unique initialise data unnecessarily

Browse Source
This commit is contained in:
sean 2023-01-03 13:07:52 +01:00
parent 5a3d7b6f56
commit b597ab5a0a
No known key found for this signature in database
GPG Key ID: 78263DAF30EB1320
3 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
server/TracyUserData.cpp
View File

@ -40,7 +40,7 @@ UserData::UserData( const char* program, uint64_t time )
fseek( f, 0, SEEK_END );
const auto sz = ftell( f );
fseek( f, 0, SEEK_SET );
auto buf = std::make_unique<char[]>( sz );
auto buf = std::unique_ptr<char[]>(new char[sz]);
fread( buf.get(), 1, sz, f );
fclose( f );
m_description.assign( buf.get(), buf.get() + sz );

16
server/TracyView_ZoneInfo.cpp
View File

@ -1239,8 +1239,8 @@ void View::DrawZoneInfoChildren( const V& children, int64_t ztime )
ImGui::NextColumn();
if( expandGroup )
{
auto ctt = std::make_unique<uint64_t[]>( cgr.v.size() );
auto cti = std::make_unique<uint32_t[]>( cgr.v.size() );
auto ctt = std::unique_ptr<uint64_t[]>( new uint64_t[cgr.v.size()] );
auto cti = std::unique_ptr<uint32_t[]>( new uint32_t[cgr.v.size()] );
for( size_t i=0; i<cgr.v.size(); i++ )
{
const auto& child = a(children[cgr.v[i]]);
@ -1293,8 +1293,8 @@ void View::DrawZoneInfoChildren( const V& children, int64_t ztime )
}
else
{
auto ctt = std::make_unique<uint64_t[]>( children.size() );
auto cti = std::make_unique<uint32_t[]>( children.size() );
auto ctt = std::unique_ptr<uint64_t[]>( new uint64_t[children.size()] );
auto cti = std::unique_ptr<uint32_t[]>( new uint32_t[children.size()] );
uint64_t ctime = 0;
for( size_t i=0; i<children.size(); i++ )
{
@ -1691,8 +1691,8 @@ void View::DrawGpuInfoChildren( const V& children, int64_t ztime )
ImGui::NextColumn();
if( expandGroup )
{
auto ctt = std::make_unique<uint64_t[]>( cgr.v.size() );
auto cti = std::make_unique<uint32_t[]>( cgr.v.size() );
auto ctt = std::unique_ptr<uint64_t[]>( new uint64_t[cgr.v.size()] );
auto cti = std::unique_ptr<uint32_t[]>( new uint32_t[cgr.v.size()] );
for( size_t i=0; i<cgr.v.size(); i++ )
{
const auto& child = a(children[cgr.v[i]]);
@ -1740,8 +1740,8 @@ void View::DrawGpuInfoChildren( const V& children, int64_t ztime )
}
else
{
auto ctt = std::make_unique<uint64_t[]>( children.size() );
auto cti = std::make_unique<uint32_t[]>( children.size() );
auto ctt = std::unique_ptr<uint64_t[]>( new uint64_t[children.size()] );
auto cti = std::unique_ptr<uint32_t[]>( new uint32_t[children.size()] );
uint64_t ctime = 0;
for( size_t i=0; i<children.size(); i++ )
{

2
server/TracyWorker.cpp
View File

@ -2722,7 +2722,7 @@ const unordered_flat_map<CallstackFrameId, uint32_t, Worker::CallstackFrameIdHas
void Worker::Network()
{
auto ShouldExit = [this] { return m_shutdown.load( std::memory_order_relaxed ); };
auto lz4buf = std::make_unique<char[]>( LZ4Size );
auto lz4buf = std::unique_ptr<char[]>( new char[LZ4Size] );
for(;;)
{