mirror/tracy
1
0
Fork 0
mirror of https://github.com/wolfpld/tracy.git synced 2024-11-26 07:54:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

No need for indirection of ImageEntry vector.

Browse Source
This commit is contained in:
Bartosz Taudul 2023-12-12 19:27:53 +01:00
parent 5decb91cd0
commit cc3cbfe6f2
No known key found for this signature in database
GPG Key ID: B7FE2008B7575DF3
1 changed files with 9 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
public/client/TracyCallstack.cpp
View File

@ -112,19 +112,14 @@ public:
}; };
ImageCache() ImageCache()
: m_images( 512 )
{ {
m_images = (FastVector<ImageEntry>*)tracy_malloc( sizeof( FastVector<ImageEntry> ) );
new(m_images) FastVector<ImageEntry>( 512 );
Refresh(); Refresh();
} }
~ImageCache() ~ImageCache()
{ {
Clear(); Clear();
m_images->~FastVector<ImageEntry>();
tracy_free( m_images );
} }
const ImageEntry* GetImageForAddress( void* address ) const ImageEntry* GetImageForAddress( void* address )
@ -139,7 +134,7 @@ public:
} }
private: private:
tracy::FastVector<ImageEntry>* m_images; tracy::FastVector<ImageEntry> m_images;
bool m_updated; bool m_updated;
static int Callback( struct dl_phdr_info* info, size_t size, void* data ) static int Callback( struct dl_phdr_info* info, size_t size, void* data )
@ -154,7 +149,7 @@ private:
const auto endAddress = reinterpret_cast<void*>( info->dlpi_addr + const auto endAddress = reinterpret_cast<void*>( info->dlpi_addr +
info->dlpi_phdr[info->dlpi_phnum - 1].p_vaddr + info->dlpi_phdr[info->dlpi_phnum - 1].p_memsz); info->dlpi_phdr[info->dlpi_phnum - 1].p_vaddr + info->dlpi_phdr[info->dlpi_phnum - 1].p_memsz);
ImageEntry* image = cache->m_images->push_next(); ImageEntry* image = cache->m_images.push_next();
image->m_startAddress = startAddress; image->m_startAddress = startAddress;
image->m_endAddress = endAddress; image->m_endAddress = endAddress;
@ -191,7 +186,7 @@ private:
bool Contains( void* startAddress ) const bool Contains( void* startAddress ) const
{ {
return std::any_of( m_images->begin(), m_images->end(), [startAddress]( const ImageEntry& entry ) { return startAddress == entry.m_startAddress; } ); return std::any_of( m_images.begin(), m_images.end(), [startAddress]( const ImageEntry& entry ) { return startAddress == entry.m_startAddress; } );
} }
void Refresh() void Refresh()
@ -201,17 +196,17 @@ private:
if( m_updated ) if( m_updated )
{ {
std::sort( m_images->begin(), m_images->end(), std::sort( m_images.begin(), m_images.end(),
[]( const ImageEntry& lhs, const ImageEntry& rhs ) { return lhs.m_startAddress > rhs.m_startAddress; } ); []( const ImageEntry& lhs, const ImageEntry& rhs ) { return lhs.m_startAddress > rhs.m_startAddress; } );
} }
} }
const ImageEntry* GetImageForAddressImpl( void* address ) const const ImageEntry* GetImageForAddressImpl( void* address ) const
{ {
auto it = std::lower_bound( m_images->begin(), m_images->end(), address, auto it = std::lower_bound( m_images.begin(), m_images.end(), address,
[]( const ImageEntry& lhs, const void* rhs ) { return lhs.m_startAddress > rhs; } ); []( const ImageEntry& lhs, const void* rhs ) { return lhs.m_startAddress > rhs; } );
if( it != m_images->end() && address < it->m_endAddress ) if( it != m_images.end() && address < it->m_endAddress )
{ {
return it; return it;
} }
@ -220,12 +215,12 @@ private:
void Clear() void Clear()
{ {
for( ImageEntry& entry : *m_images ) for( ImageEntry& entry : m_images )
{ {
tracy_free( entry.m_name ); tracy_free( entry.m_name );
} }
m_images->clear(); m_images.clear();
} }
}; };
#endif //#ifdef TRACY_USE_IMAGE_CACHE #endif //#ifdef TRACY_USE_IMAGE_CACHE