Improve time to string conversion.

- Make sure comparison doesn't overflow.
- Time is not base-2 (doh!).
- Use doubles instead of floats for better precision.
- Support displaying minutes.
This commit is contained in:
Bartosz Taudul 2017-09-18 22:56:17 +02:00
parent 73f1a39928
commit df3cd193e5

View File

@ -332,17 +332,23 @@ const char* View::TimeToString( uint64_t ns ) const
{ {
sprintf( buf, "%i ns", ns ); sprintf( buf, "%i ns", ns );
} }
else if( ns < 1000 * 1000 ) else if( ns < 1000ull * 1000 )
{ {
sprintf( buf, "%.2f us", ns / 1024.f ); sprintf( buf, "%.2f us", ns / 1000. );
} }
else if( ns < 1000 * 1000 * 1000 ) else if( ns < 1000ull * 1000 * 1000 )
{ {
sprintf( buf, "%.2f ms", ns / ( 1024.f * 1024 ) ); sprintf( buf, "%.2f ms", ns / ( 1000. * 1000. ) );
}
else if( ns < 1000ull * 1000 * 1000 * 60 )
{
sprintf( buf, "%.2f s", ns / ( 1000. * 1000. * 1000. ) );
} }
else else
{ {
sprintf( buf, "%.2f s", ns / ( 1024.f * 1024 * 1024 ) ); const auto m = ns / ( 1000ull * 1000 * 1000 * 60 );
const auto s = ns - m * ( 1000ull * 1000 * 1000 * 60 );
sprintf( buf, "%i:%04.1f", m, s / ( 1000. * 1000. * 1000. ) );
} }
return buf; return buf;
} }