PR feedback

This commit is contained in:
Joshua Kriegshauser 2024-10-02 11:21:14 -07:00
parent 9dfb1e98b9
commit e1554a13e0
2 changed files with 2 additions and 3 deletions

View File

@ -1463,7 +1463,6 @@ Profiler::Profiler()
m_userPort = atoi( userPort ); m_userPort = atoi( userPort );
} }
m_safeSendBufferSize = 65536;
m_safeSendBuffer = (char*)tracy_malloc( m_safeSendBufferSize ); m_safeSendBuffer = (char*)tracy_malloc( m_safeSendBufferSize );
#ifndef _WIN32 #ifndef _WIN32
@ -1528,7 +1527,7 @@ void Profiler::RemoveCrashHandler()
#if defined __linux__ && !defined TRACY_NO_CRASH_HANDLER #if defined __linux__ && !defined TRACY_NO_CRASH_HANDLER
if( m_crashHandlerInstalled ) if( m_crashHandlerInstalled )
{ {
auto restore = [ this ]( int signum, struct sigaction* prev ) { auto restore = []( int signum, struct sigaction* prev ) {
struct sigaction old; struct sigaction old;
sigaction( signum, prev, &old ); sigaction( signum, prev, &old );
if( old.sa_sigaction != CrashHandler ) sigaction( signum, &old, nullptr ); // A different signal handler was installed over ours => put it back if( old.sa_sigaction != CrashHandler ) sigaction( signum, &old, nullptr ); // A different signal handler was installed over ours => put it back

View File

@ -1010,7 +1010,7 @@ private:
std::atomic_bool m_inUse{ false }; std::atomic_bool m_inUse{ false };
#endif #endif
char* m_safeSendBuffer; char* m_safeSendBuffer;
size_t m_safeSendBufferSize; constexpr static size_t m_safeSendBufferSize = 65536;
#if defined _WIN32 #if defined _WIN32
void* m_prevHandler; void* m_prevHandler;