mirror/tracy
1
0
Fork 0
mirror of https://github.com/wolfpld/tracy.git synced 2024-11-26 07:54:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix race condition for symbols resolution on windows

Browse Source 
There might have been new modules loaded by another thread between the `SymInitialize` and `EnumProcessModules` calls.
Since we register the enumerated modules into the cache, we need to make sure that symbols for this module are loaded.
The only way to do that is to call `SymLoadModuleEx`, just like we do when finding new modules after `InitCallstack`.
This commit is contained in:
Lectem 2023-02-14 15:32:37 +01:00
parent 15ad9aef78
commit ecdf6adc32
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
public/client/TracyCallstack.cpp
View File

@ -227,6 +227,10 @@ void InitCallstack()
const auto res = GetModuleFileNameA( mod[i], name, 1021 ); const auto res = GetModuleFileNameA( mod[i], name, 1021 );
if( res > 0 ) if( res > 0 )
{ {
// This may be a new module loaded since our call to SymInitialize.
// Just in case, force DbgHelp to load its pdb !
SymLoadModuleEx(proc, NULL, name, NULL, (DWORD64)info.lpBaseOfDll, info.SizeOfImage, NULL, 0);
auto ptr = name + res; auto ptr = name + res;
while( ptr > name && *ptr != '\\' && *ptr != '/' ) ptr--; while( ptr > name && *ptr != '\\' && *ptr != '/' ) ptr--;
if( ptr > name ) ptr++; if( ptr > name ) ptr++;