Commit Graph

408 Commits

Author SHA1 Message Date
Bartosz Taudul
1b7e8c3520
Use ImGui keycodes. 2022-04-27 01:16:46 +02:00
Bartosz Taudul
95cf143336
Remove unused variables. 2022-04-26 22:01:09 +02:00
Bartosz Taudul
c9240c100d
Fix initialization order. 2022-04-26 22:01:09 +02:00
Bartosz Taudul
1f3ebc9f41
Use item spacing instead of ExtraLineHeight. 2022-04-26 21:11:38 +02:00
Bartosz Taudul
d56741cbeb
Stop pretending to not require additional fonts. 2022-04-25 23:29:44 +02:00
bjacob
e6a29862ec
Fix column widths for hw counts and source location (#369)
Fix column widths for hw counts and source location
2022-04-21 18:30:55 +02:00
Bartosz Taudul
a852cf390a
Adapt code to new NFD. 2022-04-20 19:40:27 +02:00
Bartosz Taudul
1fd39e90b9
Implement navigation from jump arrow context menu. 2022-04-06 23:41:46 +02:00
Bartosz Taudul
0e56397c5a
Don't show empty menu when source is not available. 2022-04-06 23:34:30 +02:00
Bartosz Taudul
7893a83633
Display jump arrow context (src and target source code). 2022-04-06 02:01:29 +02:00
Bartosz Taudul
db3736983a
Always open jump arrow context menu. 2022-04-06 02:01:07 +02:00
Bartosz Taudul
4555910536
Extract source fragment printing functionality. 2022-04-06 01:54:14 +02:00
Bartosz Taudul
1b3464a386
Fix wrong source color box. 2022-04-06 01:42:13 +02:00
Bartosz Taudul
e34d79c0c7
Display target location for local jumps. 2022-04-06 01:23:35 +02:00
Bartosz Taudul
2fc64fceba
Select appropriate branch cost, if no retirement data. 2022-04-01 19:09:56 +02:00
Bartosz Taudul
88a153504d
Show branch impact if no retirement data available.
Some CPUs are only able to report branch miss data, but not branch retirement
data.
2022-04-01 19:06:15 +02:00
Bartosz Taudul
c6da04a18b
Use TooltipIfHovered() where appropriate. 2022-01-01 16:57:48 +01:00
Bartosz Taudul
5d439c0165
Round jump separation. 2021-12-30 16:35:18 +01:00
Bartosz Taudul
adb168a5ea
Fix offset. 2021-12-30 03:19:03 +01:00
Bartosz Taudul
36068d1f2b
Condense hw samples. 2021-12-29 14:07:37 +01:00
Bartosz Taudul
0d5fbff07f
Adjust jump arrow separation to DPI scale. 2021-12-29 13:44:58 +01:00
Bartosz Taudul
ae9b9318e8
Fix calculation of jump arrows offset. 2021-12-29 13:41:55 +01:00
Bartosz Taudul
81de0a3a75
Display source location of symbol functions. 2021-12-24 03:19:13 +01:00
Bartosz Taudul
dc2ac4e4b3
Display child calls source locations. 2021-12-24 03:11:46 +01:00
Bartosz Taudul
acd8a32672
Fix referencing unknown symbol. 2021-12-24 02:36:28 +01:00
Bartosz Taudul
c4c43ef7fe
Take rounding into consideration. 2021-12-23 16:02:07 +01:00
Bartosz Taudul
b83cda575a
Add Rembrandt cpuid. 2021-12-23 13:34:24 +01:00
Bartosz Taudul
29d7115815
Add ADL cpuid. 2021-12-23 13:32:17 +01:00
Bartosz Taudul
12e0cb2036
Reorder uarch list. Push old ones to the bottom. 2021-12-23 13:28:06 +01:00
Bartosz Taudul
4642afdb9d
Add Alder Lake to uarch selection list. 2021-12-23 13:24:26 +01:00
Bartosz Taudul
6b59ccfe4d
GetFontSize() -> GetTextLineHeight(). 2021-12-22 17:57:57 +01:00
Bartosz Taudul
9fae8b7e42
Don't use obsolete functions. 2021-12-22 17:08:27 +01:00
Bartosz Taudul
52eeddd63a
Fix display of entry call stacks when inlines are present. 2021-11-27 16:41:27 +01:00
Bartosz Taudul
a84fd26ecb
Change toggle button to faux drop down. 2021-11-27 15:40:23 +01:00
Bartosz Taudul
58d5fb2ff4
Fix calculation of child sample counts. 2021-11-27 14:49:22 +01:00
Bartosz Taudul
702c87dad0
Display list of child calls. 2021-11-27 14:43:31 +01:00
Bartosz Taudul
6a7b4e6066
Add calculation of child stats to source view. 2021-11-27 14:42:23 +01:00
Bartosz Taudul
85f755f3f5
Use proper base symbol address. 2021-11-27 14:30:46 +01:00
Bartosz Taudul
a02575322f
Collect child sample addresses. 2021-11-27 02:03:59 +01:00
Bartosz Taudul
b3562c99fb
Display jump target/source function names. 2021-11-20 14:50:26 +01:00
Bartosz Taudul
7b2ed41179
Push small font to SourceView. 2021-11-20 14:47:13 +01:00
Bartosz Taudul
f0d524ad1f
Don't pass font to SourceView ctor. 2021-11-20 14:44:22 +01:00
Bartosz Taudul
b4dab753e6
List jump source locations. 2021-11-20 02:30:49 +01:00
Bartosz Taudul
fbe85ff8d3
Adapt hotness indicators to DPI scale. 2021-11-20 02:19:50 +01:00
Bartosz Taudul
d0d0aca758
Use font helpers. 2021-11-19 21:09:13 +01:00
Bartosz Taudul
e0a6c51a2f
Add font set/unset helpers. 2021-11-19 21:06:07 +01:00
Bartosz Taudul
dd8083e0ee
Prevent out-of-bounds access.
This fixes the issue when assembly view is scrolled to the bottom of the
screen and display scale is reduced by the user. In such case clipper will
report DisplayStart to be at the end element, which would cause out-of-bounds
access to the m_asm array.

Clipper self-fixes this in the next frame, so this workaround is enough.
2021-11-19 20:58:09 +01:00
Bartosz Taudul
c23abca979
Round jump arrows offsets. 2021-11-19 20:56:09 +01:00
Bartosz Taudul
404168ec69
Check whether symbols are ready, not source locations. 2021-11-14 15:51:29 +01:00
Bartosz Taudul
864d7e4e47
Sort symbols list only when actually needed. 2021-11-14 13:05:05 +01:00
Bartosz Taudul
265a39e7c9
Don't select out-of-context asm lines. 2021-11-13 17:35:02 +01:00
Bartosz Taudul
50627646c1
Don't highlight asm lines out of context on hover. 2021-11-13 16:36:46 +01:00
Bartosz Taudul
25316ddada
Display notification icon when context is limited. 2021-11-13 16:34:51 +01:00
Bartosz Taudul
cc425c4a2d
Separate function for checking asm function context. 2021-11-13 16:34:50 +01:00
Bartosz Taudul
7304558bdf
Cycle through assembly blocks when right-clicking source line. 2021-07-26 01:21:58 +02:00
Bartosz Taudul
55a966f9c6
Fix assert. 2021-07-26 01:18:17 +02:00
Bartosz Taudul
06ae39d9cc
Fix debug build. 2021-07-18 16:34:24 +02:00
Bartosz Taudul
8b489c95ff
Rename slow branches/cache to branch/cache impact. 2021-07-18 16:15:32 +02:00
Bartosz Taudul
0e603a0997
Render relative hw samples values. 2021-07-18 16:15:32 +02:00
Bartosz Taudul
d0fad4fd39
Rename relative hw samples to "impact". 2021-07-18 16:15:31 +02:00
Bartosz Taudul
83b159b43b
Count hw stats, if relative mode is set. 2021-07-18 15:00:22 +02:00
Bartosz Taudul
fbf2c87a20
Include hw stats in AddrStatData. 2021-07-18 15:00:22 +02:00
Bartosz Taudul
e30608afbf
Store and pass AddrStat data in one data structure. 2021-07-18 15:00:22 +02:00
Bartosz Taudul
9c7a122d94
Implement counting relative hw samples data.
This exploits the fact that AddrStat has two data fields (local and ext) to
store branch and cache information.
2021-07-18 15:00:22 +02:00
Bartosz Taudul
8c78af4d00
Drop limitView from GatherIpHwStats interface. 2021-07-18 15:00:21 +02:00
Bartosz Taudul
a5e655d1ee
Add relative hw samples checkbox. 2021-07-18 15:00:21 +02:00
Bartosz Taudul
b4c1313a2e
Make hw stats cost a parameter. 2021-07-18 02:03:29 +02:00
Bartosz Taudul
0e0692b7f7
Don't display hw samples as time in selected lines summary. 2021-06-20 16:01:19 +02:00
Bartosz Taudul
e9aca02880
Make hw sample cost in source files relative to whole symbol. 2021-06-20 15:55:21 +02:00
Bartosz Taudul
5efc03cdf9
Move cycles up in cost combo selector. 2021-06-20 12:50:13 +02:00
Bartosz Taudul
7e17c8643c
Don't show hw events as time. 2021-06-20 01:08:18 +02:00
Bartosz Taudul
bc4016e97c
Don't depend on callstack frames to match hw samples to source. 2021-06-20 01:01:29 +02:00
Bartosz Taudul
2f3ee594f0
Use square root to make slow branches and cache less spiky. 2021-06-20 00:50:14 +02:00
Bartosz Taudul
3305ea2775
Keep raw hw sample data visually separate. 2021-06-20 00:46:29 +02:00
Bartosz Taudul
07fe0a5447
Use enum for cost selection. 2021-06-20 00:45:39 +02:00
Bartosz Taudul
80e1b0c2cf
Don't display hw samples as time in files list. 2021-06-20 00:14:19 +02:00
Bartosz Taudul
52708268fe
Store 64-bit integers in AddrStat. 2021-06-20 00:08:25 +02:00
Bartosz Taudul
4e6a1bae22
Don't display time for hw samples. 2021-06-20 00:04:08 +02:00
Bartosz Taudul
326a2a70d8
Add indirect hw statistics. 2021-06-20 00:01:37 +02:00
Bartosz Taudul
ad2b6e932b
Don't scroll cost combo list. 2021-06-20 00:01:21 +02:00
Bartosz Taudul
a5991036dc
Add more hw stats as cost. 2021-06-19 23:43:46 +02:00
Bartosz Taudul
c7b3d42852
Calculating cost in cycles and retirements. 2021-06-19 23:39:33 +02:00
Bartosz Taudul
90149641df
Reset cost selection when no samples. 2021-06-19 23:17:24 +02:00
Bartosz Taudul
8d52d2acfd
Disable inline context if no inline symbols available. 2021-06-19 21:40:30 +02:00
Bartosz Taudul
2e3241ba54
Restrict hardware samples to inline function context. 2021-06-19 20:50:06 +02:00
Bartosz Taudul
6cc844abee
Display inline symbol address. 2021-06-19 20:20:52 +02:00
Bartosz Taudul
748c22df8e
Darken assembly instructions which aren't in current context. 2021-06-19 20:11:53 +02:00
Bartosz Taudul
8045ceee5d
Display function assigned to assembly line. 2021-06-19 19:52:33 +02:00
Bartosz Taudul
cc0ca341bb
Add cost criteria selection UI. 2021-06-19 18:16:11 +02:00
Bartosz Taudul
7ad9cafefb
Add child call samples hints to the UI. 2021-06-19 17:41:29 +02:00
Bartosz Taudul
85da04bcc4
Add hw samples line part to source view. 2021-06-09 00:19:17 +02:00
Bartosz Taudul
def9570eda
Extract rendering hw samples line part. 2021-06-09 00:19:17 +02:00
Bartosz Taudul
18cace42ca
Display hw samples tooltip for source lines. 2021-06-08 23:46:30 +02:00
Bartosz Taudul
82bfee5127
Move helper functions to top of the file. 2021-06-08 23:46:29 +02:00
Bartosz Taudul
2eb50bcf42
Hardware sample data was already queried. 2021-06-08 23:46:29 +02:00
Bartosz Taudul
b68c23fc64
Update x86 CPU models list. 2021-06-04 18:59:41 +02:00
Bartosz Taudul
4316d48bea
Add a note about CPUID list. 2021-06-04 18:48:01 +02:00
Bartosz Taudul
7c378cd0a9
Add Rocket Lake uarch data. 2021-06-04 18:40:37 +02:00
Bartosz Taudul
0b05587b05
Don't need to format const string. 2021-06-04 15:27:23 +02:00
Bartosz Taudul
3c31fb56a8
Allow range-limiting hardware samples. 2021-06-04 13:58:00 +02:00