Commit Graph

8236 Commits

Author SHA1 Message Date
Bartosz Taudul
2e9d8f8215
Check if external threads are local.
For some unknown reason, local threads may be attributed to an external
process (at least when profiling on Windows). This causes some problems,
for example the CPU usage graph may show that CPU is pegged by some other
program, when it reality it is the profiled program that uses the CPU time.

Workaround by checking first, if the thread id is known to be local by the
profiler, i.e. if there were user-generated events originating from it.

This still leaves other things, such as the CPU data list, being wrong,
but the CPU data is meant to show raw TID -> PID mapping. If the source
data is wrong, there's not much to fix here.
2023-04-30 13:55:49 +02:00
Bartosz Taudul
0f0ac2d6c5
No longer need glGenerateMipmap. 2023-04-29 13:11:16 +02:00
Bartosz Taudul
e1e4699a52
Load custom mip chain for zigzags. 2023-04-29 13:10:58 +02:00
Bartosz Taudul
657bf7d44c
Add images for more proper zigzag mip chain.
1x1 and 2x2 paths are 16 px wide.
4x4 path is 8 px wide.
8x8 path is 4 px wide.
16x16 path is 2 px wide.
32x32 path is 1.5 px wide.
2023-04-29 12:47:29 +02:00
Kristoffer
ef68f3139f allow filtering zones in Zone finder based on the user text 2023-04-28 16:54:29 +02:00
Bartosz Taudul
b83cb3f2ce
Don't use hacks to determine end time. 2023-04-28 00:00:20 +02:00
Bartosz Taudul
474dc6945e
Draw zigzags using bitmaps. 2023-04-27 23:17:35 +02:00
Bartosz Taudul
62ec968f24
Load zigzag texture. 2023-04-27 23:17:34 +02:00
Bartosz Taudul
42aeece7fd
Allow generating texture mip maps. 2023-04-27 23:17:34 +02:00
Bartosz Taudul
d131f22354
Special-case creating zigzag texture. 2023-04-27 23:17:34 +02:00
Bartosz Taudul
383f1ea8f1
Update OpenGL loader. 2023-04-27 23:17:34 +02:00
Bartosz Taudul
f7b12e2dda
Add zigzag bitmap. 2023-04-27 23:17:34 +02:00
Bartosz Taudul
52e3ae719d
Remove missed plot vector sorting during draw. 2023-04-27 17:36:11 +02:00
Bartosz Taudul
082beb66c9
Update NEWS. 2023-04-26 01:14:31 +02:00
Bartosz Taudul
e42e566dae
Error indicators are no more. 2023-04-26 00:54:09 +02:00
Bartosz Taudul
5f66cd8718
Don't use delay and resolution when processing GPU zones. 2023-04-26 00:50:13 +02:00
Bartosz Taudul
745ca83de6
PreprocessLocks() doesn't use yPos. 2023-04-26 00:47:50 +02:00
Bartosz Taudul
798249c81c
Remove error indicators for CPU zones. 2023-04-26 00:46:45 +02:00
Bartosz Taudul
72b1ff6477
Early exit on empty plots. 2023-04-25 00:35:53 +02:00
Bartosz Taudul
6aa9169901
Reduce number of plot samples from 1024 to 256.
Having 1024 samples proved to be too slow.
2023-04-25 00:27:17 +02:00
Bartosz Taudul
3811c8ace4
Remove redundant check.
There is already check for zoneFree being non-nullptr, so it makes no sense
to check zoneAlloc for that again, if it has to match zoneFree.
2023-04-25 00:04:59 +02:00
Bartosz Taudul
c8c6646f52
Simplify condition. 2023-04-25 00:03:48 +02:00
Bartosz Taudul
88cb43ad84
Don't write what is never read. 2023-04-25 00:00:30 +02:00
Bartosz Taudul
fa815f3c3b
Remove redundant check. 2023-04-24 23:57:27 +02:00
Bartosz Taudul
def30228c9
Draw plots using preprocessed draw lists. 2023-04-24 23:28:29 +02:00
Bartosz Taudul
96800a2753
Do not merge small groups of plot points (up to three). 2023-04-24 23:28:29 +02:00
Bartosz Taudul
616992a6d5
Do not include DPI scaling when grouping plot points. 2023-04-24 23:28:29 +02:00
Bartosz Taudul
102bb9f8a8
Include before-start plot item, so that the plot doesn't begin abruptly. 2023-04-24 23:28:28 +02:00
Bartosz Taudul
8eb2cc83b3
Push plot draw list to DrawPlot(). 2023-04-24 23:28:28 +02:00
Bartosz Taudul
8f5022c3c8
Calculate draw lists for plots. 2023-04-24 23:28:28 +02:00
Bartosz Taudul
0217c06377
Cosmetics. 2023-04-24 23:28:28 +02:00
Bartosz Taudul
396d4f6f3c
Merge pull request #555 from nehasharan/nehasharan/csvexport_messages
Added an option to print out "messages" while exporting a .trace file to CSV using "csvexport" utility
2023-04-20 23:46:57 +02:00
Neha Sharan
534baa829d correcting indentation 2023-04-20 14:27:15 -07:00
Bartosz Taudul
33c3d8229b
Add clang-tidy config. 2023-04-20 22:48:29 +02:00
Bartosz Taudul
ac29cffd3a
Fix assert condition. 2023-04-20 21:41:15 +02:00
Neha Sharan
518fd6ec79 cosmetic change 2023-04-20 10:09:13 -07:00
Neha Sharan
5acf66a2d4 Added an option to print out messages while exporting a .trace file to CSV using csvexport utility 2023-04-19 12:44:43 -07:00
Bartosz Taudul
7797557e8c
Don't pass memname parameter to functions handling allocation changes. 2023-04-16 18:12:14 +02:00
Bartosz Taudul
38b7aab4ef
Remove unused parameters from various payload handling functions. 2023-04-16 18:08:48 +02:00
Bartosz Taudul
3b00e55235
Rename IsThreadStringRetrieved -> IsFailureThreadStringRetrieved.
IsThreadStringRetrieved() interface suggested that it can be used for
checking any thread state, as it had an uint64_t id parameter.

The implementation ignored this parameter and checked the status of
failure thread only. This was never an issue because the code using
this function was only checking for the failure thread state.

Fixed by renaming the function to explicitly state what it does and
removing the thread id parameter.
2023-04-16 17:49:21 +02:00
Bartosz Taudul
b64bab197a
No need for GetZoneName() with GpuEvent + srcloc parameters. 2023-04-16 17:46:15 +02:00
Bartosz Taudul
08e6248299
CalcZoneTimeDataImpl() doesn't need zone parameter. 2023-04-16 17:40:16 +02:00
Bartosz Taudul
8d565e46d6
HandleTimelineMouse() doesn't need pxns parameter. 2023-04-16 17:36:04 +02:00
Bartosz Taudul
dec4713854
ListMemData() doesn't use id parameter. 2023-04-16 17:30:53 +02:00
Bartosz Taudul
adb2f9a664
GetFrameTreeItemNoGroup() doesn't need worker paramater. 2023-04-16 17:23:19 +02:00
Bartosz Taudul
31b3fcd1fe
View::InitTextEditor() doesn't need font parameter. 2023-04-16 17:21:03 +02:00
Bartosz Taudul
1c13c1ee8f
ThreadCompress::Load() doesn't need fileVer. 2023-04-16 17:17:07 +02:00
Bartosz Taudul
f60e51c91b
Fix std::move() usage. 2023-04-16 16:47:47 +02:00
Bartosz Taudul
a0221c8660
Pass function objects through const references. 2023-04-16 16:44:18 +02:00
Bartosz Taudul
778d0cb3fb
Socket::ReadUpTo() doesn't support timeouts. 2023-04-16 12:19:48 +02:00