From 441938d7310ec93da0dab3db1afa7800093c99a3 Mon Sep 17 00:00:00 2001 From: Charles Giessen <46324611+charles-lunarg@users.noreply.github.com> Date: Sun, 18 Apr 2021 14:09:12 -0600 Subject: [PATCH] Revert "Pass by value rather than ref." This reverts commit 3dc81e44df36ab48e2299906e621d0c92168aeab. --- src/VkBootstrap.cpp | 4 ++-- src/VkBootstrap.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/VkBootstrap.cpp b/src/VkBootstrap.cpp index 4f9b3b2..b4bafa2 100644 --- a/src/VkBootstrap.cpp +++ b/src/VkBootstrap.cpp @@ -1259,13 +1259,13 @@ PhysicalDeviceSelector& PhysicalDeviceSelector::set_desired_version(uint32_t maj #if defined(VK_API_VERSION_1_2) // Just calls add_required_features PhysicalDeviceSelector& PhysicalDeviceSelector::set_required_features_11( - VkPhysicalDeviceVulkan11Features features_11) { + VkPhysicalDeviceVulkan11Features& features_11) { features_11.sType = VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_VULKAN_1_1_FEATURES; add_required_extension_features(features_11); return *this; } PhysicalDeviceSelector& PhysicalDeviceSelector::set_required_features_12( - VkPhysicalDeviceVulkan12Features features_12) { + VkPhysicalDeviceVulkan12Features& features_12) { features_12.sType = VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_VULKAN_1_2_FEATURES; add_required_extension_features(features_12); return *this; diff --git a/src/VkBootstrap.h b/src/VkBootstrap.h index 2379f3c..4a03925 100644 --- a/src/VkBootstrap.h +++ b/src/VkBootstrap.h @@ -549,10 +549,10 @@ class PhysicalDeviceSelector { #if defined(VK_API_VERSION_1_2) // Require a physical device which supports the features in VkPhysicalDeviceVulkan11Features. // Must have vulkan version 1.2 - This is due to the VkPhysicalDeviceVulkan11Features struct being added in 1.2, not 1.1 - PhysicalDeviceSelector& set_required_features_11(VkPhysicalDeviceVulkan11Features features_11); + PhysicalDeviceSelector& set_required_features_11(VkPhysicalDeviceVulkan11Features& features_11); // Require a physical device which supports the features in VkPhysicalDeviceVulkan12Features. // Must have vulkan version 1.2 - PhysicalDeviceSelector& set_required_features_12(VkPhysicalDeviceVulkan12Features features_12); + PhysicalDeviceSelector& set_required_features_12(VkPhysicalDeviceVulkan12Features& features_12); #endif // Used when surface creation happens after physical device selection.