shylie/llvm-project
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Reland: [OpenMP][clang] 6.0: num_threads strict (part 1: host runtime) (#147532)

Browse Source 
OpenMP 6.0 12.1.2 specifies the behavior of the strict modifier for the
num_threads clause on parallel directives, along with the message and
severity clauses. This commit implements necessary host runtime changes.

Reland https://github.com/llvm/llvm-project/pull/146403. After manual
testing on a gfx90a machine, I could not reproduce the failing test,
which makes it even more likely that the test has just been flaky. (Or
at least that it's not an issue related to this patch.)
This commit is contained in:
Robert Imschweiler 2025-07-08 17:19:40 +02:00 committed by GitHub
parent 2fd37c9f33
commit 02aacc4cef
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
openmp/runtime/src/kmp_runtime.cpp
View File

@ -1214,6 +1214,12 @@ void __kmp_serialized_parallel(ident_t *loc, kmp_int32 global_tid) {
// Reset for next parallel region
this_thr->th.th_set_proc_bind = proc_bind_default;
// OpenMP 6.0 12.1.2 requires the num_threads 'strict' modifier to also have
// effect when parallel execution is disabled by a corresponding if clause
// attached to the parallel directive.
if (this_thr->th.th_nt_strict && this_thr->th.th_set_nproc > 1)
__kmpc_error(this_thr->th.th_nt_loc, this_thr->th.th_nt_sev,
this_thr->th.th_nt_msg);
// Reset num_threads for next parallel region
this_thr->th.th_set_nproc = 0;