shylie/llvm-project
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[IA] Naming and style cleanup [nfc]

Browse Source 
1) Rename argument II to something slightly more descriptive since we have
more than one IntrinsicInst flowing through.
2) Perform a checked dyn_cast early to eliminate two casts later in each
routine.
This commit is contained in:
Philip Reames 2025-07-21 12:38:55 -07:00 committed by Philip Reames
parent 4184a1b581
commit 033df384cd
1 changed files with 17 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
llvm/lib/CodeGen/InterleavedAccessPass.cpp
View File

@ -600,8 +600,8 @@ static Value *getMask(Value *WideMask, unsigned Factor,
bool InterleavedAccessImpl::lowerDeinterleaveIntrinsic(
IntrinsicInst *DI, SmallSetVector<Instruction *, 32> &DeadInsts) {
Value *LoadedVal = DI->getOperand(0);
if (!LoadedVal->hasOneUse())
Instruction *LoadedVal = dyn_cast<Instruction>(DI->getOperand(0));
if (!LoadedVal || !LoadedVal->hasOneUse())
return false;
auto *LI = dyn_cast<LoadInst>(LoadedVal);
@ -645,26 +645,27 @@ bool InterleavedAccessImpl::lowerDeinterleaveIntrinsic(
}
// Try and match this with target specific intrinsics.
if (!TLI->lowerDeinterleaveIntrinsicToLoad(cast<Instruction>(LoadedVal), Mask,
DI))
if (!TLI->lowerDeinterleaveIntrinsicToLoad(LoadedVal, Mask, DI))
return false;
DeadInsts.insert(DI);
// We now have a target-specific load, so delete the old one.
DeadInsts.insert(cast<Instruction>(LoadedVal));
DeadInsts.insert(LoadedVal);
return true;
}
bool InterleavedAccessImpl::lowerInterleaveIntrinsic(
IntrinsicInst *II, SmallSetVector<Instruction *, 32> &DeadInsts) {
if (!II->hasOneUse())
IntrinsicInst *IntII, SmallSetVector<Instruction *, 32> &DeadInsts) {
if (!IntII->hasOneUse())
return false;
Instruction *StoredBy = dyn_cast<Instruction>(IntII->user_back());
if (!StoredBy)
return false;
Value *StoredBy = II->user_back();
if (!isa<StoreInst, VPIntrinsic>(StoredBy))
return false;
SmallVector<Value *, 8> InterleaveValues(II->args());
const unsigned Factor = getInterleaveIntrinsicFactor(II->getIntrinsicID());
SmallVector<Value *, 8> InterleaveValues(IntII->args());
const unsigned Factor = getInterleaveIntrinsicFactor(IntII->getIntrinsicID());
assert(Factor && "unexpected interleave intrinsic");
Value *Mask = nullptr;
@ -679,24 +680,23 @@ bool InterleavedAccessImpl::lowerInterleaveIntrinsic(
return false;
LLVM_DEBUG(dbgs() << "IA: Found a vp.store with interleave intrinsic "
<< *II << " and factor = " << Factor << "\n");
<< *IntII << " and factor = " << Factor << "\n");
} else {
auto *SI = cast<StoreInst>(StoredBy);
if (!SI->isSimple())
return false;
LLVM_DEBUG(dbgs() << "IA: Found a store with interleave intrinsic " << *II
<< " and factor = " << Factor << "\n");
LLVM_DEBUG(dbgs() << "IA: Found a store with interleave intrinsic "
<< *IntII << " and factor = " << Factor << "\n");
}
// Try and match this with target specific intrinsics.
if (!TLI->lowerInterleaveIntrinsicToStore(cast<Instruction>(StoredBy), Mask,
InterleaveValues))
if (!TLI->lowerInterleaveIntrinsicToStore(StoredBy, Mask, InterleaveValues))
return false;
// We now have a target-specific store, so delete the old one.
DeadInsts.insert(cast<Instruction>(StoredBy));
DeadInsts.insert(II);
DeadInsts.insert(StoredBy);
DeadInsts.insert(IntII);
return true;
}