shylie/llvm-project
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[lldb][Modules] Fix error handling of parseAndLoadModuleMapFile (#141220)

Browse Source 
`parseAndLoadModuleMapFile` returns `true` on error. This seems to have
always been an issue? This is now preventing me from fixing a different
modules related issue. So this patch checks the return value correctly.
This commit is contained in:
Michael Buch 2025-05-27 09:29:31 +01:00 committed by GitHub
parent 692d9f26b5
commit 052c70451a
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lldb/source/Plugins/ExpressionParser/Clang/ClangModulesDeclVendor.cpp
View File

@ -330,7 +330,7 @@ bool ClangModulesDeclVendorImpl::AddModule(const SourceModule &module,
auto file = HS.lookupModuleMapFile(*dir, is_framework);
if (!file)
return error();
if (!HS.parseAndLoadModuleMapFile(*file, is_system))
if (HS.parseAndLoadModuleMapFile(*file, is_system))
return error();
}
}