shylie/llvm-project
1
0
Fork 0
Code Issues Pull Requests Actions 6 Packages Projects Releases Wiki Activity

[libc++] Simplify the implementation of __formatter::__fill a bit (#147777)

Browse Source 
This replaces some SFINAE with `if constexpr`.
This commit is contained in:
Nikolas Klauser 2025-11-03 10:41:55 +01:00 committed by GitHub
parent 40a042e49c
commit 0569cc141b
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 28 additions and 32 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

60
libcxx/include/__format/formatter_output.h
View File

@ -151,45 +151,41 @@ _LIBCPP_HIDE_FROM_ABI _OutIt __fill(_OutIt __out_it, size_t __n, _CharT __value)
}
}
template <__fmt_char_type _CharT, output_iterator<const _CharT&> _OutIt>
_LIBCPP_HIDE_FROM_ABI _OutIt __fill(_OutIt __out_it, size_t __n, __format_spec::__code_point<_CharT> __value) {
# if _LIBCPP_HAS_UNICODE
template <__fmt_char_type _CharT, output_iterator<const _CharT&> _OutIt>
requires(same_as<_CharT, char>)
_LIBCPP_HIDE_FROM_ABI _OutIt __fill(_OutIt __out_it, size_t __n, __format_spec::__code_point<_CharT> __value) {
std::size_t __bytes = std::countl_one(static_cast<unsigned char>(__value.__data[0]));
if (__bytes == 0)
return __formatter::__fill(std::move(__out_it), __n, __value.__data[0]);
for (size_t __i = 0; __i < __n; ++__i)
__out_it = __formatter::__copy(
std::addressof(__value.__data[0]), std::addressof(__value.__data[0]) + __bytes, std::move(__out_it));
return __out_it;
}
if constexpr (same_as<_CharT, char>) {
std::size_t __bytes = std::countl_one(static_cast<unsigned char>(__value.__data[0]));
if (__bytes == 0)
return __formatter::__fill(std::move(__out_it), __n, __value.__data[0]);
for (size_t __i = 0; __i < __n; ++__i)
__out_it = __formatter::__copy(
std::addressof(__value.__data[0]), std::addressof(__value.__data[0]) + __bytes, std::move(__out_it));
return __out_it;
# if _LIBCPP_HAS_WIDE_CHARACTERS
template <__fmt_char_type _CharT, output_iterator<const _CharT&> _OutIt>
requires(same_as<_CharT, wchar_t> && sizeof(wchar_t) == 2)
_LIBCPP_HIDE_FROM_ABI _OutIt __fill(_OutIt __out_it, size_t __n, __format_spec::__code_point<_CharT> __value) {
if (!__unicode::__is_high_surrogate(__value.__data[0]))
return __formatter::__fill(std::move(__out_it), __n, __value.__data[0]);
} else if constexpr (same_as<_CharT, wchar_t>) {
if constexpr (sizeof(wchar_t) == 2) {
if (!__unicode::__is_high_surrogate(__value.__data[0]))
return __formatter::__fill(std::move(__out_it), __n, __value.__data[0]);
for (size_t __i = 0; __i < __n; ++__i)
__out_it = __formatter::__copy(
std::addressof(__value.__data[0]), std::addressof(__value.__data[0]) + 2, std::move(__out_it));
return __out_it;
}
template <__fmt_char_type _CharT, output_iterator<const _CharT&> _OutIt>
requires(same_as<_CharT, wchar_t> && sizeof(wchar_t) == 4)
_LIBCPP_HIDE_FROM_ABI _OutIt __fill(_OutIt __out_it, size_t __n, __format_spec::__code_point<_CharT> __value) {
return __formatter::__fill(std::move(__out_it), __n, __value.__data[0]);
}
for (size_t __i = 0; __i < __n; ++__i)
__out_it = __formatter::__copy(
std::addressof(__value.__data[0]), std::addressof(__value.__data[0]) + 2, std::move(__out_it));
return __out_it;
} else if constexpr (sizeof(wchar_t) == 4) {
return __formatter::__fill(std::move(__out_it), __n, __value.__data[0]);
} else {
static_assert(false, "expected sizeof(wchar_t) to be 2 or 4");
}
# endif // _LIBCPP_HAS_WIDE_CHARACTERS
# else // _LIBCPP_HAS_UNICODE
template <__fmt_char_type _CharT, output_iterator<const _CharT&> _OutIt>
_LIBCPP_HIDE_FROM_ABI _OutIt __fill(_OutIt __out_it, size_t __n, __format_spec::__code_point<_CharT> __value) {
} else {
static_assert(false, "Unexpected CharT");
}
# else // _LIBCPP_HAS_UNICODE
return __formatter::__fill(std::move(__out_it), __n, __value.__data[0]);
# endif // _LIBCPP_HAS_UNICODE
}
# endif // _LIBCPP_HAS_UNICODE
/// Writes the input to the output with the required padding.
///