From 0aea22f13ebad57e973cfc8a3a04a97361a503bf Mon Sep 17 00:00:00 2001 From: Andrew Haberlandt Date: Tue, 6 Jan 2026 12:47:56 -0800 Subject: [PATCH] [compiler-rt] Support default-True lit config options (follow up to #174522) (#174642) The option added in #174522 breaks simulator tests, since `set_default` overrides `False` values with the default. Since these options are either string or boolean, this patches set_default to override only un-set or empty string values (empty string is not truth-y and therefore would be overwritten by defaults currently, so this is NFCI) --- compiler-rt/test/lit.common.configured.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/compiler-rt/test/lit.common.configured.in b/compiler-rt/test/lit.common.configured.in index ea3bb9b08d05..cad956aedf94 100644 --- a/compiler-rt/test/lit.common.configured.in +++ b/compiler-rt/test/lit.common.configured.in @@ -2,7 +2,7 @@ # Set attribute value if it is unset. def set_default(attr, value): - if not getattr(config, attr, None): + if getattr(config, attr, "") == "": setattr(config, attr, value) # Generic config options for all compiler-rt lit tests.