shylie/llvm-project
1
0
Fork 0
Code Issues Pull Requests Actions 6 Packages Projects Releases Wiki Activity

Reapply "[llvm] Fix assertion error where we didn't check fixed point… (#82412)

Browse Source 
… types." (#82285)

This reverts commit d9f9775ac6289271d57671c55166fa0cad61075b.

The test was missing a `REQUIRES: object-emission`.
This commit is contained in:
PiJoules 2024-02-20 12:09:00 -08:00 committed by GitHub
parent f740366fa6
commit 0b2b91ee9c
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 35 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
llvm/lib/CodeGen/AsmPrinter/DebugHandlerBase.cpp
View File

@ -224,12 +224,15 @@ bool DebugHandlerBase::isUnsignedDIType(const DIType *Ty) {
Encoding == dwarf::DW_ATE_float || Encoding == dwarf::DW_ATE_UTF ||
Encoding == dwarf::DW_ATE_boolean ||
Encoding == dwarf::DW_ATE_complex_float ||
Encoding == dwarf::DW_ATE_signed_fixed ||
Encoding == dwarf::DW_ATE_unsigned_fixed ||
(Ty->getTag() == dwarf::DW_TAG_unspecified_type &&
Ty->getName() == "decltype(nullptr)")) &&
"Unsupported encoding");
return Encoding == dwarf::DW_ATE_unsigned ||
Encoding == dwarf::DW_ATE_unsigned_char ||
Encoding == dwarf::DW_ATE_UTF || Encoding == dwarf::DW_ATE_boolean ||
Encoding == llvm::dwarf::DW_ATE_unsigned_fixed ||
Ty->getTag() == dwarf::DW_TAG_unspecified_type;
}

32
llvm/test/DebugInfo/fixed-point.ll Normal file
View File

@ -0,0 +1,32 @@
;; This fixes https://github.com/llvm/llvm-project/issues/81555
; REQUIRES: object-emission
; RUN: %llc_dwarf %s -filetype=obj -o - | llvm-dwarfdump - | FileCheck %s
; RUN: %llc_dwarf %s -filetype=obj -o - | llvm-dwarfdump - -verify | FileCheck %s --check-prefix=VERIFY
; VERIFY-NOT: error:
; CHECK: {{.*}}: DW_TAG_base_type
; CHECK-NEXT: DW_AT_name ("var")
; CHECK-NEXT: DW_AT_encoding (DW_ATE_signed_fixed)
define void @func() !dbg !26 {
entry:
%classifier = alloca i32, align 4
tail call void @llvm.dbg.value(metadata i32 32768, metadata !37, metadata !DIExpression()), !dbg !39
store i32 32768, ptr %classifier, align 4, !dbg !39
ret void
}
declare void @llvm.dbg.value(metadata, metadata, metadata)
!llvm.dbg.cu = !{!0}
!llvm.module.flags = !{!19}
!0 = distinct !DICompileUnit(language: DW_LANG_C_plus_plus_14, file: !1, emissionKind: FullDebug)
!1 = !DIFile(filename: "a", directory: "")
!6 = !DIBasicType(name: "var", size: 32, encoding: DW_ATE_signed_fixed)
!19 = !{i32 2, !"Debug Info Version", i32 3}
!3 = !DISubroutineType(types: null)
!26 = distinct !DISubprogram(unit: !0, type: !3)
!37 = !DILocalVariable(name: "intercept", arg: 2, scope: !26, file: !1, line: 7, type: !6)
!39 = !DILocation(line: 0, scope: !26)