shylie/llvm-project
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[clang-tidy] Avoid repeated hash lookups (NFC) (#127370)

Browse Source
This commit is contained in:
Kazu Hirata 2025-02-16 08:14:42 -08:00 committed by GitHub
parent 1c87e4739f
commit 0bae0bf8ba
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
clang-tools-extra/clang-tidy/bugprone/VirtualNearMissCheck.cpp
View File

@ -179,15 +179,15 @@ static bool checkOverrideByDerivedMethod(const CXXMethodDecl *BaseMD,
bool VirtualNearMissCheck::isPossibleToBeOverridden(
const CXXMethodDecl *BaseMD) {
auto Iter = PossibleMap.find(BaseMD);
if (Iter != PossibleMap.end())
auto [Iter, Inserted] = PossibleMap.try_emplace(BaseMD);
if (!Inserted)
return Iter->second;
bool IsPossible = !BaseMD->isImplicit() && !isa<CXXConstructorDecl>(BaseMD) &&
!isa<CXXDestructorDecl>(BaseMD) && BaseMD->isVirtual() &&
!BaseMD->isOverloadedOperator() &&
!isa<CXXConversionDecl>(BaseMD);
PossibleMap[BaseMD] = IsPossible;
Iter->second = IsPossible;
return IsPossible;
}