shylie/llvm-project
1
0
Fork 0
Code Issues Pull Requests Actions 6 Packages Projects Releases Wiki Activity

[clang-tidy] Speed up bugprone-suspicious-semicolon (#187558)

Browse Source 
```txt
                   ---User Time---   --System Time--   --User+System--   ---Wall Time---  --- Name ---
Status quo:        0.4743 (100.0%)   0.3802 (100.0%)   0.8546 (100.0%)   0.8567 (100.0%)  bugprone-suspicious-semicolon
With this change:  0.0103 (100.0%)   0.0027 (100.0%)   0.0130 (100.0%)   0.0133 (100.0%)  bugprone-suspicious-semicolon
```
Continuing the trend of registering one `anyOf` matcher being slower
than registering each of its matchers separately (see #178829 for a
previous example).

(This PR also changes the traversal mode, but I only saw a small speedup
from that. Most of it came from registering the matchers separately.)

This check wasn't super expensive to begin with, but the speedup is
still pretty nice.
This commit is contained in:
Victor Chernyakin 2026-03-21 00:29:07 -05:00 committed by GitHub
parent d7fe9c87ce
commit 1087db5b1f
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 12 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
clang-tools-extra/clang-tidy/bugprone/SuspiciousSemicolonCheck.cpp
View File

@ -16,14 +16,16 @@ using namespace clang::ast_matchers;
namespace clang::tidy::bugprone {
void SuspiciousSemicolonCheck::registerMatchers(MatchFinder *Finder) {
Finder->addMatcher(ifStmt(hasThen(nullStmt().bind("semi")),
unless(hasElse(stmt())), unless(isConstexpr()))
.bind("stmt"),
this);
Finder->addMatcher(forStmt(hasBody(nullStmt().bind("semi"))).bind("stmt"),
this);
Finder->addMatcher(
stmt(anyOf(ifStmt(hasThen(nullStmt().bind("semi")),
unless(hasElse(stmt())), unless(isConstexpr())),
forStmt(hasBody(nullStmt().bind("semi"))),
cxxForRangeStmt(hasBody(nullStmt().bind("semi"))),
whileStmt(hasBody(nullStmt().bind("semi")))))
.bind("stmt"),
this);
cxxForRangeStmt(hasBody(nullStmt().bind("semi"))).bind("stmt"), this);
Finder->addMatcher(whileStmt(hasBody(nullStmt().bind("semi"))).bind("stmt"),
this);
}
void SuspiciousSemicolonCheck::check(const MatchFinder::MatchResult &Result) {

3
clang-tools-extra/clang-tidy/bugprone/SuspiciousSemicolonCheck.h
View File

@ -24,6 +24,9 @@ public:
: ClangTidyCheck(Name, Context) {}
void registerMatchers(ast_matchers::MatchFinder *Finder) override;
void check(const ast_matchers::MatchFinder::MatchResult &Result) override;
std::optional<TraversalKind> getCheckTraversalKind() const override {
return TK_IgnoreUnlessSpelledInSource;
}
};
} // namespace clang::tidy::bugprone