[flang] Warn when F128 is unsupported (#102147)

This generates `warning: REAL(KIND=16) is not an enabled type for this
target` if that type is used in a build not correctly configured to
support this type. Uses of `selected_real_kind(30)` return -1.
This commit is contained in:
Tom Eccles 2024-08-28 16:33:39 +01:00 committed by GitHub
parent 89bbcbe285
commit 114ff99e93
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
14 changed files with 112 additions and 4 deletions

View File

@ -11,6 +11,7 @@
#include "flang/Evaluate/target.h" #include "flang/Evaluate/target.h"
#include "llvm/Target/TargetMachine.h" #include "llvm/Target/TargetMachine.h"
#include <cfloat>
namespace Fortran::tools { namespace Fortran::tools {
@ -21,9 +22,25 @@ namespace Fortran::tools {
const llvm::Triple &targetTriple{targetMachine.getTargetTriple()}; const llvm::Triple &targetTriple{targetMachine.getTargetTriple()};
// FIXME: Handle real(3) ? // FIXME: Handle real(3) ?
if (targetTriple.getArch() != llvm::Triple::ArchType::x86_64) if (targetTriple.getArch() != llvm::Triple::ArchType::x86_64) {
targetCharacteristics.DisableType( targetCharacteristics.DisableType(
Fortran::common::TypeCategory::Real, /*kind=*/10); Fortran::common::TypeCategory::Real, /*kind=*/10);
}
// Figure out if we can support F128: see
// flang/runtime/Float128Math/math-entries.h
#ifdef FLANG_RUNTIME_F128_MATH_LIB
// we can use libquadmath wrappers
constexpr bool f128Support = true;
#elif LDBL_MANT_DIG == 113
// we can use libm wrappers
constexpr bool f128Support = true;
#else
constexpr bool f128Support = false;
#endif
if constexpr (!f128Support)
targetCharacteristics.DisableType(Fortran::common::TypeCategory::Real, 16);
targetCharacteristics.set_compilerOptionsString(compilerOptions) targetCharacteristics.set_compilerOptionsString(compilerOptions)
.set_compilerVersionString(compilerVersion); .set_compilerVersionString(compilerVersion);

View File

@ -161,6 +161,8 @@ module ieee_arithmetic
G(1) G(2) G(4) G(8) G(16) G(1) G(2) G(4) G(8) G(16)
#define SPECIFICS_L(G) \ #define SPECIFICS_L(G) \
G(1) G(2) G(4) G(8) G(1) G(2) G(4) G(8)
#if FLANG_SUPPORT_R16
#if __x86_64__ #if __x86_64__
#define SPECIFICS_R(G) \ #define SPECIFICS_R(G) \
G(2) G(3) G(4) G(8) G(10) G(16) G(2) G(3) G(4) G(8) G(10) G(16)
@ -168,12 +170,24 @@ module ieee_arithmetic
#define SPECIFICS_R(G) \ #define SPECIFICS_R(G) \
G(2) G(3) G(4) G(8) G(16) G(2) G(3) G(4) G(8) G(16)
#endif #endif
#else
#if __x86_64__
#define SPECIFICS_R(G) \
G(2) G(3) G(4) G(8) G(10)
#else
#define SPECIFICS_R(G) \
G(2) G(3) G(4) G(8)
#endif
#endif
#define SPECIFICS_II(G) \ #define SPECIFICS_II(G) \
G(1,1) G(1,2) G(1,4) G(1,8) G(1,16) \ G(1,1) G(1,2) G(1,4) G(1,8) G(1,16) \
G(2,1) G(2,2) G(2,4) G(2,8) G(2,16) \ G(2,1) G(2,2) G(2,4) G(2,8) G(2,16) \
G(4,1) G(4,2) G(4,4) G(4,8) G(4,16) \ G(4,1) G(4,2) G(4,4) G(4,8) G(4,16) \
G(8,1) G(8,2) G(8,4) G(8,8) G(8,16) \ G(8,1) G(8,2) G(8,4) G(8,8) G(8,16) \
G(16,1) G(16,2) G(16,4) G(16,8) G(16,16) G(16,1) G(16,2) G(16,4) G(16,8) G(16,16)
#if FLANG_SUPPORT_R16
#if __x86_64__ #if __x86_64__
#define SPECIFICS_RI(G) \ #define SPECIFICS_RI(G) \
G(2,1) G(2,2) G(2,4) G(2,8) G(2,16) \ G(2,1) G(2,2) G(2,4) G(2,8) G(2,16) \
@ -190,7 +204,24 @@ module ieee_arithmetic
G(8,1) G(8,2) G(8,4) G(8,8) G(8,16) \ G(8,1) G(8,2) G(8,4) G(8,8) G(8,16) \
G(16,1) G(16,2) G(16,4) G(16,8) G(16,16) G(16,1) G(16,2) G(16,4) G(16,8) G(16,16)
#endif #endif
#else
#if __x86_64__
#define SPECIFICS_RI(G) \
G(2,1) G(2,2) G(2,4) G(2,8) \
G(3,1) G(3,2) G(3,4) G(3,8) \
G(4,1) G(4,2) G(4,4) G(4,8) \
G(8,1) G(8,2) G(8,4) G(8,8) \
G(10,1) G(10,2) G(10,4) G(10,8)
#else
#define SPECIFICS_RI(G) \
G(2,1) G(2,2) G(2,4) G(2,8) \
G(3,1) G(3,2) G(3,4) G(3,8) \
G(4,1) G(4,2) G(4,4) G(4,8) \
G(8,1) G(8,2) G(8,4) G(8,8)
#endif
#endif
#if FLANG_SUPPORT_R16
#if __x86_64__ #if __x86_64__
#define SPECIFICS_RR(G) \ #define SPECIFICS_RR(G) \
G(2,2) G(2,3) G(2,4) G(2,8) G(2,10) G(2,16) \ G(2,2) G(2,3) G(2,4) G(2,8) G(2,10) G(2,16) \
@ -207,6 +238,22 @@ module ieee_arithmetic
G(8,2) G(8,3) G(8,4) G(8,8) G(8,16) \ G(8,2) G(8,3) G(8,4) G(8,8) G(8,16) \
G(16,2) G(16,3) G(16,4) G(16,8) G(16,16) G(16,2) G(16,3) G(16,4) G(16,8) G(16,16)
#endif #endif
#else
#if __x86_64__
#define SPECIFICS_RR(G) \
G(2,2) G(2,3) G(2,4) G(2,8) G(2,10) \
G(3,2) G(3,3) G(3,4) G(3,8) G(3,10) \
G(4,2) G(4,3) G(4,4) G(4,8) G(4,10) \
G(8,2) G(8,3) G(8,4) G(8,8) G(8,10) \
G(10,2) G(10,3) G(10,4) G(10,8) G(10,10)
#else
#define SPECIFICS_RR(G) \
G(2,2) G(2,3) G(2,4) G(2,8) \
G(3,2) G(3,3) G(3,4) G(3,8) \
G(4,2) G(4,3) G(4,4) G(4,8) \
G(8,2) G(8,3) G(8,4) G(8,8)
#endif
#endif
#define IEEE_CLASS_R(XKIND) \ #define IEEE_CLASS_R(XKIND) \
elemental type(ieee_class_type) function ieee_class_a##XKIND(x); \ elemental type(ieee_class_type) function ieee_class_a##XKIND(x); \
@ -462,8 +509,10 @@ module ieee_arithmetic
interface ieee_real interface ieee_real
SPECIFICS_I(IEEE_REAL_I) SPECIFICS_I(IEEE_REAL_I)
SPECIFICS_R(IEEE_REAL_R) SPECIFICS_R(IEEE_REAL_R)
#if FLANG_SUPPORT_R16
SPECIFICS_II(IEEE_REAL_II) SPECIFICS_II(IEEE_REAL_II)
SPECIFICS_RI(IEEE_REAL_RI) SPECIFICS_RI(IEEE_REAL_RI)
#endif
end interface ieee_real end interface ieee_real
public :: ieee_real public :: ieee_real
#undef IEEE_REAL_I #undef IEEE_REAL_I

View File

@ -11,6 +11,16 @@ llvm_canonicalize_cmake_booleans(
set(FLANG_TOOLS_DIR ${FLANG_BINARY_DIR}/bin) set(FLANG_TOOLS_DIR ${FLANG_BINARY_DIR}/bin)
# Check if 128-bit float computations can be done via long double
check_cxx_source_compiles(
"#include <cfloat>
#if LDBL_MANT_DIG != 113
#error LDBL_MANT_DIG != 113
#endif
int main() { return 0; }
"
HAVE_LDBL_MANT_DIG_113)
# FIXME In out-of-tree builds, "SHLIBDIR" is undefined and passing it to # FIXME In out-of-tree builds, "SHLIBDIR" is undefined and passing it to
# `configure_lit_site_cfg` leads to a configuration error. This is currently # `configure_lit_site_cfg` leads to a configuration error. This is currently
# only required by plugins/examples, which are not supported in out-of-tree # only required by plugins/examples, which are not supported in out-of-tree

View File

@ -1,6 +1,7 @@
! RUN: %python %S/test_folding.py %s %flang_fc1 -pedantic -triple x86_64-unknown-linux-gnu ! RUN: %python %S/test_folding.py %s %flang_fc1 -pedantic -triple x86_64-unknown-linux-gnu
! UNSUPPORTED: system-windows ! UNSUPPORTED: system-windows
! REQUIRES: target=x86_64{{.*}} ! REQUIRES: target=x86_64{{.*}}
! REQUIRES: flang-supports-f128-math
! Tests folding of OUT_OF_RANGE(). ! Tests folding of OUT_OF_RANGE().
module m module m
integer(1), parameter :: i1v(*) = [ -huge(1_1) - 1_1, huge(1_1) ] integer(1), parameter :: i1v(*) = [ -huge(1_1) - 1_1, huge(1_1) ]

View File

@ -1,3 +1,4 @@
! REQUIRES: flang-supports-f128-math
! RUN: %python %S/test_folding.py %s %flang_fc1 ! RUN: %python %S/test_folding.py %s %flang_fc1
! Test numeric model inquiry intrinsics ! Test numeric model inquiry intrinsics

View File

@ -1,3 +1,4 @@
! REQUIRES: flang-supports-f128-math
! RUN: bbc -emit-fir -o - %s | FileCheck %s ! RUN: bbc -emit-fir -o - %s | FileCheck %s
! CHECK-LABEL: func @_QQmain ! CHECK-LABEL: func @_QQmain

View File

@ -1,3 +1,4 @@
! REQUIRES: flang-supports-f128-math
! RUN: bbc -emit-fir -hlfir=false -o - %s | FileCheck %s ! RUN: bbc -emit-fir -hlfir=false -o - %s | FileCheck %s
! CHECK-LABEL: func @_QQmain ! CHECK-LABEL: func @_QQmain

View File

@ -1,3 +1,4 @@
! REQUIRES: flang-supports-f128-math
! RUN: bbc %s -o - | tco | FileCheck %s ! RUN: bbc %s -o - | tco | FileCheck %s
! RUN: %flang -emit-llvm -S -mmlir -disable-external-name-interop %s -o - | FileCheck %s ! RUN: %flang -emit-llvm -S -mmlir -disable-external-name-interop %s -o - | FileCheck %s
@ -78,4 +79,3 @@ subroutine s7()
real(16) r16 real(16) r16
common /co1/ r16 common /co1/ r16
end subroutine end subroutine

View File

@ -1,3 +1,4 @@
! REQUIRES: flang-supports-f128-math
! RUN: %python %S/test_symbols.py %s %flang_fc1 ! RUN: %python %S/test_symbols.py %s %flang_fc1
!DEF: /MainProgram1/ipdt DerivedType !DEF: /MainProgram1/ipdt DerivedType
!DEF: /MainProgram1/ipdt/k TypeParam INTEGER(4) !DEF: /MainProgram1/ipdt/k TypeParam INTEGER(4)

View File

@ -1,3 +1,4 @@
! REQUIRES: flang-supports-f128-math
! RUN: %python %S/test_modfile.py %s %flang_fc1 ! RUN: %python %S/test_modfile.py %s %flang_fc1
! Intrinsics SELECTED_INT_KIND, SELECTED_REAL_KIND, PRECISION, RANGE, ! Intrinsics SELECTED_INT_KIND, SELECTED_REAL_KIND, PRECISION, RANGE,
! RADIX, DIGITS ! RADIX, DIGITS

View File

@ -1,4 +1,5 @@
! REQUIRES: aarch64-registered-target ! REQUIRES: aarch64-registered-target
! REQUIRES: flang-supports-f128-math
! RUN: %python %S/test_modfile.py %s %flang_fc1 -triple aarch64-unknown-linux-gnu ! RUN: %python %S/test_modfile.py %s %flang_fc1 -triple aarch64-unknown-linux-gnu
module m1 module m1

View File

@ -216,8 +216,9 @@ if config.have_openmp_rtl:
# Add features and substitutions to test F128 math support. # Add features and substitutions to test F128 math support.
# %f128-lib substitution may be used to generate check prefixes # %f128-lib substitution may be used to generate check prefixes
# for LIT tests checking for F128 library support. # for LIT tests checking for F128 library support.
if config.flang_runtime_f128_math_lib: if config.flang_runtime_f128_math_lib or config.have_ldbl_mant_dig_113:
config.available_features.add("flang-supports-f128-math") config.available_features.add("flang-supports-f128-math")
if config.flang_runtime_f128_math_lib:
config.available_features.add( config.available_features.add(
"flang-f128-math-lib-" + config.flang_runtime_f128_math_lib "flang-f128-math-lib-" + config.flang_runtime_f128_math_lib
) )

View File

@ -31,6 +31,7 @@ if "openmp" in "@LLVM_ENABLE_RUNTIMES@".lower().split(";"):
else: else:
config.openmp_module_dir = None config.openmp_module_dir = None
config.flang_runtime_f128_math_lib = "@FLANG_RUNTIME_F128_MATH_LIB@" config.flang_runtime_f128_math_lib = "@FLANG_RUNTIME_F128_MATH_LIB@"
config.have_ldbl_mant_dig_113 = "@HAVE_LDBL_MANT_DIG_113@"
import lit.llvm import lit.llvm
lit.llvm.initialize(lit_config, config) lit.llvm.initialize(lit_config, config)

View File

@ -31,6 +31,25 @@ set(MODULES_WITHOUT_IMPLEMENTATION
set(MODULES ${MODULES_WITH_IMPLEMENTATION} ${MODULES_WITHOUT_IMPLEMENTATION}) set(MODULES ${MODULES_WITH_IMPLEMENTATION} ${MODULES_WITHOUT_IMPLEMENTATION})
# Check if 128-bit float computations can be done via long double.
check_cxx_source_compiles(
"#include <cfloat>
#if LDBL_MANT_DIG != 113
#error LDBL_MANT_DIG != 113
#endif
int main() { return 0; }
"
HAVE_LDBL_MANT_DIG_113)
# Figure out whether we can support REAL(KIND=16)
if (FLANG_RUNTIME_F128_MATH_LIB)
set(FLANG_SUPPORT_R16 "1")
elseif (HAVE_LDBL_MANT_DIG_113)
set(FLANG_SUPPORT_R16 "1")
else()
set(FLANG_SUPPORT_R16 "0")
endif()
# Init variable to hold extra object files coming from the Fortran modules; # Init variable to hold extra object files coming from the Fortran modules;
# these module files will be contributed from the CMakeLists in flang/tools/f18. # these module files will be contributed from the CMakeLists in flang/tools/f18.
set(module_objects "") set(module_objects "")
@ -76,6 +95,10 @@ if (NOT CMAKE_CROSSCOMPILING)
endif() endif()
endif() endif()
set(decls "")
if (FLANG_SUPPORT_R16)
set(decls "-DFLANG_SUPPORT_R16")
endif()
# Some modules have an implementation part that needs to be added to the # Some modules have an implementation part that needs to be added to the
# FortranRuntime library. # FortranRuntime library.
@ -92,7 +115,7 @@ if (NOT CMAKE_CROSSCOMPILING)
# TODO: We may need to flag this with conditional, in case Flang is built w/o OpenMP support # TODO: We may need to flag this with conditional, in case Flang is built w/o OpenMP support
add_custom_command(OUTPUT ${base}.mod ${object_output} add_custom_command(OUTPUT ${base}.mod ${object_output}
COMMAND ${CMAKE_COMMAND} -E make_directory ${FLANG_INTRINSIC_MODULES_DIR} COMMAND ${CMAKE_COMMAND} -E make_directory ${FLANG_INTRINSIC_MODULES_DIR}
COMMAND flang-new ${opts} -cpp ${compile_with} -module-dir ${FLANG_INTRINSIC_MODULES_DIR} COMMAND flang-new ${opts} ${decls} -cpp ${compile_with} -module-dir ${FLANG_INTRINSIC_MODULES_DIR}
${FLANG_SOURCE_DIR}/module/${filename}.f90 ${FLANG_SOURCE_DIR}/module/${filename}.f90
DEPENDS flang-new ${FLANG_SOURCE_DIR}/module/${filename}.f90 ${FLANG_SOURCE_DIR}/module/__fortran_builtins.f90 ${depends} DEPENDS flang-new ${FLANG_SOURCE_DIR}/module/${filename}.f90 ${FLANG_SOURCE_DIR}/module/__fortran_builtins.f90 ${depends}
) )