From 180625fcb478877bfada337705ec4e2e1ecb8d7e Mon Sep 17 00:00:00 2001 From: Philip Reames Date: Thu, 18 Nov 2021 09:05:28 -0800 Subject: [PATCH] Add a breadcrumb comment to make debugging a user error when using ./utils/update_analyze_test_checks.py easier. We won't talk about how long it took me to figure this out. The difference in batch vs interactive on the "did you mean to print bitcode" message made this confusing. --- llvm/utils/UpdateTestChecks/common.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/llvm/utils/UpdateTestChecks/common.py b/llvm/utils/UpdateTestChecks/common.py index 5cb5eb473e28..cf8c8881c851 100644 --- a/llvm/utils/UpdateTestChecks/common.py +++ b/llvm/utils/UpdateTestChecks/common.py @@ -182,6 +182,9 @@ def invoke_tool(exe, cmd_args, ir, preprocess_cmd=None, verbose=False): stdout = subprocess.check_output(exe + ' ' + applySubstitutions(cmd_args, substitutions), shell=True, stdin=ir_file) if sys.version_info[0] > 2: + # FYI, if you crashed here with a decode error, your run line probably + # results in bitcode or other binary format being written to the pipe. + # For an opt test, you probably want to add -S or -disable-output. stdout = stdout.decode() # Fix line endings to unix CR style. return stdout.replace('\r\n', '\n')