shylie/llvm-project
1
0
Fork 0
Code Issues Pull Requests Actions 6 Packages Projects Releases Wiki Activity

[runtimes] Skip custom linker validation for gpu/offload targets (#189933)

Browse Source 
This fixes `Host compiler does not support '-fuse-ld=lld'` error when
cross-build libclc for gpu target. Cmake configure command is:
-DRUNTIMES_amdgcn-amd-amdhsa-llvm_LLVM_ENABLE_RUNTIMES=libclc \
-DLLVM_RUNTIME_TARGETS="amdgcn-amd-amdhsa-llvm"
libclc targets only support offload target cross-build and can't link
host executable. The configuration error is false positive for offload.

This PR adds a baseline test to first check if the target can link
executable. If it fails (typical for gpu/offload), we skip the custom
linker validation.
This commit is contained in:
Wenju He 2026-04-06 07:18:36 +08:00 committed by GitHub
parent 58208a0cc1
commit 1839b755dd
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 12 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
llvm/cmake/modules/HandleLLVMOptions.cmake
View File

@ -429,14 +429,20 @@ if( LLVM_ENABLE_LLD )
endif()
if( LLVM_USE_LINKER )
check_cxx_source_compiles("int main() { return 0; }" _CAN_LINK_EXECUTABLE)
mark_as_advanced(_CAN_LINK_EXECUTABLE)
append("-fuse-ld=${LLVM_USE_LINKER}"
CMAKE_EXE_LINKER_FLAGS CMAKE_MODULE_LINKER_FLAGS CMAKE_SHARED_LINKER_FLAGS)
check_cxx_source_compiles("int main() { return 0; }" CXX_SUPPORTS_CUSTOM_LINKER)
if ( NOT CXX_SUPPORTS_CUSTOM_LINKER )
message(FATAL_ERROR "Host compiler does not support '-fuse-ld=${LLVM_USE_LINKER}'. "
"Please make sure that '${LLVM_USE_LINKER}' is installed and "
"that your host compiler can compile a simple program when "
"given the option '-fuse-ld=${LLVM_USE_LINKER}'.")
if(_CAN_LINK_EXECUTABLE)
check_cxx_source_compiles("int main() { return 0; }" CXX_SUPPORTS_CUSTOM_LINKER)
if ( NOT CXX_SUPPORTS_CUSTOM_LINKER )
message(FATAL_ERROR "Host compiler does not support '-fuse-ld=${LLVM_USE_LINKER}'. "
"Please make sure that '${LLVM_USE_LINKER}' is installed and "
"that your host compiler can compile a simple program when "
"given the option '-fuse-ld=${LLVM_USE_LINKER}'.")
endif()
else()
message(STATUS "Skipping custom linker check: offload target cannot link executable")
endif()
endif()