shylie/llvm-project
1
0
Fork 0
Code Issues Pull Requests Actions 6 Packages Projects Releases Wiki Activity

[CAS] OnDiskGraphDB - fix MSVC "not all control paths return a value" warnings. NFC. (#164369)

Browse Source
This commit is contained in:
Simon Pilgrim 2025-10-21 09:02:13 +01:00 committed by GitHub
parent 34c6fa3071
commit 1bf7ed27c1
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
llvm/include/llvm/CAS/OnDiskGraphDB.h
View File

@ -380,6 +380,7 @@ private:
case ObjectPresence::OnlyInUpstreamDB:
return true;
}
llvm_unreachable("Unknown ObjectPresence enum");
}
/// When \p load is called for a node that doesn't exist, this function tries

3
llvm/lib/CAS/OnDiskGraphDB.cpp
View File

@ -836,6 +836,7 @@ uint64_t DataRecordHandle::getDataSize() const {
case DataSizeFlags::Uses8B:
return support::endian::read64le(DataSizePtr);
}
llvm_unreachable("Unknown DataSizeFlags enum");
}
void DataRecordHandle::skipDataSize(LayoutFlags LF, int64_t &RelOffset) const {
@ -863,6 +864,7 @@ uint32_t DataRecordHandle::getNumRefs() const {
case NumRefsFlags::Uses8B:
return support::endian::read64le(NumRefsPtr);
}
llvm_unreachable("Unknown NumRefsFlags enum");
}
void DataRecordHandle::skipNumRefs(LayoutFlags LF, int64_t &RelOffset) const {
@ -1270,6 +1272,7 @@ Expected<bool> OnDiskGraphDB::isMaterialized(ObjectID Ref) {
return FaultInResult.takeError();
return true;
}
llvm_unreachable("Unknown ObjectPresence enum");
}
Expected<OnDiskGraphDB::ObjectPresence>