shylie/llvm-project
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[DirectX] Make firstbithigh intrinsic use first arg as overload type (#145401)

Browse Source 
Sibling to https://github.com/llvm/llvm-project/pull/145350 part of
https://github.com/llvm/llvm-project/issues/144966

firstbituhigh and firstbitshigh should use the first arg for overloads
instead of the return type since the return is always i32
This commit is contained in:
Ashley Coleman 2025-06-24 11:00:21 -07:00 committed by GitHub
parent 52b27c2bd6
commit 21423c7fdc
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 72 additions and 40 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
llvm/lib/Target/DirectX/DirectXTargetTransformInfo.cpp
View File

@ -31,6 +31,8 @@ bool DirectXTTIImpl::isTargetIntrinsicWithOverloadTypeAtArg(Intrinsic::ID ID,
case Intrinsic::dx_asdouble: case Intrinsic::dx_asdouble:
case Intrinsic::dx_isinf: case Intrinsic::dx_isinf:
case Intrinsic::dx_firstbitlow: case Intrinsic::dx_firstbitlow:
case Intrinsic::dx_firstbituhigh:
case Intrinsic::dx_firstbitshigh:
return OpdIdx == 0; return OpdIdx == 0;
default: default:
return OpdIdx == -1; return OpdIdx == -1;

92
llvm/test/CodeGen/DirectX/firstbithigh.ll
View File

@ -4,42 +4,42 @@
define noundef i32 @test_firstbithigh_ushort(i16 noundef %a) { define noundef i32 @test_firstbithigh_ushort(i16 noundef %a) {
entry: entry:
; CHECK: call i32 @dx.op.unaryBits.i16(i32 33, i16 %{{.*}}) #[[#ATTR:]] ; CHECK: call i32 @dx.op.unaryBits.i16(i32 33, i16 %{{.*}})
%elt.firstbithigh = call i32 @llvm.dx.firstbituhigh.i16(i16 %a) %elt.firstbithigh = call i32 @llvm.dx.firstbituhigh.i16(i16 %a)
ret i32 %elt.firstbithigh ret i32 %elt.firstbithigh
} }
define noundef i32 @test_firstbithigh_short(i16 noundef %a) { define noundef i32 @test_firstbithigh_short(i16 noundef %a) {
entry: entry:
; CHECK: call i32 @dx.op.unaryBits.i16(i32 34, i16 %{{.*}}) #[[#ATTR]] ; CHECK: call i32 @dx.op.unaryBits.i16(i32 34, i16 %{{.*}})
%elt.firstbithigh = call i32 @llvm.dx.firstbitshigh.i16(i16 %a) %elt.firstbithigh = call i32 @llvm.dx.firstbitshigh.i16(i16 %a)
ret i32 %elt.firstbithigh ret i32 %elt.firstbithigh
} }
define noundef i32 @test_firstbithigh_uint(i32 noundef %a) { define noundef i32 @test_firstbithigh_uint(i32 noundef %a) {
entry: entry:
; CHECK: call i32 @dx.op.unaryBits.i32(i32 33, i32 %{{.*}}) #[[#ATTR]] ; CHECK: call i32 @dx.op.unaryBits.i32(i32 33, i32 %{{.*}})
%elt.firstbithigh = call i32 @llvm.dx.firstbituhigh.i32(i32 %a) %elt.firstbithigh = call i32 @llvm.dx.firstbituhigh.i32(i32 %a)
ret i32 %elt.firstbithigh ret i32 %elt.firstbithigh
} }
define noundef i32 @test_firstbithigh_int(i32 noundef %a) { define noundef i32 @test_firstbithigh_int(i32 noundef %a) {
entry: entry:
; CHECK: call i32 @dx.op.unaryBits.i32(i32 34, i32 %{{.*}}) #[[#ATTR]] ; CHECK: call i32 @dx.op.unaryBits.i32(i32 34, i32 %{{.*}})
%elt.firstbithigh = call i32 @llvm.dx.firstbitshigh.i32(i32 %a) %elt.firstbithigh = call i32 @llvm.dx.firstbitshigh.i32(i32 %a)
ret i32 %elt.firstbithigh ret i32 %elt.firstbithigh
} }
define noundef i32 @test_firstbithigh_ulong(i64 noundef %a) { define noundef i32 @test_firstbithigh_ulong(i64 noundef %a) {
entry: entry:
; CHECK: call i32 @dx.op.unaryBits.i64(i32 33, i64 %{{.*}}) #[[#ATTR]] ; CHECK: call i32 @dx.op.unaryBits.i64(i32 33, i64 %{{.*}})
%elt.firstbithigh = call i32 @llvm.dx.firstbituhigh.i64(i64 %a) %elt.firstbithigh = call i32 @llvm.dx.firstbituhigh.i64(i64 %a)
ret i32 %elt.firstbithigh ret i32 %elt.firstbithigh
} }
define noundef i32 @test_firstbithigh_long(i64 noundef %a) { define noundef i32 @test_firstbithigh_long(i64 noundef %a) {
entry: entry:
; CHECK: call i32 @dx.op.unaryBits.i64(i32 34, i64 %{{.*}}) #[[#ATTR]] ; CHECK: call i32 @dx.op.unaryBits.i64(i32 34, i64 %{{.*}})
%elt.firstbithigh = call i32 @llvm.dx.firstbitshigh.i64(i64 %a) %elt.firstbithigh = call i32 @llvm.dx.firstbitshigh.i64(i64 %a)
ret i32 %elt.firstbithigh ret i32 %elt.firstbithigh
} }
@ -47,17 +47,18 @@ entry:
define noundef <4 x i32> @test_firstbituhigh_vec4_i32(<4 x i32> noundef %a) { define noundef <4 x i32> @test_firstbituhigh_vec4_i32(<4 x i32> noundef %a) {
entry: entry:
; CHECK: [[ee0:%.*]] = extractelement <4 x i32> %a, i64 0 ; CHECK: [[ee0:%.*]] = extractelement <4 x i32> %a, i64 0
; CHECK: [[ie0:%.*]] = call i32 @dx.op.unaryBits.i32(i32 33, i32 [[ee0]]) #[[#ATTR]] ; CHECK: [[ie0:%.*]] = call i32 @dx.op.unaryBits.i32(i32 33, i32 [[ee0]])
; CHECK: [[ee1:%.*]] = extractelement <4 x i32> %a, i64 1 ; CHECK: [[ee1:%.*]] = extractelement <4 x i32> %a, i64 1
; CHECK: [[ie1:%.*]] = call i32 @dx.op.unaryBits.i32(i32 33, i32 [[ee1]]) #[[#ATTR]] ; CHECK: [[ie1:%.*]] = call i32 @dx.op.unaryBits.i32(i32 33, i32 [[ee1]])
; CHECK: [[ee2:%.*]] = extractelement <4 x i32> %a, i64 2 ; CHECK: [[ee2:%.*]] = extractelement <4 x i32> %a, i64 2
; CHECK: [[ie2:%.*]] = call i32 @dx.op.unaryBits.i32(i32 33, i32 [[ee2]]) #[[#ATTR]] ; CHECK: [[ie2:%.*]] = call i32 @dx.op.unaryBits.i32(i32 33, i32 [[ee2]])
; CHECK: [[ee3:%.*]] = extractelement <4 x i32> %a, i64 3 ; CHECK: [[ee3:%.*]] = extractelement <4 x i32> %a, i64 3
; CHECK: [[ie3:%.*]] = call i32 @dx.op.unaryBits.i32(i32 33, i32 [[ee3]]) #[[#ATTR]] ; CHECK: [[ie3:%.*]] = call i32 @dx.op.unaryBits.i32(i32 33, i32 [[ee3]])
; CHECK: insertelement <4 x i32> poison, i32 [[ie0]], i64 0 ; CHECK: [[rt0:%.*]] = insertelement <4 x i32> poison, i32 [[ie0]], i64 0
; CHECK: insertelement <4 x i32> %{{.*}}, i32 [[ie1]], i64 1 ; CHECK: [[rt1:%.*]] = insertelement <4 x i32> [[rt0]], i32 [[ie1]], i64 1
; CHECK: insertelement <4 x i32> %{{.*}}, i32 [[ie2]], i64 2 ; CHECK: [[rt2:%.*]] = insertelement <4 x i32> [[rt1]], i32 [[ie2]], i64 2
; CHECK: insertelement <4 x i32> %{{.*}}, i32 [[ie3]], i64 3 ; CHECK: [[rt3:%.*]] = insertelement <4 x i32> [[rt2]], i32 [[ie3]], i64 3
; CHECK: ret <4 x i32> [[rt3]]
%2 = call <4 x i32> @llvm.dx.firstbituhigh.v4i32(<4 x i32> %a) %2 = call <4 x i32> @llvm.dx.firstbituhigh.v4i32(<4 x i32> %a)
ret <4 x i32> %2 ret <4 x i32> %2
} }
@ -65,29 +66,56 @@ entry:
define noundef <4 x i32> @test_firstbitshigh_vec4_i32(<4 x i32> noundef %a) { define noundef <4 x i32> @test_firstbitshigh_vec4_i32(<4 x i32> noundef %a) {
entry: entry:
; CHECK: [[ee0:%.*]] = extractelement <4 x i32> %a, i64 0 ; CHECK: [[ee0:%.*]] = extractelement <4 x i32> %a, i64 0
; CHECK: [[ie0:%.*]] = call i32 @dx.op.unaryBits.i32(i32 34, i32 [[ee0]]) #[[#ATTR]] ; CHECK: [[ie0:%.*]] = call i32 @dx.op.unaryBits.i32(i32 34, i32 [[ee0]])
; CHECK: [[ee1:%.*]] = extractelement <4 x i32> %a, i64 1 ; CHECK: [[ee1:%.*]] = extractelement <4 x i32> %a, i64 1
; CHECK: [[ie1:%.*]] = call i32 @dx.op.unaryBits.i32(i32 34, i32 [[ee1]]) #[[#ATTR]] ; CHECK: [[ie1:%.*]] = call i32 @dx.op.unaryBits.i32(i32 34, i32 [[ee1]])
; CHECK: [[ee2:%.*]] = extractelement <4 x i32> %a, i64 2 ; CHECK: [[ee2:%.*]] = extractelement <4 x i32> %a, i64 2
; CHECK: [[ie2:%.*]] = call i32 @dx.op.unaryBits.i32(i32 34, i32 [[ee2]]) #[[#ATTR]] ; CHECK: [[ie2:%.*]] = call i32 @dx.op.unaryBits.i32(i32 34, i32 [[ee2]])
; CHECK: [[ee3:%.*]] = extractelement <4 x i32> %a, i64 3 ; CHECK: [[ee3:%.*]] = extractelement <4 x i32> %a, i64 3
; CHECK: [[ie3:%.*]] = call i32 @dx.op.unaryBits.i32(i32 34, i32 [[ee3]]) #[[#ATTR]] ; CHECK: [[ie3:%.*]] = call i32 @dx.op.unaryBits.i32(i32 34, i32 [[ee3]])
; CHECK: insertelement <4 x i32> poison, i32 [[ie0]], i64 0 ; CHECK: [[rt0:%.*]] = insertelement <4 x i32> poison, i32 [[ie0]], i64 0
; CHECK: insertelement <4 x i32> %{{.*}}, i32 [[ie1]], i64 1 ; CHECK: [[rt1:%.*]] = insertelement <4 x i32> [[rt0]], i32 [[ie1]], i64 1
; CHECK: insertelement <4 x i32> %{{.*}}, i32 [[ie2]], i64 2 ; CHECK: [[rt2:%.*]] = insertelement <4 x i32> [[rt1]], i32 [[ie2]], i64 2
; CHECK: insertelement <4 x i32> %{{.*}}, i32 [[ie3]], i64 3 ; CHECK: [[rt3:%.*]] = insertelement <4 x i32> [[rt2]], i32 [[ie3]], i64 3
; CHECK: ret <4 x i32> [[rt3]]
%2 = call <4 x i32> @llvm.dx.firstbitshigh.v4i32(<4 x i32> %a) %2 = call <4 x i32> @llvm.dx.firstbitshigh.v4i32(<4 x i32> %a)
ret <4 x i32> %2 ret <4 x i32> %2
} }
; CHECK: attributes #[[#ATTR]] = {{{.*}} memory(none) {{.*}}} define noundef <4 x i32> @test_firstbituhigh_vec4_i16(<4 x i16> noundef %a) {
entry:
; CHECK: [[ee0:%.*]] = extractelement <4 x i16> %a, i64 0
; CHECK: [[ie0:%.*]] = call i32 @dx.op.unaryBits.i16(i32 33, i16 [[ee0]])
; CHECK: [[ee1:%.*]] = extractelement <4 x i16> %a, i64 1
; CHECK: [[ie1:%.*]] = call i32 @dx.op.unaryBits.i16(i32 33, i16 [[ee1]])
; CHECK: [[ee2:%.*]] = extractelement <4 x i16> %a, i64 2
; CHECK: [[ie2:%.*]] = call i32 @dx.op.unaryBits.i16(i32 33, i16 [[ee2]])
; CHECK: [[ee3:%.*]] = extractelement <4 x i16> %a, i64 3
; CHECK: [[ie3:%.*]] = call i32 @dx.op.unaryBits.i16(i32 33, i16 [[ee3]])
; CHECK: [[rt0:%.*]] = insertelement <4 x i32> poison, i32 [[ie0]], i64 0
; CHECK: [[rt1:%.*]] = insertelement <4 x i32> [[rt0]], i32 [[ie1]], i64 1
; CHECK: [[rt2:%.*]] = insertelement <4 x i32> [[rt1]], i32 [[ie2]], i64 2
; CHECK: [[rt3:%.*]] = insertelement <4 x i32> [[rt2]], i32 [[ie3]], i64 3
; CHECK: ret <4 x i32> [[rt3]]
%2 = call <4 x i32> @llvm.dx.firstbituhigh.v4i16(<4 x i16> %a)
ret <4 x i32> %2
}
declare i32 @llvm.dx.firstbituhigh.i16(i16) define noundef <4 x i32> @test_firstbitshigh_vec4_i16(<4 x i16> noundef %a) {
declare i32 @llvm.dx.firstbituhigh.i32(i32) entry:
declare i32 @llvm.dx.firstbituhigh.i64(i64) ; CHECK: [[ee0:%.*]] = extractelement <4 x i16> %a, i64 0
declare <4 x i32> @llvm.dx.firstbituhigh.v4i32(<4 x i32>) ; CHECK: [[ie0:%.*]] = call i32 @dx.op.unaryBits.i16(i32 34, i16 [[ee0]])
; CHECK: [[ee1:%.*]] = extractelement <4 x i16> %a, i64 1
declare i32 @llvm.dx.firstbitshigh.i16(i16) ; CHECK: [[ie1:%.*]] = call i32 @dx.op.unaryBits.i16(i32 34, i16 [[ee1]])
declare i32 @llvm.dx.firstbitshigh.i32(i32) ; CHECK: [[ee2:%.*]] = extractelement <4 x i16> %a, i64 2
declare i32 @llvm.dx.firstbitshigh.i64(i64) ; CHECK: [[ie2:%.*]] = call i32 @dx.op.unaryBits.i16(i32 34, i16 [[ee2]])
declare <4 x i32> @llvm.dx.firstbitshigh.v4i32(<4 x i32>) ; CHECK: [[ee3:%.*]] = extractelement <4 x i16> %a, i64 3
; CHECK: [[ie3:%.*]] = call i32 @dx.op.unaryBits.i16(i32 34, i16 [[ee3]])
; CHECK: [[rt0:%.*]] = insertelement <4 x i32> poison, i32 [[ie0]], i64 0
; CHECK: [[rt1:%.*]] = insertelement <4 x i32> [[rt0]], i32 [[ie1]], i64 1
; CHECK: [[rt2:%.*]] = insertelement <4 x i32> [[rt1]], i32 [[ie2]], i64 2
; CHECK: [[rt3:%.*]] = insertelement <4 x i32> [[rt2]], i32 [[ie3]], i64 3
; CHECK: ret <4 x i32> [[rt3]]
%2 = call <4 x i32> @llvm.dx.firstbitshigh.v4i16(<4 x i16> %a)
ret <4 x i32> %2
}

18
llvm/test/CodeGen/DirectX/firstbitlow.ll
View File

@ -33,10 +33,11 @@ entry:
; CHECK: [[ie2:%.*]] = call i32 @dx.op.unaryBits.i32(i32 32, i32 [[ee2]]) ; CHECK: [[ie2:%.*]] = call i32 @dx.op.unaryBits.i32(i32 32, i32 [[ee2]])
; CHECK: [[ee3:%.*]] = extractelement <4 x i32> %a, i64 3 ; CHECK: [[ee3:%.*]] = extractelement <4 x i32> %a, i64 3
; CHECK: [[ie3:%.*]] = call i32 @dx.op.unaryBits.i32(i32 32, i32 [[ee3]]) ; CHECK: [[ie3:%.*]] = call i32 @dx.op.unaryBits.i32(i32 32, i32 [[ee3]])
; CHECK: insertelement <4 x i32> poison, i32 [[ie0]], i64 0 ; CHECK: [[rt0:%.*]] = insertelement <4 x i32> poison, i32 [[ie0]], i64 0
; CHECK: insertelement <4 x i32> %{{.*}}, i32 [[ie1]], i64 1 ; CHECK: [[rt1:%.*]] = insertelement <4 x i32> [[rt0]], i32 [[ie1]], i64 1
; CHECK: insertelement <4 x i32> %{{.*}}, i32 [[ie2]], i64 2 ; CHECK: [[rt2:%.*]] = insertelement <4 x i32> [[rt1]], i32 [[ie2]], i64 2
; CHECK: insertelement <4 x i32> %{{.*}}, i32 [[ie3]], i64 3 ; CHECK: [[rt3:%.*]] = insertelement <4 x i32> [[rt2]], i32 [[ie3]], i64 3
; CHECK: ret <4 x i32> [[rt3]]
%2 = call <4 x i32> @llvm.dx.firstbitlow.v4i32(<4 x i32> %a) %2 = call <4 x i32> @llvm.dx.firstbitlow.v4i32(<4 x i32> %a)
ret <4 x i32> %2 ret <4 x i32> %2
} }
@ -51,10 +52,11 @@ entry:
; CHECK: [[ie2:%.*]] = call i32 @dx.op.unaryBits.i16(i32 32, i16 [[ee2]]) ; CHECK: [[ie2:%.*]] = call i32 @dx.op.unaryBits.i16(i32 32, i16 [[ee2]])
; CHECK: [[ee3:%.*]] = extractelement <4 x i16> %a, i64 3 ; CHECK: [[ee3:%.*]] = extractelement <4 x i16> %a, i64 3
; CHECK: [[ie3:%.*]] = call i32 @dx.op.unaryBits.i16(i32 32, i16 [[ee3]]) ; CHECK: [[ie3:%.*]] = call i32 @dx.op.unaryBits.i16(i32 32, i16 [[ee3]])
; CHECK: insertelement <4 x i32> poison, i32 [[ie0]], i64 0 ; CHECK: [[rt0:%.*]] = insertelement <4 x i32> poison, i32 [[ie0]], i64 0
; CHECK: insertelement <4 x i32> %{{.*}}, i32 [[ie1]], i64 1 ; CHECK: [[rt1:%.*]] = insertelement <4 x i32> [[rt0]], i32 [[ie1]], i64 1
; CHECK: insertelement <4 x i32> %{{.*}}, i32 [[ie2]], i64 2 ; CHECK: [[rt2:%.*]] = insertelement <4 x i32> [[rt1]], i32 [[ie2]], i64 2
; CHECK: insertelement <4 x i32> %{{.*}}, i32 [[ie3]], i64 3 ; CHECK: [[rt3:%.*]] = insertelement <4 x i32> [[rt2]], i32 [[ie3]], i64 3
; CHECK: ret <4 x i32> [[rt3]]
%2 = call <4 x i32> @llvm.dx.firstbitlow.v4i16(<4 x i16> %a) %2 = call <4 x i32> @llvm.dx.firstbitlow.v4i16(<4 x i16> %a)
ret <4 x i32> %2 ret <4 x i32> %2
} }