shylie/llvm-project
1
0
Fork 0
Code Issues Pull Requests Actions 6 Packages Projects Releases Wiki Activity

[orc-rt] Move CallViaSession into Session, add comments. (#187238)

Browse Source 
Makes CallViaSession an inner class on Session, and adds comments and a
convenience method for creating instances.
This commit is contained in:
Lang Hames 2026-03-18 22:17:04 +11:00 committed by GitHub
parent 003ec3e0a1
commit 2915519efd
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 32 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

43
orc-rt/include/orc-rt/Session.h
View File

@ -171,6 +171,11 @@ public:
/// Disconnect the ControllerAccess object.
void detach();
/// Call a tagged handler in the Controller.
///
/// This method can be called directly, but is expected to be more commonly
/// called by the WrapperFunction::call method using a CallViaSession object
/// (see below).
void callController(OnCallHandlerCompleteFn OnComplete, HandlerTag T,
WrapperFunctionBuffer ArgBytes) {
if (auto TmpCA = CA)
@ -180,6 +185,30 @@ public:
"no controller attached"));
}
/// Provides an async method interface to call, via the given Session, the
/// controller handler with the given tag.
///
/// Useable as a Caller implementation with WrapperFunction::call.
class CallViaSession {
public:
CallViaSession(Session &S, HandlerTag T) : S(S), T(T) {}
void operator()(OnCallHandlerCompleteFn &&HandleResult,
WrapperFunctionBuffer ArgBytes) {
S.callController(std::move(HandleResult), T, std::move(ArgBytes));
}
private:
Session &S;
HandlerTag T;
};
/// Get a WrapperFunction::call-compatible Caller that will call through to
/// the handler with the given tag.
CallViaSession callViaSession(HandlerTag T) noexcept {
return CallViaSession(*this, T);
}
private:
struct ShutdownInfo {
bool Complete = false;
@ -215,20 +244,6 @@ private:
std::unique_ptr<ShutdownInfo> SI;
};
class CallViaSession {
public:
CallViaSession(Session &S, Session::HandlerTag T) : S(S), T(T) {}
void operator()(Session::OnCallHandlerCompleteFn &&HandleResult,
WrapperFunctionBuffer ArgBytes) {
S.callController(std::move(HandleResult), T, std::move(ArgBytes));
}
private:
Session &S;
Session::HandlerTag T;
};
} // namespace orc_rt
#endif // ORC_RT_SESSION_H

6
orc-rt/unittests/SessionTest.cpp
View File

@ -420,7 +420,7 @@ TEST(ControllerAccessTest, ValidCallToController) {
int32_t Result = 0;
SPSWrapperFunction<int32_t(int32_t, int32_t)>::call(
CallViaSession(S, reinterpret_cast<Session::HandlerTag>(add_sps_wrapper)),
S.callViaSession(reinterpret_cast<Session::HandlerTag>(add_sps_wrapper)),
[&](Expected<int32_t> R) { Result = cantFail(std::move(R)); }, 41, 1);
EnqueueingDispatcher::runTasksFromFront(Tasks);
@ -438,7 +438,7 @@ TEST(ControllerAccessTest, CallToControllerBeforeAttach) {
Error Err = Error::success();
SPSWrapperFunction<int32_t(int32_t, int32_t)>::call(
CallViaSession(S, reinterpret_cast<Session::HandlerTag>(add_sps_wrapper)),
S.callViaSession(reinterpret_cast<Session::HandlerTag>(add_sps_wrapper)),
[&](Expected<int32_t> R) {
ErrorAsOutParameter _(Err);
Err = R.takeError();
@ -462,7 +462,7 @@ TEST(ControllerAccessTest, CallToControllerAfterDetach) {
Error Err = Error::success();
SPSWrapperFunction<int32_t(int32_t, int32_t)>::call(
CallViaSession(S, reinterpret_cast<Session::HandlerTag>(add_sps_wrapper)),
S.callViaSession(reinterpret_cast<Session::HandlerTag>(add_sps_wrapper)),
[&](Expected<int32_t> R) {
ErrorAsOutParameter _(Err);
Err = R.takeError();