shylie/llvm-project
1
0
Fork 0
Code Issues Pull Requests Actions 6 Packages Projects Releases Wiki Activity

Revert "[analyzer] Treat LValueBitCasts like regular pointer bit casts."

Browse Source 
This does not actually give us the right behavior for reinterpret_cast
of references. Reverting so I can think about it some more.

This reverts commit 50a75a6e26a49011150067adac556ef978639fe6.

llvm-svn: 158341
This commit is contained in:
Jordan Rose 2012-06-12 00:20:22 +00:00
parent 3e465fb225
commit 2fdc07ee89
4 changed files with 7 additions and 48 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
clang/lib/StaticAnalyzer/Core/ExprEngine.cpp
View File

@ -1641,7 +1641,7 @@ void ExprEngine::evalLoad(ExplodedNodeSet &Dst,
assert(!isa<NonLoc>(location) && "location cannot be a NonLoc.");
assert(!isa<loc::ObjCPropRef>(location));
// Are we loading from a reference? This actually results in two loads; one
// Are we loading from a region? This actually results in two loads; one
// to fetch the address of the referenced value and one to fetch the
// referenced value.
if (const TypedValueRegion *TR =

4
clang/lib/StaticAnalyzer/Core/ExprEngineC.cpp
View File

@ -279,7 +279,6 @@ void ExprEngine::VisitCast(const CastExpr *CastE, const Expr *Ex,
case CK_Dependent:
case CK_ArrayToPointerDecay:
case CK_BitCast:
case CK_LValueBitCast:
case CK_IntegralCast:
case CK_NullToPointer:
case CK_IntegralToPointer:
@ -378,7 +377,8 @@ void ExprEngine::VisitCast(const CastExpr *CastE, const Expr *Ex,
case CK_UserDefinedConversion:
case CK_ConstructorConversion:
case CK_VectorSplat:
case CK_MemberPointerToBoolean: {
case CK_MemberPointerToBoolean:
case CK_LValueBitCast: {
// Recover some path-sensitivty by conjuring a new value.
QualType resultType = CastE->getType();
if (CastE->isGLValue())

13
clang/lib/StaticAnalyzer/Core/RegionStore.cpp
View File

@ -878,15 +878,10 @@ SVal RegionStoreManager::ArrayToPointer(Loc Array) {
if (!ArrayR)
return UnknownVal();
// Extract the element type from the array region's ValueType.
// Be careful about weird things happening due to user-written casts.
QualType T = ArrayR->getValueType();
if (const ArrayType *AT = Ctx.getAsArrayType(T))
T = AT->getElementType();
else if (const PointerType *PT = T->getAs<PointerType>())
T = PT->getPointeeType();
else
return UnknownVal();
// Strip off typedefs from the ArrayRegion's ValueType.
QualType T = ArrayR->getValueType().getDesugaredType(Ctx);
const ArrayType *AT = cast<ArrayType>(T);
T = AT->getElementType();
NonLoc ZeroIdx = svalBuilder.makeZeroArrayIndex();
return loc::MemRegionVal(MRMgr.getElementRegion(T, ZeroIdx, ArrayR, Ctx));

36
clang/test/Analysis/casts.cpp
View File

@ -1,36 +0,0 @@
// RUN: %clang_cc1 -analyze -analyzer-checker=core,experimental.core -analyzer-store=region -verify %s
void fill_r (int * const &x);
char testPointer () {
int x[8];
int *xp = x;
fill_r(xp);
return x[0]; // no-warning
}
char testArray () {
int x[8];
fill_r(x);
return x[0]; // no-warning
}
char testReferenceCast () {
int x[8];
int *xp = x;
fill_r(reinterpret_cast<int * const &>(xp));
return x[0]; // no-warning
}
void fill (int *x);
char testReferenceCastRValue () {
int x[8];
int *xp = x;
fill(reinterpret_cast<int * const &>(xp));
return x[0]; // no-warning
}