shylie/llvm-project
1
0
Fork 0
Code Issues Pull Requests Actions 6 Packages Projects Releases Wiki Activity

[X86] canCreateUndefOrPoisonForTargetNode - add GF2P8AFFINEINVQB / GF2P8AFFINEQB / GF2P8MULB handling (#155409)

Browse Source 
All 3 instructions are well defined bit twiddling operations - they do
not introduce undef/poison with well defined inputs.

Fixes regressions in #152107
This commit is contained in:
Simon Pilgrim 2025-08-26 15:07:35 +01:00 committed by GitHub
parent 62ac4e3014
commit 343e944c07
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
llvm/lib/Target/X86/X86ISelLowering.cpp
View File

@ -45167,6 +45167,11 @@ bool X86TargetLowering::canCreateUndefOrPoisonForTargetNode(
// SSE signbit extraction.
case X86ISD::MOVMSK:
return false;
// GFNI instructions.
case X86ISD::GF2P8AFFINEINVQB:
case X86ISD::GF2P8AFFINEQB:
case X86ISD::GF2P8MULB:
return false;
case ISD::INTRINSIC_WO_CHAIN:
switch (Op->getConstantOperandVal(0)) {
case Intrinsic::x86_sse2_pmadd_wd:

9
llvm/test/CodeGen/X86/combine-gfni.ll
View File

@ -24,8 +24,7 @@ define <16 x i8> @gf2p8affineqb_freeze(<16 x i8> %a0, <16 x i8> %a1, <16 x i8> %
; AVX512-LABEL: gf2p8affineqb_freeze:
; AVX512: # %bb.0:
; AVX512-NEXT: vpmovb2m %xmm2, %k1
; AVX512-NEXT: vgf2p8affineqb $11, %xmm1, %xmm1, %xmm1
; AVX512-NEXT: vmovdqu8 %xmm1, %xmm0 {%k1}
; AVX512-NEXT: vgf2p8affineqb $11, %xmm1, %xmm1, %xmm0 {%k1}
; AVX512-NEXT: retq
%i = icmp slt <16 x i8> %a2, zeroinitializer
%g = call <16 x i8> @llvm.x86.vgf2p8affineqb.128(<16 x i8> %a1, <16 x i8> %a1, i8 11)
@ -55,8 +54,7 @@ define <16 x i8> @gf2p8affineinvqb_freeze(<16 x i8> %a0, <16 x i8> %a1, <16 x i8
; AVX512-LABEL: gf2p8affineinvqb_freeze:
; AVX512: # %bb.0:
; AVX512-NEXT: vpmovb2m %xmm2, %k1
; AVX512-NEXT: vgf2p8affineinvqb $11, %xmm1, %xmm1, %xmm1
; AVX512-NEXT: vmovdqu8 %xmm1, %xmm0 {%k1}
; AVX512-NEXT: vgf2p8affineinvqb $11, %xmm1, %xmm1, %xmm0 {%k1}
; AVX512-NEXT: retq
%i = icmp slt <16 x i8> %a2, zeroinitializer
%g = call <16 x i8> @llvm.x86.vgf2p8affineinvqb.128(<16 x i8> %a1, <16 x i8> %a1, i8 11)
@ -86,8 +84,7 @@ define <16 x i8> @gf2p8mulb_freeze(<16 x i8> %a0, <16 x i8> %a1, <16 x i8> %a2)
; AVX512-LABEL: gf2p8mulb_freeze:
; AVX512: # %bb.0:
; AVX512-NEXT: vpmovb2m %xmm2, %k1
; AVX512-NEXT: vgf2p8mulb %xmm1, %xmm1, %xmm1
; AVX512-NEXT: vmovdqu8 %xmm1, %xmm0 {%k1}
; AVX512-NEXT: vgf2p8mulb %xmm1, %xmm1, %xmm0 {%k1}
; AVX512-NEXT: retq
%i = icmp slt <16 x i8> %a2, zeroinitializer
%g = call <16 x i8> @llvm.x86.vgf2p8mulb.128(<16 x i8> %a1, <16 x i8> %a1)