shylie/llvm-project
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

libclc: Fix signed integer underflow in abs_diff

Browse Source 
We noticed this same issue in our own implementation of abs_diff, and
the same issue also came up in the abs_diff reference function in the
OpenCL CTS.

Reviewed By: rjodinchr

Differential Revision: https://reviews.llvm.org/D159275
This commit is contained in:
Fraser Cormack 2023-08-31 13:41:53 +01:00
parent 27313b68ef
commit 37a3de1e2e
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
libclc/generic/lib/integer/abs_diff.inc
View File

@ -1,3 +1,5 @@
_CLC_OVERLOAD _CLC_DEF __CLC_U_GENTYPE abs_diff(__CLC_GENTYPE x, __CLC_GENTYPE y) {
return __builtin_astype((__CLC_GENTYPE)(x > y ? x-y : y-x), __CLC_U_GENTYPE);
__CLC_U_GENTYPE ux = __builtin_astype(x, __CLC_U_GENTYPE);
__CLC_U_GENTYPE uy = __builtin_astype(y, __CLC_U_GENTYPE);
return x > y ? ux - uy : uy - ux;
}