shylie/llvm-project
1
0
Fork 0
Code Issues Pull Requests Actions 6 Packages Projects Releases Wiki Activity

[Flang-RT][unittests] Fix buffer over-read (#182176)

Browse Source 
The unittests `Reductions.InfSums` defines a test array descriptor with
shape 2x3 (i.e. 6 elements), but only provides values for 2 elements.
The result is access of likely uninitialized memory when accessing the
additional 4 elements. In most cases the additional values get gobbled
up by the infinity, but if it happens to be NaN or the negated infinity,
the result becomes NaN and fails the test.

Fix by reducing the shabe of the test array to 2. Fixes the flakyness of
the test of the flang-x86_64-windows buildbot.
This commit is contained in:
Michael Kruse 2026-02-20 09:31:39 +01:00 committed by GitHub
parent 2619cad4c2
commit 398bd9543b
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
flang-rt/unittests/Runtime/Reduction.cpp
View File

@ -676,15 +676,15 @@ TEST(Reductions, ReduceInt4Dim) {
TEST(Reductions, InfSums) {
auto inf{std::numeric_limits<float>::infinity()};
auto inf0{MakeArray<TypeCategory::Real, 4>(
std::vector<int>{2, 3}, std::vector<float>{inf, 0.0f})};
std::vector<int>{2}, std::vector<float>{inf, 0.0f})};
auto t1{RTNAME(SumReal4)(*inf0, __FILE__, __LINE__)};
EXPECT_EQ(t1, inf) << t1;
auto infMinusInf{MakeArray<TypeCategory::Real, 4>(
std::vector<int>{2, 3}, std::vector<float>{inf, -inf})};
std::vector<int>{2}, std::vector<float>{inf, -inf})};
auto t2{RTNAME(SumReal4)(*infMinusInf, __FILE__, __LINE__)};
EXPECT_NE(t2, t2) << t2;
auto minusInfInf{MakeArray<TypeCategory::Real, 4>(
std::vector<int>{2, 3}, std::vector<float>{-inf, inf})};
std::vector<int>{2}, std::vector<float>{-inf, inf})};
auto t3{RTNAME(SumReal4)(*infMinusInf, __FILE__, __LINE__)};
EXPECT_NE(t3, t3) << t3;
}