shylie/llvm-project
1
0
Fork 0
Code Issues Pull Requests Actions 6 Packages Projects Releases Wiki Activity

[ConstraintElimination] Do not crash on vector GEP in decomposeGEP

Browse Source 
Commit 359bc5c541ae4b02 caused
 Assertion `isa<To>(Val) && "cast<Ty>() argument of incompatible type!"'
failures in decomposeGEP when the GEP pointer operand is a vector.

Fix is to use DataLayout::getIndexTypeSizeInBits when fetching the
index size, as it will use the scalar type in case of a ptr vector.

Differential Revision: https://reviews.llvm.org/D137185
This commit is contained in:
Bjorn Pettersson 2022-11-01 19:55:23 +01:00
parent 9a9b904b87
commit 44bb4099cd
2 changed files with 15 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
llvm/lib/Transforms/Scalar/ConstraintElimination.cpp
View File

@ -209,9 +209,7 @@ decomposeGEP(GetElementPtrInst &GEP,
const DataLayout &DL) {
// Do not reason about pointers where the index size is larger than 64 bits,
// as the coefficients used to encode constraints are 64 bit integers.
unsigned AS =
cast<PointerType>(GEP.getPointerOperand()->getType())->getAddressSpace();
if (DL.getIndexSizeInBits(AS) > 64)
if (DL.getIndexTypeSizeInBits(GEP.getPointerOperand()->getType()) > 64)
return {};
if (!GEP.isInBounds())

14
llvm/test/Transforms/ConstraintElimination/geps-ptrvector.ll Normal file
View File

@ -0,0 +1,14 @@
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
; RUN: opt -passes=constraint-elimination -S %s | FileCheck %s
; Should not crash when GEP pointer operand is a vector.
define <2 x i1> @test.vectorgep(<2 x ptr> %vec) {
; CHECK-LABEL: @test.vectorgep(
; CHECK-NEXT: [[GEP:%.*]] = getelementptr inbounds i32, <2 x ptr> [[VEC:%.*]], i64 0
; CHECK-NEXT: [[COND:%.*]] = icmp ule <2 x ptr> [[GEP]], zeroinitializer
; CHECK-NEXT: ret <2 x i1> [[COND]]
;
%gep = getelementptr inbounds i32, <2 x ptr> %vec, i64 0
%cond = icmp ule <2 x ptr> %gep, zeroinitializer
ret <2 x i1> %cond
}