shylie/llvm-project
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[flang] Control alignment of constant folded reals (#149381)

Browse Source 
When REAL types are constant folded, the underneath implementation uses
arrays of integers. Ensure that these arrays are properly aligned.

This matters when building flang with clang. In some cases, the
resulting code for flang compiler ended up using SSE2 aligned load
instructions for REAL(16) constant folding on x86_64, and these
instructions require that the values are loaded from the aligned
addresses.
This commit is contained in:
Eugene Epshteyn 2025-07-21 16:51:52 -04:00 committed by GitHub
parent 2a78c6d45d
commit 45a6c02c21
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
flang/include/flang/Evaluate/integer.h
View File

@ -74,6 +74,7 @@ public:
static_assert(std::is_unsigned_v<BigPart>);
static_assert(CHAR_BIT * sizeof(BigPart) >= 2 * partBits);
static constexpr bool littleEndian{IS_LITTLE_ENDIAN};
static constexpr int alignment{ALIGNMENT};
private:
static constexpr int maxPartBits{CHAR_BIT * sizeof(Part)};

5
flang/include/flang/Evaluate/real.h
View File

@ -490,7 +490,10 @@ private:
bool isNegative, int exponent, const Fraction &, Rounding, RoundingBits,
bool multiply = false);
Word word_{}; // an Integer<>
// Require alignment, in case code generation on x86_64 decides that our
// Real object is suitable for SSE2 instructions and then gets surprised
// by unaligned address.
alignas(Word::alignment / 8) Word word_{}; // an Integer<>
};
extern template class Real<Integer<16>, 11>; // IEEE half format