shylie/llvm-project
1
0
Fork 0
Code Issues Pull Requests Actions 6 Packages Projects Releases Wiki Activity

Revert "[compiler-rt][test] Apply CFLAGS from sanitizer_common to all tests" (#152177)

Browse Source 
Reverts llvm/llvm-project#120798 because it caused an AddressSanitizer
test breakage in global-overflow-bfd.cpp:

https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8707434189452310849/overview
This commit is contained in:
gulfemsavrun 2025-08-05 10:15:27 -07:00 committed by GitHub
parent 406f61fd3a
commit 4a13f0912a
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 11 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
compiler-rt/cmake/config-ix.cmake
View File

@ -309,14 +309,6 @@ macro(get_test_cc_for_arch arch cc_out cflags_out)
endif()
string(REPLACE ";" " " ${cflags_out} "${${cflags_out}}")
endif()
if(CMAKE_SYSTEM_NAME STREQUAL "Linux" AND NOT ANDROID)
# ARM on Linux might use the slow unwinder as default and the unwind table
# is required to get a complete stacktrace.
string(APPEND ${cflags_out} " -funwind-tables")
if(CMAKE_SYSROOT)
string(APPEND ${cflags_out} " --sysroot=${CMAKE_SYSROOT}")
endif()
endif()
endmacro()
# Returns CFLAGS that should be used to run tests for the

11
compiler-rt/test/sanitizer_common/CMakeLists.txt
View File

@ -73,6 +73,17 @@ foreach(tool ${SUPPORTED_TOOLS})
get_test_cc_for_arch(${arch} SANITIZER_COMMON_TEST_TARGET_CC SANITIZER_COMMON_TEST_TARGET_CFLAGS)
set(CONFIG_NAME ${tool}-${arch}-${OS_NAME})
# ARM on Linux might use the slow unwinder as default and the unwind table is
# required to get a complete stacktrace.
if ("${CMAKE_SYSTEM_NAME}" STREQUAL "Linux" AND NOT ANDROID)
list(APPEND SANITIZER_COMMON_TEST_TARGET_CFLAGS -funwind-tables)
if(CMAKE_SYSROOT)
list(APPEND SANITIZER_COMMON_TEST_TARGET_CFLAGS "--sysroot=${CMAKE_SYSROOT}")
endif()
string(REPLACE ";" " " SANITIZER_COMMON_TEST_TARGET_CFLAGS
"${SANITIZER_COMMON_TEST_TARGET_CFLAGS}")
endif()
configure_lit_site_cfg(
${CMAKE_CURRENT_SOURCE_DIR}/lit.site.cfg.py.in
${CMAKE_CURRENT_BINARY_DIR}/${CONFIG_NAME}/lit.site.cfg.py)