shylie/llvm-project
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[Assignment Tracking][mem2reg] Remove overly defensive assert

Browse Source 
The assert fires if a store to an alloca with no linked dbg.assigns has linked
dbg.assigns. This can happen in the wild due to optimisations dropping the
alloca's debug info so we shouldn't assert against it.

Reviewed By: jryans

Differential Revision: https://reviews.llvm.org/D143153
This commit is contained in:
OCHyams 2023-02-10 09:27:37 +00:00
parent bb059e85d6
commit 4ad8f7a189
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
llvm/lib/Transforms/Utils/PromoteMemoryToRegister.cpp
View File

@ -121,10 +121,8 @@ public:
void updateForDeletedStore(StoreInst *ToDelete, DIBuilder &DIB) const {
// There's nothing to do if the alloca doesn't have any variables using
// assignment tracking.
if (DbgAssigns.empty()) {
assert(at::getAssignmentMarkers(ToDelete).empty());
if (DbgAssigns.empty())
return;
}
// Just leave dbg.assign intrinsics in place and remember that we've seen
// one for each variable fragment.