From 4ebb01cbcb3a9566fa0684eac5bdb232d9dc91fe Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20Storsj=C3=B6?= Date: Tue, 6 Apr 2021 11:37:52 +0300 Subject: [PATCH] [libcxx] [test] Convert a couple of LIBCXX-WINDOWS-FIXME into XFAIL: windows-dll for known bugs These are caused due to inconsistencies regarding always inline in combination with dllimport. A bug report reference is added next to each XFAIL line. Differential Revision: https://reviews.llvm.org/D100789 --- .../category.collate/locale.collate.byname/hash.pass.cpp | 3 ++- .../locale.collate/locale.collate.members/compare.pass.cpp | 5 +++-- .../locale.collate/locale.collate.members/hash.pass.cpp | 5 +++-- .../locales/locale/locale.operators/compare.pass.cpp | 3 ++- 4 files changed, 10 insertions(+), 6 deletions(-) diff --git a/libcxx/test/std/localization/locale.categories/category.collate/locale.collate.byname/hash.pass.cpp b/libcxx/test/std/localization/locale.categories/category.collate/locale.collate.byname/hash.pass.cpp index dbf50c12ff2e..8be36e3bd1fd 100644 --- a/libcxx/test/std/localization/locale.categories/category.collate/locale.collate.byname/hash.pass.cpp +++ b/libcxx/test/std/localization/locale.categories/category.collate/locale.collate.byname/hash.pass.cpp @@ -8,7 +8,8 @@ // REQUIRES: locale.en_US.UTF-8 -// XFAIL: LIBCXX-WINDOWS-FIXME +// https://llvm.org/PR41018 +// XFAIL: windows-dll // diff --git a/libcxx/test/std/localization/locale.categories/category.collate/locale.collate/locale.collate.members/compare.pass.cpp b/libcxx/test/std/localization/locale.categories/category.collate/locale.collate/locale.collate.members/compare.pass.cpp index 0a255a5b64f7..7e2833b436bc 100644 --- a/libcxx/test/std/localization/locale.categories/category.collate/locale.collate/locale.collate.members/compare.pass.cpp +++ b/libcxx/test/std/localization/locale.categories/category.collate/locale.collate/locale.collate.members/compare.pass.cpp @@ -6,6 +6,9 @@ // //===----------------------------------------------------------------------===// +// https://llvm.org/PR41018 +// XFAIL: windows-dll + // // template class collate; @@ -13,8 +16,6 @@ // int compare(const charT* low1, const charT* high1, // const charT* low2, const charT* high2) const; -// XFAIL: LIBCXX-WINDOWS-FIXME - #include #include diff --git a/libcxx/test/std/localization/locale.categories/category.collate/locale.collate/locale.collate.members/hash.pass.cpp b/libcxx/test/std/localization/locale.categories/category.collate/locale.collate/locale.collate.members/hash.pass.cpp index 2858ab02bffe..777ba4b4c6da 100644 --- a/libcxx/test/std/localization/locale.categories/category.collate/locale.collate/locale.collate.members/hash.pass.cpp +++ b/libcxx/test/std/localization/locale.categories/category.collate/locale.collate/locale.collate.members/hash.pass.cpp @@ -6,6 +6,9 @@ // //===----------------------------------------------------------------------===// +// https://llvm.org/PR41018 +// XFAIL: windows-dll + // // template class collate; @@ -14,8 +17,6 @@ // This test is not portable -// XFAIL: LIBCXX-WINDOWS-FIXME - #include #include #include diff --git a/libcxx/test/std/localization/locales/locale/locale.operators/compare.pass.cpp b/libcxx/test/std/localization/locales/locale/locale.operators/compare.pass.cpp index 001d834adc75..f912dc63a2e9 100644 --- a/libcxx/test/std/localization/locales/locale/locale.operators/compare.pass.cpp +++ b/libcxx/test/std/localization/locales/locale/locale.operators/compare.pass.cpp @@ -6,7 +6,8 @@ // //===----------------------------------------------------------------------===// -// XFAIL: LIBCXX-WINDOWS-FIXME +// https://llvm.org/PR41018 +// XFAIL: windows-dll //