shylie/llvm-project
1
0
Fork 0
Code Issues Pull Requests Actions 6 Packages Projects Releases Wiki Activity

[clang-tools-extra] Remove redundant declarations (NFC) (#166894)

Browse Source 
In C++17, static constexpr members are implicitly inline, so they no
longer require an out-of-line definition.

Identified with readability-redundant-declaration.
This commit is contained in:
Kazu Hirata 2025-11-07 07:58:32 -08:00 committed by GitHub
parent bddab8359e
commit 563ea29932
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
5 changed files with 0 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
clang-tools-extra/clang-doc/BitcodeWriter.cpp
View File

@ -303,8 +303,6 @@ static const std::vector<std::pair<BlockId, std::vector<RecordId>>>
// AbbreviationMap
constexpr unsigned char BitCodeConstants::Signature[];
void ClangDocBitcodeWriter::AbbreviationMap::add(RecordId RID,
unsigned AbbrevID) {
assert(RecordIdNameMap[RID] && "Unknown RecordId.");

1
clang-tools-extra/clangd/ClangdLSPServer.cpp
View File

@ -456,7 +456,6 @@ private:
ClangdLSPServer &Server;
};
constexpr int ClangdLSPServer::MessageHandler::MaxReplayCallbacks;
// call(), notify(), and reply() wrap the Transport, adding logging and locking.
void ClangdLSPServer::callMethod(StringRef Method, llvm::json::Value Params,

1
clang-tools-extra/clangd/FileDistance.cpp
View File

@ -54,7 +54,6 @@ static llvm::SmallString<128> canonicalize(llvm::StringRef Path) {
return Result;
}
constexpr const unsigned FileDistance::Unreachable;
const llvm::hash_code FileDistance::RootHash =
llvm::hash_value(llvm::StringRef("/"));

3
clang-tools-extra/clangd/FuzzyMatch.cpp
View File

@ -62,9 +62,6 @@
namespace clang {
namespace clangd {
constexpr int FuzzyMatcher::MaxPat;
constexpr int FuzzyMatcher::MaxWord;
static char lower(char C) { return C >= 'A' && C <= 'Z' ? C + ('a' - 'A') : C; }
// A "negative infinity" score that won't overflow.
// We use this to mark unreachable states and forbidden solutions.

3
clang-tools-extra/clangd/index/SymbolLocation.cpp
View File

@ -11,9 +11,6 @@
namespace clang {
namespace clangd {
constexpr uint32_t SymbolLocation::Position::MaxLine;
constexpr uint32_t SymbolLocation::Position::MaxColumn;
void SymbolLocation::Position::setLine(uint32_t L) {
if (L > MaxLine)
L = MaxLine;