shylie/llvm-project
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[Clang] Fix warning on synthetic offload arch argument in host only mode (#151969)

Browse Source 
Summary:
These arguments are synthetically generated and should always be
considered used. This was emitting a warning on the new driver.
This commit is contained in:
Joseph Huber 2025-08-06 07:30:07 -05:00 committed by GitHub
parent 97cf061e83
commit 56ba1181e9
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
clang/lib/Driver/Driver.cpp
View File

@ -1012,6 +1012,7 @@ inferOffloadToolchains(Compilation &C, Action::OffloadKind Kind) {
Arg *A = new Arg(Opt, C.getArgs().getArgString(Index), Index, Arg *A = new Arg(Opt, C.getArgs().getArgString(Index), Index,
C.getArgs().MakeArgString(Triple.split("-").first), C.getArgs().MakeArgString(Triple.split("-").first),
C.getArgs().MakeArgString("--offload-arch=" + Arch)); C.getArgs().MakeArgString("--offload-arch=" + Arch));
A->claim();
C.getArgs().append(A); C.getArgs().append(A);
C.getArgs().AddSynthesizedArg(A); C.getArgs().AddSynthesizedArg(A);
Triples.insert(Triple); Triples.insert(Triple);

2
clang/test/Driver/hip-options.hip
View File

@ -241,7 +241,7 @@
// Check --offload-compress --offload-jobs=N does not cause warning. // Check --offload-compress --offload-jobs=N does not cause warning.
// RUN: %clang -### -Werror --target=x86_64-unknown-linux-gnu -nogpuinc -nogpulib \ // RUN: %clang -### -Werror --target=x86_64-unknown-linux-gnu -nogpuinc -nogpulib \
// RUN: --offload-arch=gfx1100 --offload-compress --offload-host-only -M %s \ // RUN: --offload-arch=gfx1100 --offload-compress --offload-host-only -M %s \
// RUN: --offload-jobs=4 // RUN: --offload-jobs=4 --offload-new-driver
// Check --offload-jobs=N option. // Check --offload-jobs=N option.